GameCult/Thing
Watch
9
0
Fork
You've already forked Thing
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CI: install eve-contracts dependencies before a package that links it #3

Closed
libby wants to merge 2 commits from libby/ci-install-eve-contracts into main
pull from: libby/ci-install-eve-contracts
merge into: GameCult:main
Conversation 1 Commits 2 Files changed 1 +8
libby commented 2026-11-09 15:24:41 +00:00
Member
Copy link

eve-browser-lowering links @gamecult/eve-contracts as file:../eve-contracts (package.json:12). npm installs none of a linked package's dependencies, and tsc resolves the declarations from the real path packages/eve-contracts/dist, where ajv is not installed in that matrix leg. The leg fails on main with TS2307: Cannot find module 'ajv/dist/2020.js'.

Fix: portable-contracts.yml runs npm ci in packages/eve-contracts before the matrix package's own install (skipped for the eve-contracts leg itself). No package or lockfile change; runs-on is unchanged (the label change is Thing PR #2).

Reproduced in a scratch tree at main: npm ci then npm test in eve-browser-lowering fails with TS2307; after npm ci in eve-contracts first, eve-browser-lowering passes (23 pass, 0 fail) and the eve-contracts leg passes (10 pass, 0 fail). The workflow was not run on the forge.

Separate, not in this PR: the runner image has no pwsh, so the shell: pwsh step ("Reject stale generated output") exits 127 on the runner (Eureka's image).

🤖 Generated with Claude Code

`eve-browser-lowering` links `@gamecult/eve-contracts` as `file:../eve-contracts` (package.json:12). npm installs none of a linked package's dependencies, and `tsc` resolves the declarations from the real path `packages/eve-contracts/dist`, where `ajv` is not installed in that matrix leg. The leg fails on main with `TS2307: Cannot find module 'ajv/dist/2020.js'`. Fix: `portable-contracts.yml` runs `npm ci` in `packages/eve-contracts` before the matrix package's own install (skipped for the eve-contracts leg itself). No package or lockfile change; `runs-on` is unchanged (the label change is Thing PR #2). Reproduced in a scratch tree at main: `npm ci` then `npm test` in eve-browser-lowering fails with TS2307; after `npm ci` in eve-contracts first, eve-browser-lowering passes (23 pass, 0 fail) and the eve-contracts leg passes (10 pass, 0 fail). The workflow was not run on the forge. Separate, not in this PR: the runner image has no `pwsh`, so the `shell: pwsh` step ("Reject stale generated output") exits 127 on the runner (Eureka's image). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
CI: install eve-contracts dependencies before a package that links it
Some checks failed
Portable Eve contracts and browser lowering / ubuntu-latest eve-browser-lowering (pull_request) Failing after 32s
Details
Portable Eve contracts and browser lowering / ubuntu-latest eve-contracts (pull_request) Failing after 34s
Details
Portable Eve contracts and browser lowering / windows-latest eve-browser-lowering (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / windows-latest eve-contracts (pull_request) Has been cancelled
Details
3bedaf3d8a 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ci: retrigger (run 851 died at checkout, git exit 128)
Some checks failed
Portable Eve contracts and browser lowering / ubuntu-latest eve-browser-lowering (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / ubuntu-latest eve-contracts (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / windows-latest eve-browser-lowering (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / windows-latest eve-contracts (pull_request) Has been cancelled
Details
f0bff08e42 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
libby commented 2026-11-09 22:57:55 +00:00
Author
Member
Copy link

Closing as redundant: the eve-contracts install fix is on #2 as 27161af, and #2 makes the Windows leg dispatch-only. Closing also cancels run 921 (its windows-latest jobs have no runner).

Closing as redundant: the eve-contracts install fix is on #2 as 27161af, and #2 makes the Windows leg dispatch-only. Closing also cancels run 921 (its windows-latest jobs have no runner).
libby closed this pull request 2026-11-09 22:57:55 +00:00
Some checks failed
Portable Eve contracts and browser lowering / ubuntu-latest eve-browser-lowering (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / ubuntu-latest eve-contracts (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / windows-latest eve-browser-lowering (pull_request) Has been cancelled
Details
Portable Eve contracts and browser lowering / windows-latest eve-contracts (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Thing!3
No description provided.