GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions 1

auth: test the emitted footer rule; wrap comment; correct the terrain luminance figure #62

Merged
void merged 2 commits from void/footer-lows into dev 2026-11-10 04:04:15 +00:00
Conversation 0 Commits 2 Files changed 5 +84 -6
void commented 2026-11-10 03:48:37 +00:00
Member
Copy link

Libby's lows on #61 (merged as 30ae5154; follow-up chat-s5444-5444). Base dev 30ae5154.

  • styles.css.ts: the footer comment wrapped under 120 columns.
  • footerBand.test.ts (new): reads the CSS vanilla-extract emits for styles.css.ts and asserts one footer rule over the scene, the plain var(--sky-bubble, #0d1a26) fill before the color-mix one, a mask faded on both axes with mask-composite: intersect, a blur, and no border or radius. Mutations each fail it (1 of 3 tests): fills in the wrong order, a borderRadius added, a second footer rule appended, the side fade removed. @vanilla-extract/integration 6.5.0 (already in the tree, transitive) becomes a devDependency because the test imports it.
  • skyPlate.ts: the 0.0045 figure is struck. It was Night's whole-frame minimum, not the terrain behind the footer. Measured from the saved shots (A/B-full-*, rows 1480 to 1688, the footer's region, 390x844@2x, terrain scene, tier low): darkest pixel Dusk 0.0203, Day 0.0936 (dark ink), Night 0.0052 (light ink). The comment now says that and gives the measured worst link contrast with the band (Dusk 5.0, Day 5.7, Night 11.2). Those were the final (#61 head) numbers; the footer band was measured at 0.82 tint on previews, the shots exist for one camera only.
  • Review round 2 (head see PR): compile gets identOption: 'debug' (TS2345 fixed). Mutants, all killed (each fails 1 of 5 tests): fills reversed, radius in the scene rule, second scene rule, side fade removed, blur(0px), border in the base .AuthFooter rule, radius in the base rule, hard-stop Y fade (0px), near-hard X fade (1px). New assertions: nonzero blur radius, soft ramp of at least 8px on both axes, no border/outline/radius in base or scene rule.
  • tsc --noEmit: 799 errors at dev 30ae5154 and 799 at this head on the same lockfile (an earlier report here of 'tsc clean' was wrong: the repo does not typecheck clean, 799 pre-existing errors, mostly matrix-js-sdk types); this head's earlier version added one (footerBand.test.ts TS2345, 800), the new head adds none.
  • Counts, honestly: the earlier 380 was src/app/features/scene + src/app/pages/auth only, on a copied node_modules. After a fresh npm ci (rc 0) the full suite is 42 files, 595 tests, all passed (including this PR's 5 footerBand tests). tsc --noEmit is not clean: it reports 799 errors at dev 30ae5154 and 799 at this head, and the two sorted error lists are identical (diff empty); this PR adds none. eslint and prettier are clean on the touched files.

No preview built or touched; named previews unchanged.

🤖 Generated with Claude Code

Libby's lows on #61 (merged as 30ae5154; follow-up chat-s5444-5444). Base dev 30ae5154. - `styles.css.ts`: the footer comment wrapped under 120 columns. - `footerBand.test.ts` (new): reads the CSS vanilla-extract emits for `styles.css.ts` and asserts one footer rule over the scene, the plain `var(--sky-bubble, #0d1a26)` fill before the `color-mix` one, a mask faded on both axes with `mask-composite: intersect`, a blur, and no border or radius. Mutations each fail it (1 of 3 tests): fills in the wrong order, a `borderRadius` added, a second footer rule appended, the side fade removed. `@vanilla-extract/integration` 6.5.0 (already in the tree, transitive) becomes a devDependency because the test imports it. - `skyPlate.ts`: the 0.0045 figure is struck. It was Night's whole-frame minimum, not the terrain behind the footer. Measured from the saved shots (A/B-full-*, rows 1480 to 1688, the footer's region, 390x844@2x, terrain scene, tier low): darkest pixel Dusk 0.0203, Day 0.0936 (dark ink), Night 0.0052 (light ink). The comment now says that and gives the measured worst link contrast with the band (Dusk 5.0, Day 5.7, Night 11.2). Those were the final (#61 head) numbers; the footer band was measured at 0.82 tint on previews, the shots exist for one camera only. - Review round 2 (head see PR): `compile` gets `identOption: 'debug'` (TS2345 fixed). Mutants, all killed (each fails 1 of 5 tests): fills reversed, radius in the scene rule, second scene rule, side fade removed, `blur(0px)`, border in the base `.AuthFooter` rule, radius in the base rule, hard-stop Y fade (0px), near-hard X fade (1px). New assertions: nonzero blur radius, soft ramp of at least 8px on both axes, no border/outline/radius in base or scene rule. - `tsc --noEmit`: **799 errors at dev 30ae5154 and 799 at this head** on the same lockfile (an earlier report here of 'tsc clean' was wrong: the repo does not typecheck clean, 799 pre-existing errors, mostly matrix-js-sdk types); this head's earlier version added one (footerBand.test.ts TS2345, 800), the new head adds none. - Counts, honestly: the earlier 380 was `src/app/features/scene` + `src/app/pages/auth` only, on a copied node_modules. After a fresh `npm ci` (rc 0) the full suite is 42 files, 595 tests, all passed (including this PR's 5 footerBand tests). `tsc --noEmit` is not clean: it reports 799 errors at dev 30ae5154 and 799 at this head, and the two sorted error lists are identical (diff empty); this PR adds none. eslint and prettier are clean on the touched files. No preview built or touched; named previews unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
auth: test the emitted footer rule; wrap its comment; correct the terrain luminance figure
Some checks failed
Build pull request / Build pull request (pull_request) Has been cancelled
Details
NPM Lockfile Changes / lockfile_changes (pull_request) Has been cancelled
Details
271729a5c0 
footerBand.test.ts reads the CSS vanilla-extract emits for styles.css.ts (so
@vanilla-extract/integration becomes a devDependency): one footer rule, the plate fill before
the color-mix fill, a mask faded on both axes, no border or radius. skyPlate.ts no longer
claims the darkest terrain is 0.0045 (that was Night's whole frame); it states the footer
region's minima per state and the measured link contrast.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
auth: footerBand test: identOption for compile; kill blur(0), base-rule border, hard-stop survivors
Some checks failed
Build pull request / Build pull request (pull_request) Successful in 2m48s
Details
NPM Lockfile Changes / lockfile_changes (pull_request) Failing after 1s
Details
b5e93510e8 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
void merged commit 7494591624 into dev 2026-11-10 04:04:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!62
No description provided.