GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Files desk cut 4: add files to an open album, named upload refusals #150

Merged
void merged 2 commits from void/files-desk-cut4 into dev 2026-11-13 23:11:36 +00:00
Conversation 0 Commits 2 Files changed 10 +170 -33
void commented 2026-11-13 23:05:38 +00:00
Member
Copy link

Cut 5 of the doc's list, fourth PR of follow-up ratatoskr:follow_up:files-desk-cuts-2-5-and-release-146.

  • sendShareSet(port, into: string | ExistingAlbum, files): an existing album sends no root; the first file threads after lastEventId(album).
  • refusalOf: sentences for M_TOO_LARGE, M_FORBIDDEN, M_LIMIT_EXCEEDED, shown beside each failed file in the note.
  • ShareSet into prop and adding view mode (no title field, Add files ›); AlbumView mounts it inside an open album (behind fileZoneShare.enabled, as the folder panel).

Not built: cancel of a send in flight (needs an abort path through uploadContent); the progress is the existing Sending N of M. The add panel unmounts when leaving the album; the send continues (the room lock is module-level) but its progress is not shown elsewhere. Untested: against a real homeserver refusal (errcode read from a thrown MatrixError by shape).

🤖 Generated with Claude Code

Cut 5 of the doc's list, fourth PR of follow-up `ratatoskr:follow_up:files-desk-cuts-2-5-and-release-146`. - `sendShareSet(port, into: string | ExistingAlbum, files)`: an existing album sends no root; the first file threads after `lastEventId(album)`. - `refusalOf`: sentences for M_TOO_LARGE, M_FORBIDDEN, M_LIMIT_EXCEEDED, shown beside each failed file in the note. - `ShareSet` `into` prop and `adding` view mode (no title field, `Add files ›`); AlbumView mounts it inside an open album (behind `fileZoneShare.enabled`, as the folder panel). Not built: cancel of a send in flight (needs an abort path through `uploadContent`); the progress is the existing `Sending N of M`. The add panel unmounts when leaving the album; the send continues (the room lock is module-level) but its progress is not shown elsewhere. Untested: against a real homeserver refusal (errcode read from a thrown MatrixError by shape). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Files desk cut 4: add files to an open album; name the upload refusals
Some checks failed
Build pull request / Build pull request (pull_request) Has been cancelled
Details
0622d7d65d 
sendShareSet takes a title or an existing album (no new root; the first file threads after the album's newest event). Failed files carry the refusal for M_TOO_LARGE, M_FORBIDDEN and M_LIMIT_EXCEEDED in the result note. AlbumView mounts an Add files panel inside an open album.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cut 4: pin that ShareSet sends into an existing album
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 5m22s
Details
90c6d5e278 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
void merged commit d12e7bd578 into dev 2026-11-13 23:11:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!150
No description provided.