GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Phone hit: message content and data editors (group 10) #138

Merged
void merged 2 commits from void/phone-hit-content into dev 2026-11-13 13:26:44 +00:00
Conversation 0 Commits 2 Files changed 6 +36 -2
void commented 2026-11-13 07:16:42 +00:00
Member
Copy link

Group 10 of the IconButton phone-hit audit. Nothing drawn changes.

Changed:

  • components/message/content/AudioContent.tsx: mute toggle, 24 px, PhoneHitSpread24. Audit said PhoneHit; the volume slider sits 8 px beside it and is tappable.
  • components/message/FileHeader.tsx: FileDownloadButton, 26 px, PhoneHit. Alone at the end of the header row (both uses pass it as after).
  • plugins/react-custom-html-parser.tsx: code block expand/collapse, 24 px, PhoneHitSpread24. Audit said PhoneHit; the Copy chip is 8 px beside it.
  • components/AccountDataEditor.tsx: close, 40 px, PhoneHit (alone in its Box).
  • components/image-pack-view/ImagePackView.tsx: close, 40 px, PhoneHit (alone in its Box).

Skipped: none (all under 44 px, all rendered on phones).

Test: src/app/phoneHit.content.test.ts pins the variant per button and the size tie; no allow-list entries. Mutants (variant swapped in source) all killed: AudioContent Spread24->PhoneHit, FileHeader PhoneHit->Spread26, code block Spread24->Spread32, AccountDataEditor class removed.

Unmeasured on a real phone / doubt: the code block header lives in a pre with overflow hidden; the 44 px hit area of the 24 px expand button may be clipped by a couple of px at the top edge (no Room24 variant exists). Nothing here was tapped on a device.

🤖 Generated with Claude Code

Group 10 of the IconButton phone-hit audit. Nothing drawn changes. Changed: - components/message/content/AudioContent.tsx: mute toggle, 24 px, PhoneHitSpread24. Audit said PhoneHit; the volume slider sits 8 px beside it and is tappable. - components/message/FileHeader.tsx: FileDownloadButton, 26 px, PhoneHit. Alone at the end of the header row (both uses pass it as `after`). - plugins/react-custom-html-parser.tsx: code block expand/collapse, 24 px, PhoneHitSpread24. Audit said PhoneHit; the Copy chip is 8 px beside it. - components/AccountDataEditor.tsx: close, 40 px, PhoneHit (alone in its Box). - components/image-pack-view/ImagePackView.tsx: close, 40 px, PhoneHit (alone in its Box). Skipped: none (all under 44 px, all rendered on phones). Test: src/app/phoneHit.content.test.ts pins the variant per button and the size tie; no allow-list entries. Mutants (variant swapped in source) all killed: AudioContent Spread24->PhoneHit, FileHeader PhoneHit->Spread26, code block Spread24->Spread32, AccountDataEditor class removed. Unmeasured on a real phone / doubt: the code block header lives in a `pre` with overflow hidden; the 44 px hit area of the 24 px expand button may be clipped by a couple of px at the top edge (no Room24 variant exists). Nothing here was tapped on a device. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Phone hit: message content and data editor icon buttons
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 4m30s
Details
a0d047c139 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge branch 'dev' into void/phone-hit-content
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 3m11s
Details
4c16e51559
void merged commit d5ad73fa5e into dev 2026-11-13 13:26:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!138
No description provided.