GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Phone hit: common-settings IconButtons (group 6) #134

Merged
void merged 2 commits from void/phone-hit-common-settings into dev 2026-11-13 12:11:44 +00:00
Conversation 0 Commits 2 Files changed 10 +51 -8
void commented 2026-11-13 07:16:04 +00:00
Member
Copy link

Group 6 of the IconButton phone-hit audit: features/common-settings. Nothing drawn changes; on phones each button gets a 44 px hit area (PhoneHit).

Buttons changed (11, all PhoneHit):

  • Members.tsx: header close (40 px, alone at header end, title text beside it is not tappable); scroll-to-top (30 px, floating alone in ScrollTopContainer, which does not clip).
  • SendRoomEvent, StateEventEditor, DevelopTools, PowersEditor, EmojisStickers: header close (40 px, alone at header end).
  • RoomPacks: the remove/undo pair (26 px each; a ternary, only one renders, the avatar beside is not tappable). The audit listed the second as a header close; it is the else branch of the ternary.
  • RoomEncryption, RoomUpgrade: dialog close (32 px, alone in the dialog Header; 6 px overhang stays inside the Header's 8 px right padding).

No Spread/Room variants apply, so expectSizeTie is trivially satisfied (no allow-list). Vertical stacks: none.
Skipped: none (all under 44 px, all reachable on a phone).

Test: src/app/phoneHit.commonSettings.test.ts pins variants per file in source order. Mutants (variant swapped in source): RoomUpgrade -> Spread40 killed; Members first button -> Room26 killed; RoomPacks first button -> Spread26 killed.

Unmeasured on a real phone: actual tap behaviour of the hit areas in the Dialog headers and the RoomPacks rows (inferred from source, not run on Starfire).

🤖 Generated with Claude Code

Group 6 of the IconButton phone-hit audit: features/common-settings. Nothing drawn changes; on phones each button gets a 44 px hit area (PhoneHit). Buttons changed (11, all `PhoneHit`): - Members.tsx: header close (40 px, alone at header end, title text beside it is not tappable); scroll-to-top (30 px, floating alone in ScrollTopContainer, which does not clip). - SendRoomEvent, StateEventEditor, DevelopTools, PowersEditor, EmojisStickers: header close (40 px, alone at header end). - RoomPacks: the remove/undo pair (26 px each; a ternary, only one renders, the avatar beside is not tappable). The audit listed the second as a header close; it is the else branch of the ternary. - RoomEncryption, RoomUpgrade: dialog close (32 px, alone in the dialog Header; 6 px overhang stays inside the Header's 8 px right padding). No Spread/Room variants apply, so expectSizeTie is trivially satisfied (no allow-list). Vertical stacks: none. Skipped: none (all under 44 px, all reachable on a phone). Test: src/app/phoneHit.commonSettings.test.ts pins variants per file in source order. Mutants (variant swapped in source): RoomUpgrade -> Spread40 killed; Members first button -> Room26 killed; RoomPacks first button -> Spread26 killed. Unmeasured on a real phone: actual tap behaviour of the hit areas in the Dialog headers and the RoomPacks rows (inferred from source, not run on Starfire). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Phone hit: common-settings IconButtons get PhoneHit, with a pinning test
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 3m31s
Details
e209688de1 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge branch 'dev' into void/phone-hit-common-settings
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 3m46s
Details
8a52fa9353
void merged commit a7ac67683f into dev 2026-11-13 12:11:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!134
No description provided.