Phone hit: dialogs and prompts (group 8) #132

Merged
void merged 2 commits from void/phone-hit-dialogs into dev 2026-11-13 10:16:51 +00:00
Member

Group 8 of the IconButton phone-hit audit: dialogs and prompts.

Changed (all PhoneHit; each is a 32 px close button, 24 px Icon + 8 px padding, alone at the end of a header whose title is not tappable, no clipping container found in folds Modal or the local css):

  • features/create-space/CreateSpaceModal.tsx (1)
  • features/create-room/CreateRoomModal.tsx (1)
  • features/add-existing/AddExisting.tsx (1)
  • components/room-topic-viewer/RoomTopicViewer.tsx (1)
  • components/leave-room-prompt/LeaveRoomPrompt.tsx (1)
  • components/leave-space-prompt/LeaveSpacePrompt.tsx (1)
  • components/event-readers/EventReaders.tsx (1)
  • components/invite-user-prompt/InviteUserPrompt.tsx (1)
  • components/join-address-prompt/JoinAddressPrompt.tsx (1)
  • components/user-profile/PowerChip.tsx (2: self demotion, shared power)

Skipped: none (no button >= 44 px; all render on a phone). No vertical stacks. Nothing drawn changes; the audit table's proposals held on re-read.

Test: src/app/phoneHit.dialogs.test.ts pins each variant per file in source order and runs expectSizeTie (no allow-list; plain PhoneHit has no size to tie, so that check is vacuous here). Mutants (variant swapped to PhoneHitSpread32 in CreateSpaceModal, PowerChip, EventReaders; class removed in LeaveRoomPrompt) all fail the test.

Unmeasured on a real phone: the 44 px hit area against the modal edge (header padding is 6 px on the right, so the area reaches the modal border), and overlap with the Header's own taps.

🤖 Generated with Claude Code

Group 8 of the IconButton phone-hit audit: dialogs and prompts. Changed (all `PhoneHit`; each is a 32 px close button, 24 px Icon + 8 px padding, alone at the end of a header whose title is not tappable, no clipping container found in folds Modal or the local css): - features/create-space/CreateSpaceModal.tsx (1) - features/create-room/CreateRoomModal.tsx (1) - features/add-existing/AddExisting.tsx (1) - components/room-topic-viewer/RoomTopicViewer.tsx (1) - components/leave-room-prompt/LeaveRoomPrompt.tsx (1) - components/leave-space-prompt/LeaveSpacePrompt.tsx (1) - components/event-readers/EventReaders.tsx (1) - components/invite-user-prompt/InviteUserPrompt.tsx (1) - components/join-address-prompt/JoinAddressPrompt.tsx (1) - components/user-profile/PowerChip.tsx (2: self demotion, shared power) Skipped: none (no button >= 44 px; all render on a phone). No vertical stacks. Nothing drawn changes; the audit table's proposals held on re-read. Test: src/app/phoneHit.dialogs.test.ts pins each variant per file in source order and runs expectSizeTie (no allow-list; plain PhoneHit has no size to tie, so that check is vacuous here). Mutants (variant swapped to PhoneHitSpread32 in CreateSpaceModal, PowerChip, EventReaders; class removed in LeaveRoomPrompt) all fail the test. Unmeasured on a real phone: the 44 px hit area against the modal edge (header padding is 6 px on the right, so the area reaches the modal border), and overlap with the Header's own taps. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Phone hit: PhoneHit on the ten dialog and prompt close buttons, with a pinning test
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 5m26s
0b40f4c66f
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge branch 'dev' into void/phone-hit-dialogs
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 4m5s
2c39f89fe4
void merged commit 32b95fb60b into dev 2026-11-13 10:16:51 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!132
No description provided.