Phone hit: call controls (audit group 1) #130
Loading…
Reference in a new issue
No description provided.
Delete branch "void/phone-hit-call"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Phone hit areas, group 1 of the IconButton audit: the call controls.
Buttons changed (drawn px derived from size prop plus Icon size, tied by
expectSizeTie):features/call/Controls.tsx: mic, sound, video, screen share, chat:PhoneHitSpread40(24 px icon + 2x8 padding = 40, in rows with 4 px gaps; neighbours are tappable buttons).features/call/CallControls.tsx: the VerticalDots menu button:PhoneHitSpread40(40 px, shares a row with ChatButton; the PopOut menu opens from it and is not its clipping parent).features/call-status/CallControl.tsx: mic, sound, video, screen share:PhoneHitSpread26(18 px icon + 2x4 = 26, one row, gap200).Skipped: none >= 44 px. The call-status hangup is a Chip, not an IconButton. Controls.tsx buttons are also used by PrescreenControls (same variants apply there).
No vertical stacks: with
compact, the call bar stacks its groups in a column, but each group is still a row, so Spread (horizontal) applies. Nothing drawn changes.Test:
src/app/phoneHit.call.test.tspins each file's variants in source order plus the size tie, no allow-list entries. Mutation checks (variant swapped in source, test died each time): Controls.tsx chat Spread40 -> Spread36; CallControls.tsx menu Spread40 -> PhoneHit; CallControl.tsx sound Spread26 -> Spread28; CallControl.tsx share Spread26 -> Room26.Unmeasured on a real phone: the row widening (margin 2 px on each side for 40 px buttons, 9 px for 26 px buttons) in the call bar and call-status bar, and whether the call-status bar still fits at 390 px (its container was not measured, compact mode hides share and divider).
🤖 Generated with Claude Code