File zone share: component tests, state machine moved out of ShareSet #116
Loading…
Reference in a new issue
No description provided.
Delete branch "void/share-set-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up
chat-mind-20261112T124133749Z-t6. The repo has no DOM test environment (server render only), so the panel's state moved intoshareController.ts(picked files, phase, one send per room, encrypted refusal at Send, failed files kept by position) andShareSet.tsxdraws it (ShareSetViewis pure props). No behavior change intended; flag stays off.Tests: shareController.test.ts (double tap, re-mount, other rooms, throw frees the room, progress, failed by position with same-named twins, all failed, encrypted refusal at Send not mount); ShareSet.test.tsx (idle row, picked, sending, encrypted note, success; flag off/on/encrypted, hook under the config provider). 87 albums tests pass.
Not covered: a real tap on a real input (no DOM env); that is the phone check.
🤖 Generated with Claude Code
Soul pass on
86a68839: 17 mutations, 4 survived, plus two code findings. Fixed in the next commit: controller built once per mount (was useMemo over mx/room/queryClient, a rerender with a new Room could drop the pick), success lands in one notification, new tests kill the surviving title-on-partial-failure and onSent timing/throw mutations (checked by re-mutating). Left, stated: key={epoch} on the file input is not observable by server render (phone check); the encrypted-note wording is pinned by literal. 90 albums tests pass. Flag stays off.