GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

A long reply quote stays inside its column #112

Merged
void merged 3 commits from void/reply-preview-bounds-r into dev 2026-11-12 10:50:04 +00:00
Conversation 0 Commits 3 Files changed 5 +92 -14
void commented 2026-11-12 09:54:24 +00:00
Member
Copy link

Closes ratatoskr:follow_up:reply-preview-bounds-land. A nowrap reply quote sized the own-message row to 782px on a 390px phone (left -425). BubbleColumn, BubbleContentRow and BubbleContent get minWidth 0 and the row maxWidth 100%; the demo gets a long quote to reply to; bubbleBounds.test.ts pins the emitted declarations (removing the row maxWidth fails it). Rebased onto dev 07b82f24 (conflict in Bubble.tsx resolved to dev plus BubbleColumn). Full vitest from a /tmp copy: 998 of 999, the one failure (scene/index.test.ts, build-disposal timing) passes alone 14/14. Not seen rendered here: no browser; the Starfire after-shots of the original commit stand (own quote 782px to 332px, received 176px).

🤖 Generated with Claude Code

Closes ratatoskr:follow_up:reply-preview-bounds-land. A nowrap reply quote sized the own-message row to 782px on a 390px phone (left -425). BubbleColumn, BubbleContentRow and BubbleContent get minWidth 0 and the row maxWidth 100%; the demo gets a long quote to reply to; bubbleBounds.test.ts pins the emitted declarations (removing the row maxWidth fails it). Rebased onto dev 07b82f24 (conflict in Bubble.tsx resolved to dev plus BubbleColumn). Full vitest from a /tmp copy: 998 of 999, the one failure (scene/index.test.ts, build-disposal timing) passes alone 14/14. Not seen rendered here: no browser; the Starfire after-shots of the original commit stand (own quote 782px to 332px, received 176px). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The row around a bubble sized to its content in a right-aligned column, and the quote's nowrap text made
that content 782px, so on a phone the column ran off the left edge. The row, column and bubble now carry
minWidth 0 / maxWidth 100%, and ReplyContent minWidth 0 so the quote truncates. Starfire 390x844:
own quote 782px at left -425 -> 332px at left 25; desktop inside the bubble. No test yet.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Pin the bubble row's shrink-to-column declarations
Some checks failed
Build pull request / Build pull request (pull_request) Has been cancelled
Details
4208b1e25c 
A test reads the emitted layout.css.ts and fails when BubbleColumn,
BubbleContentRow or BubbleContent lose min-width 0 or the row loses
max-width 100%, the cause of the 782px own-message quote.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
bubbleBounds test also pins the Bubble.tsx wiring
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 4m51s
Details
fb03aa0ffb 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
void merged commit 010e68b5e8 into dev 2026-11-12 10:50:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!112
No description provided.