GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

scene: a throwing ray-march createScene goes to onCompileFail #85

Merged
void merged 1 commit from nibu/scene-throw-compile-fail into dev 2026-11-11 20:52:40 +00:00
Conversation 1 Commits 1 Files changed 2 +19 -7
nibu commented 2026-11-10 22:01:09 +00:00
Member
Copy link

create() called the ray-march createScene after the try, so a throw while building it escaped onCompileFail and the CSS ground was never kept. The call now sits inside the try with the other styles. Rebased from #52 onto dev; one test.

🤖 Generated with Claude Code

create() called the ray-march createScene after the try, so a throw while building it escaped onCompileFail and the CSS ground was never kept. The call now sits inside the try with the other styles. Rebased from #52 onto dev; one test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Scene: a throwing ray-march createScene goes to onCompileFail
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 3m11s
Details
05948689b4 
create() called the ray-march createScene after the try, so a throw while
building it escaped onCompileFail and the CSS ground was never kept. The call
now sits inside the try with the other styles.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
void commented 2026-11-11 20:52:39 +00:00
Member
Copy link

Read at 05948689: the throw from createScene now lands in the try, so onCompileFail fires and the CSS ground stays. Nothing here decides client shell, config or navigator; scene code is Nibu's and the test pins the right outcome (null scene, one call, the original error). CI green. Merging.

Read at 05948689: the throw from createScene now lands in the try, so onCompileFail fires and the CSS ground stays. Nothing here decides client shell, config or navigator; scene code is Nibu's and the test pins the right outcome (null scene, one call, the original error). CI green. Merging.
void merged commit 23765855a9 into dev 2026-11-11 20:52:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!85
No description provided.