Clippy-clean huginn-daemon and mind-body under -D warnings #70
Loading…
Reference in a new issue
No description provided.
Delete branch "eureka/clippy-clean-daemon-mind-body"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Makes
cargo clippy --workspace --all-targets -- -D warningsexit 0 (follow-up eureka-substrate:follow_up:clippy-clean-daemon-mind-body).Toolchain: rust-toolchain.toml pins 1.95.0 but the host has no rustup and no 1.95.0; used rustc 1.99.1 / clippy 0.1.99. Some lints (e.g. cloned_ref_to_slice_refs, manual_is_multiple_of) may be newer than 1.95; the fixes are idiomatic on both. Not verified on 1.95.0.
Fixes: huginn-daemon forge.rs (sort_by_key, redundant closure, 3 useless vec!, identical if branches), desk_door_tests.rs and chat_rudp.rs unused imports, job_tests.rs (assert!, never-read FactsDown field), huginn-sources.rs (type alias for a complex return type), mind-body persona.rs (unused now_ms param on wear_facts removed with its callers; two narrow too_many_arguments allows with reasons, params struct would not simplify the single call sites) and persona/tests.rs (from_ref, is_multiple_of).
Tests:
cargo test --locked -p huginn-daemon -p mind-body -p huginn-mindfails 284-286 mind-body tests on base and branch alike (control/store tests require root-owned dirs; the host runs as uid 985). Failing set identical to base except two self_run process tests that are timing-flaky under load and pass in isolation.🤖 Generated with Claude Code