Clippy-clean huginn-daemon and mind-body under -D warnings #70

Merged
eureka merged 2 commits from eureka/clippy-clean-daemon-mind-body into main 2026-11-17 02:22:31 +00:00
Owner

Makes cargo clippy --workspace --all-targets -- -D warnings exit 0 (follow-up eureka-substrate:follow_up:clippy-clean-daemon-mind-body).

Toolchain: rust-toolchain.toml pins 1.95.0 but the host has no rustup and no 1.95.0; used rustc 1.99.1 / clippy 0.1.99. Some lints (e.g. cloned_ref_to_slice_refs, manual_is_multiple_of) may be newer than 1.95; the fixes are idiomatic on both. Not verified on 1.95.0.

Fixes: huginn-daemon forge.rs (sort_by_key, redundant closure, 3 useless vec!, identical if branches), desk_door_tests.rs and chat_rudp.rs unused imports, job_tests.rs (assert!, never-read FactsDown field), huginn-sources.rs (type alias for a complex return type), mind-body persona.rs (unused now_ms param on wear_facts removed with its callers; two narrow too_many_arguments allows with reasons, params struct would not simplify the single call sites) and persona/tests.rs (from_ref, is_multiple_of).

Tests: cargo test --locked -p huginn-daemon -p mind-body -p huginn-mind fails 284-286 mind-body tests on base and branch alike (control/store tests require root-owned dirs; the host runs as uid 985). Failing set identical to base except two self_run process tests that are timing-flaky under load and pass in isolation.

🤖 Generated with Claude Code

Makes `cargo clippy --workspace --all-targets -- -D warnings` exit 0 (follow-up eureka-substrate:follow_up:clippy-clean-daemon-mind-body). Toolchain: rust-toolchain.toml pins 1.95.0 but the host has no rustup and no 1.95.0; used rustc 1.99.1 / clippy 0.1.99. Some lints (e.g. cloned_ref_to_slice_refs, manual_is_multiple_of) may be newer than 1.95; the fixes are idiomatic on both. Not verified on 1.95.0. Fixes: huginn-daemon forge.rs (sort_by_key, redundant closure, 3 useless vec!, identical if branches), desk_door_tests.rs and chat_rudp.rs unused imports, job_tests.rs (assert!, never-read FactsDown field), huginn-sources.rs (type alias for a complex return type), mind-body persona.rs (unused now_ms param on wear_facts removed with its callers; two narrow too_many_arguments allows with reasons, params struct would not simplify the single call sites) and persona/tests.rs (from_ref, is_multiple_of). Tests: `cargo test --locked -p huginn-daemon -p mind-body -p huginn-mind` fails 284-286 mind-body tests on base and branch alike (control/store tests require root-owned dirs; the host runs as uid 985). Failing set identical to base except two self_run process tests that are timing-flaky under load and pass in isolation. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Unused import, sort_by_key, redundant closure, useless vec!, identical if
branches, assert!(bool), a never-read test field, and a Collected alias for
the huginn-sources option pair. No behaviour change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Unused ChatDelivery import and wear_facts now_ms parameter removed,
from_ref and is_multiple_of in tests, and narrow too_many_arguments allows
on message_line and render_input (independent prompt sections; a params
struct would only rename them). No behaviour change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
eureka merged commit 416e385c97 into main 2026-11-17 02:22:31 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Huginn!70
No description provided.