Refuse retirement in channel reach, speech, knowledge, and office (PA.f33-f35)
`audience()`'s Reach::Subjects arm returned channel members without filtering retirement, so a retired subject remained a Communicate audience and a CanReach target (audience() is the one statement both preconditions and Communicate read, so one filter, `is_retired`, fixes both). A retired Communicate speaker was also resolved rather than refused. Audience derivation stays the one owner of reachability, so a channel may still declare a retired member; retirement is filtered at that single read site. AcquireKnowledge, Forget, and InstallIncumbent all accepted a retired subject as the one learning, forgetting, or taking office. All four ops now push the new `Mismatch::RetiredSubjectActed`. Transfer is untouched: a retired holder's holdings remain transferable, so a body can still be looted. Adds permanent tests for PA.f33-f35, including named pins for the five mutations Soul's probes found live: MuA (retire-then-relocate), MuB (an elaborator revoking outside its jurisdiction), MuC (a mirror flagged retired), MuD (three revokes in one patch), and MuE (retiring the same subject twice in one patch). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
parent
fd64595908
commit
e18aa03878
2 changed files with 408 additions and 3 deletions
|
|
@ -3164,6 +3164,17 @@ fn channel_referents_exist(state: &WorldState, record: &ChannelRecord) -> bool {
|
||||||
.is_none_or(|subject_id| state.subjects.contains_key(&subject_id))
|
.is_none_or(|subject_id| state.subjects.contains_key(&subject_id))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Whether a subject's controller assignment is `Retired`. The one statement
|
||||||
|
/// of retirement read by anything downstream of it (audience derivation,
|
||||||
|
/// preconditions, resolvers): a mirror's assignment is `ExternallyControlled`
|
||||||
|
/// and is never retired by this check, only an actual `Retire` sets it.
|
||||||
|
fn is_retired(state: &WorldState, subject_id: SubjectId) -> bool {
|
||||||
|
matches!(
|
||||||
|
state.controller_assignments.get(&DecisionScope { subject_id }),
|
||||||
|
Some(ControllerAssignment::Retired)
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
/// Everyone standing anywhere under one place. The one downward-facing read of
|
/// Everyone standing anywhere under one place. The one downward-facing read of
|
||||||
/// `positions`: `audience`'s `Reach::Place` arm and `ResolvedOp::Witness` are
|
/// `positions`: `audience`'s `Reach::Place` arm and `ResolvedOp::Witness` are
|
||||||
/// its two callers, so what "under a place" means cannot drift between a
|
/// its two callers, so what "under a place" means cannot drift between a
|
||||||
|
|
@ -3203,7 +3214,15 @@ fn audience(state: &WorldState, actor: SubjectId, of: &Audience) -> BTreeSet<Sub
|
||||||
return BTreeSet::new();
|
return BTreeSet::new();
|
||||||
};
|
};
|
||||||
match &record.reach {
|
match &record.reach {
|
||||||
Reach::Subjects(members) => members.clone(),
|
// Audience derivation is the one owner of who is reachable, so
|
||||||
|
// a channel may still *declare* a retired member (PA.f33);
|
||||||
|
// retirement is filtered here, at the single read site, not at
|
||||||
|
// declaration time.
|
||||||
|
Reach::Subjects(members) => members
|
||||||
|
.iter()
|
||||||
|
.copied()
|
||||||
|
.filter(|member| !is_retired(state, *member))
|
||||||
|
.collect(),
|
||||||
Reach::Place(root) => under_place(state, *root),
|
Reach::Place(root) => under_place(state, *root),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
@ -12551,8 +12570,9 @@ mod witness_tests {
|
||||||
mod clock_tests {
|
mod clock_tests {
|
||||||
use super::patch::{PreconditionRef, PressureSourceRef, WorldScaleIntentRef};
|
use super::patch::{PreconditionRef, PressureSourceRef, WorldScaleIntentRef};
|
||||||
use super::tests::{
|
use super::tests::{
|
||||||
activate, affordance_named, auth_principal, command, creation, operations, opportunity_for,
|
activate, affordance_named, authority_kind, auth_principal, command, creation, office,
|
||||||
owner, human_principal, reject_owner, submit_owner,
|
operations, opportunity_for, owner, human_principal, reject_owner, speech_world,
|
||||||
|
submit_owner,
|
||||||
};
|
};
|
||||||
use super::*;
|
use super::*;
|
||||||
use std::path::Path;
|
use std::path::Path;
|
||||||
|
|
@ -17786,4 +17806,357 @@ mod clock_tests {
|
||||||
assert!(retired);
|
assert!(retired);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// PA.f33: audience derivation (`audience()`) is the one owner of who a
|
||||||
|
/// channel reaches, so a channel may still *declare* a retired member,
|
||||||
|
/// but that member is filtered out at the one read site — it gains no
|
||||||
|
/// knowledge from a telling into that channel.
|
||||||
|
#[test]
|
||||||
|
fn channel_audience_excludes_a_retired_member() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf33Audience");
|
||||||
|
owner_retires(&mut kernel, clockwork.reeve).expect("retire");
|
||||||
|
let mut patch = ruled_fact_patch("news");
|
||||||
|
patch.declarations.push(Declaration::Channel(ChannelDeclaration {
|
||||||
|
handle: DraftHandle::new("wire"),
|
||||||
|
label: "The Wire".into(),
|
||||||
|
reach: ReachRef::Subjects(BTreeSet::from([
|
||||||
|
Ref::Existing(clockwork.reeve),
|
||||||
|
Ref::Existing(clockwork.farmer),
|
||||||
|
])),
|
||||||
|
controller: None,
|
||||||
|
}));
|
||||||
|
patch.operations.push(ComponentOp::Communicate {
|
||||||
|
speaker: Ref::Existing(clockwork.farmer),
|
||||||
|
fact: Ref::Draft(DraftHandle::new("news")),
|
||||||
|
to: AudienceRef::Channel(Ref::Draft(DraftHandle::new("wire"))),
|
||||||
|
});
|
||||||
|
submit_as(&mut kernel, play_caller(), CommandBody::AdmitPatch { answers: None, patch })
|
||||||
|
.expect("admitted");
|
||||||
|
let reeve_knows = kernel
|
||||||
|
.state
|
||||||
|
.knowledge
|
||||||
|
.get(&clockwork.reeve)
|
||||||
|
.map(BTreeMap::len)
|
||||||
|
.unwrap_or(0);
|
||||||
|
assert_eq!(reeve_knows, 0, "a retired subject was an audience");
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f33: `Communicate` resolves and refuses a retired speaker with
|
||||||
|
/// `RetiredSubjectActed`, whether or not it is also that channel's
|
||||||
|
/// controller.
|
||||||
|
#[test]
|
||||||
|
fn a_retired_subject_cannot_speak_through_a_channel() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf33RetiredSpeaks");
|
||||||
|
let mut declare = ruled_fact_patch("wire-decl");
|
||||||
|
declare.declarations.push(Declaration::Channel(ChannelDeclaration {
|
||||||
|
handle: DraftHandle::new("wire"),
|
||||||
|
label: "The Wire".into(),
|
||||||
|
reach: ReachRef::Subjects(BTreeSet::from([
|
||||||
|
Ref::Existing(clockwork.reeve),
|
||||||
|
Ref::Existing(clockwork.farmer),
|
||||||
|
])),
|
||||||
|
controller: None,
|
||||||
|
}));
|
||||||
|
submit_as(&mut kernel, play_caller(), CommandBody::AdmitPatch { answers: None, patch: declare })
|
||||||
|
.expect("declare");
|
||||||
|
owner_retires(&mut kernel, clockwork.reeve).expect("retire");
|
||||||
|
let wire = *kernel.state.channels.keys().next().unwrap();
|
||||||
|
let mut patch = ruled_fact_patch("news");
|
||||||
|
patch.operations.push(ComponentOp::Communicate {
|
||||||
|
speaker: Ref::Existing(clockwork.reeve),
|
||||||
|
fact: Ref::Draft(DraftHandle::new("news")),
|
||||||
|
to: AudienceRef::Channel(Ref::Existing(wire)),
|
||||||
|
});
|
||||||
|
let error = submit_as(&mut kernel, play_caller(), CommandBody::AdmitPatch { answers: None, patch })
|
||||||
|
.unwrap_err();
|
||||||
|
assert!(
|
||||||
|
matches!(&error, KernelError::PatchRejected(set)
|
||||||
|
if set.contains(&Mismatch::RetiredSubjectActed { operation: 0 })),
|
||||||
|
"{error:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f33: `CanReach` is `audience().contains(target)`, so a retired
|
||||||
|
/// target fails the same precondition every other reach check now
|
||||||
|
/// respects — one statement of reach, one fix.
|
||||||
|
#[test]
|
||||||
|
fn a_retired_subject_is_unreachable_through_can_reach() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let mut kernel = WorldKernel::create(
|
||||||
|
directory.path().join("world.cc"),
|
||||||
|
creation(CommandId::new(), "PAf33CanReach"),
|
||||||
|
&auth_principal(owner()),
|
||||||
|
)
|
||||||
|
.expect("a created world")
|
||||||
|
.0;
|
||||||
|
let (speech, _) = speech_world(&mut kernel);
|
||||||
|
owner_retires(&mut kernel, speech.listener).expect("the owner retires the listener");
|
||||||
|
let snapshot = kernel.snapshot().unwrap();
|
||||||
|
let opportunity = opportunity_for(&snapshot, speech.speaker);
|
||||||
|
let invocation = DecisionInvocation {
|
||||||
|
affordance: speech.whisper,
|
||||||
|
bindings: vec![binding("target", Target::Subject(speech.listener))],
|
||||||
|
proposed: Vec::new(),
|
||||||
|
speech: Some(Statement::new("Are you still there?").unwrap()),
|
||||||
|
display: None,
|
||||||
|
};
|
||||||
|
let error = submit_as(
|
||||||
|
&mut kernel,
|
||||||
|
CallerId::Controller(opportunity.controller_id),
|
||||||
|
CommandBody::ExerciseDecision { invocation, opportunity },
|
||||||
|
)
|
||||||
|
.unwrap_err();
|
||||||
|
assert!(
|
||||||
|
matches!(&error, KernelError::ActionRejected(set)
|
||||||
|
if set.contains(&ActionMismatch::CannotReach { precondition: 0 })),
|
||||||
|
"{error:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f34: `AcquireKnowledge` refuses a retired subject.
|
||||||
|
#[test]
|
||||||
|
fn a_retired_subject_cannot_acquire_knowledge() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf34Acquire");
|
||||||
|
owner_retires(&mut kernel, clockwork.reeve).expect("retire");
|
||||||
|
let mut patch = ruled_fact_patch("news");
|
||||||
|
patch.operations.push(ComponentOp::AcquireKnowledge {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
fact: Ref::Draft(DraftHandle::new("news")),
|
||||||
|
source: AuthoredSource::Witnessed,
|
||||||
|
confidence: Confidence::Certain,
|
||||||
|
});
|
||||||
|
let error = submit_as(&mut kernel, play_caller(), CommandBody::AdmitPatch { answers: None, patch })
|
||||||
|
.unwrap_err();
|
||||||
|
assert!(
|
||||||
|
matches!(&error, KernelError::PatchRejected(set)
|
||||||
|
if set.contains(&Mismatch::RetiredSubjectActed { operation: 0 })),
|
||||||
|
"{error:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f34: `Forget` refuses a retired subject.
|
||||||
|
#[test]
|
||||||
|
fn a_retired_subject_cannot_forget() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf34Forget");
|
||||||
|
let mut declare = ruled_fact_patch("news");
|
||||||
|
declare.operations.push(ComponentOp::AcquireKnowledge {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
fact: Ref::Draft(DraftHandle::new("news")),
|
||||||
|
source: AuthoredSource::Witnessed,
|
||||||
|
confidence: Confidence::Certain,
|
||||||
|
});
|
||||||
|
submit_as(&mut kernel, play_caller(), CommandBody::AdmitPatch { answers: None, patch: declare })
|
||||||
|
.expect("the reeve learns the fact");
|
||||||
|
let fact = *kernel.state.knowledge[&clockwork.reeve].keys().next().unwrap();
|
||||||
|
owner_retires(&mut kernel, clockwork.reeve).expect("retire");
|
||||||
|
let before = kernel.snapshot().unwrap();
|
||||||
|
let error = reject_owner(
|
||||||
|
&mut kernel,
|
||||||
|
&before,
|
||||||
|
operations(vec![ComponentOp::Forget {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
fact: Ref::Existing(fact),
|
||||||
|
}]),
|
||||||
|
);
|
||||||
|
assert_eq!(error, vec![Mismatch::RetiredSubjectActed { operation: 0 }]);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f34: `InstallIncumbent` refuses a retired subject as incumbent.
|
||||||
|
#[test]
|
||||||
|
fn a_retired_subject_cannot_take_office() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf34Office");
|
||||||
|
owner_retires(&mut kernel, clockwork.farmer).expect("retire");
|
||||||
|
let before = kernel.snapshot().unwrap();
|
||||||
|
let error = reject_owner(
|
||||||
|
&mut kernel,
|
||||||
|
&before,
|
||||||
|
operations(vec![
|
||||||
|
ComponentOp::OpenOffice {
|
||||||
|
institution: Ref::Existing(clockwork.treasury),
|
||||||
|
office: office("warden"),
|
||||||
|
delegated: BTreeSet::from([authority_kind("levy")]),
|
||||||
|
},
|
||||||
|
ComponentOp::InstallIncumbent {
|
||||||
|
institution: Ref::Existing(clockwork.treasury),
|
||||||
|
office: office("warden"),
|
||||||
|
incumbent: Ref::Existing(clockwork.farmer),
|
||||||
|
},
|
||||||
|
]),
|
||||||
|
);
|
||||||
|
assert_eq!(error, vec![Mismatch::RetiredSubjectActed { operation: 1 }]);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f34: a retired subject's holdings remain transferable — a body may
|
||||||
|
/// still be looted after it stops acting.
|
||||||
|
#[test]
|
||||||
|
fn holdings_are_still_transferable_from_a_retired_holder() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf34Loot");
|
||||||
|
owner_retires(&mut kernel, clockwork.farmer).expect("retire");
|
||||||
|
let before = kernel.snapshot().unwrap();
|
||||||
|
let grain = *kernel
|
||||||
|
.state
|
||||||
|
.holdings
|
||||||
|
.get(&clockwork.farmer)
|
||||||
|
.expect("the retired farmer still holds grain")
|
||||||
|
.keys()
|
||||||
|
.next()
|
||||||
|
.expect("at least one resource");
|
||||||
|
submit_owner(
|
||||||
|
&mut kernel,
|
||||||
|
&before,
|
||||||
|
operations(vec![ComponentOp::Transfer {
|
||||||
|
from: Ref::Existing(clockwork.farmer),
|
||||||
|
to: Ref::Existing(clockwork.reeve),
|
||||||
|
resource: Ref::Existing(grain),
|
||||||
|
qty: Quantity(2),
|
||||||
|
}]),
|
||||||
|
);
|
||||||
|
assert_eq!(
|
||||||
|
kernel.state.holdings[&clockwork.reeve][&grain],
|
||||||
|
Quantity(2)
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f35, MuA: the resolver's `Retire` arm removes the subject's
|
||||||
|
/// Position (`positions.remove`) in the same candidate pass a later
|
||||||
|
/// `Relocate` in the same patch reads, so retire-then-relocate in one
|
||||||
|
/// patch is rejected as `UnplacedSubject` rather than silently placing a
|
||||||
|
/// retired subject.
|
||||||
|
#[test]
|
||||||
|
fn retiring_then_relocating_in_one_patch_is_rejected() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf35RetireRelocate");
|
||||||
|
let stair = *kernel
|
||||||
|
.state
|
||||||
|
.edges
|
||||||
|
.iter()
|
||||||
|
.find(|(_, edge)| edge.endpoints().0 == clockwork.yard)
|
||||||
|
.unwrap()
|
||||||
|
.0;
|
||||||
|
let before = kernel.snapshot().unwrap();
|
||||||
|
let error = reject_owner(
|
||||||
|
&mut kernel,
|
||||||
|
&before,
|
||||||
|
operations(vec![
|
||||||
|
ComponentOp::Retire { subject: Ref::Existing(clockwork.reeve) },
|
||||||
|
ComponentOp::Relocate {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
via: Ref::Existing(stair),
|
||||||
|
},
|
||||||
|
]),
|
||||||
|
);
|
||||||
|
assert_eq!(error, vec![Mismatch::UnplacedSubject { operation: 1 }]);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f35, MuB: `RevokeAffordance` is confined exactly as every other
|
||||||
|
/// structural operation, so an elaborator cannot use it to touch a
|
||||||
|
/// subject's grants outside its jurisdiction.
|
||||||
|
#[test]
|
||||||
|
fn an_elaborator_cannot_revoke() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf35ElabRevoke");
|
||||||
|
let answered = dead_end_boundary(&kernel);
|
||||||
|
let speak = super::tests::speak_entry(&kernel);
|
||||||
|
let error = submit_as(
|
||||||
|
&mut kernel,
|
||||||
|
elaborator(JurisdictionKey::PlaceSubtree(clockwork.dead_end)),
|
||||||
|
CommandBody::AdmitPatch {
|
||||||
|
answers: Some(PatchAnswer::Boundary(answered)),
|
||||||
|
patch: WorldPatch {
|
||||||
|
declarations: vec![Declaration::Subject(SubjectDeclaration {
|
||||||
|
handle: DraftHandle::new("stray"),
|
||||||
|
label: "The Roadside Stray".into(),
|
||||||
|
kind: SubjectKind::Person,
|
||||||
|
controller: NewController::NarrativePersona,
|
||||||
|
affordances: BTreeSet::from([
|
||||||
|
speak.clone(),
|
||||||
|
Ref::Existing(clockwork.threaten),
|
||||||
|
]),
|
||||||
|
position: Some(Ref::Existing(clockwork.dead_end)),
|
||||||
|
})],
|
||||||
|
operations: vec![ComponentOp::RevokeAffordance {
|
||||||
|
subject: Ref::Draft(DraftHandle::new("stray")),
|
||||||
|
affordance: Ref::Existing(clockwork.threaten),
|
||||||
|
}],
|
||||||
|
evidence: Vec::new(),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
)
|
||||||
|
.unwrap_err();
|
||||||
|
assert!(
|
||||||
|
matches!(&error, KernelError::PatchRejected(set)
|
||||||
|
if set.contains(&Mismatch::OutsideJurisdiction { site: Site::Operation(0) })),
|
||||||
|
"{error:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f35, MuC: `retired` on a subject snapshot row is read from
|
||||||
|
/// `ControllerAssignment::Retired` specifically, not from
|
||||||
|
/// `mode().is_none()` — a mirror's mode is also `None`, and a mirror must
|
||||||
|
/// never be reported retired.
|
||||||
|
#[test]
|
||||||
|
fn a_mirror_is_not_reported_retired() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf35MirrorFlag");
|
||||||
|
let mirror = declare_mirror(&mut kernel, &clockwork, "pa-f35-mirror");
|
||||||
|
let snapshot = kernel.snapshot().unwrap();
|
||||||
|
let row = snapshot.subjects.iter().find(|s| s.id == mirror).unwrap();
|
||||||
|
assert!(!row.retired);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f35, MuD: the affordance-holdings candidate set is updated after
|
||||||
|
/// every grant and revoke in a patch, not only the first, so three
|
||||||
|
/// revokes in one patch still catch the one that would leave the subject
|
||||||
|
/// mute.
|
||||||
|
#[test]
|
||||||
|
fn three_revokes_in_one_patch_cannot_mute_the_subject() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf35ThreeRevokes");
|
||||||
|
let speak = super::tests::speak_entry(&kernel);
|
||||||
|
let before = kernel.snapshot().unwrap();
|
||||||
|
let error = reject_owner(
|
||||||
|
&mut kernel,
|
||||||
|
&before,
|
||||||
|
operations(vec![
|
||||||
|
ComponentOp::RevokeAffordance {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
affordance: Ref::Existing(clockwork.threaten),
|
||||||
|
},
|
||||||
|
ComponentOp::RevokeAffordance {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
affordance: Ref::Existing(clockwork.deliver),
|
||||||
|
},
|
||||||
|
ComponentOp::RevokeAffordance {
|
||||||
|
subject: Ref::Existing(clockwork.reeve),
|
||||||
|
affordance: speak,
|
||||||
|
},
|
||||||
|
]),
|
||||||
|
);
|
||||||
|
assert_eq!(error, vec![Mismatch::WouldLeaveSubjectMute { operation: 2 }]);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// PA.f35, MuE: the resolver's `Retire` arm inserts the subject into its
|
||||||
|
/// own-patch `retired` candidate set, so a second `Retire` of the same
|
||||||
|
/// subject in one patch is caught as a no-op rather than silently
|
||||||
|
/// re-resolving.
|
||||||
|
#[test]
|
||||||
|
fn retiring_the_same_subject_twice_in_one_patch_is_a_noop_the_second_time() {
|
||||||
|
let directory = tempfile::tempdir().unwrap();
|
||||||
|
let (mut kernel, clockwork, _) = clock_kernel(directory.path(), "PAf35DoubleRetire");
|
||||||
|
let before = kernel.snapshot().unwrap();
|
||||||
|
let error = reject_owner(
|
||||||
|
&mut kernel,
|
||||||
|
&before,
|
||||||
|
operations(vec![
|
||||||
|
ComponentOp::Retire { subject: Ref::Existing(clockwork.reeve) },
|
||||||
|
ComponentOp::Retire { subject: Ref::Existing(clockwork.reeve) },
|
||||||
|
]),
|
||||||
|
);
|
||||||
|
assert_eq!(error, vec![Mismatch::NoOperationEffect { operation: 1 }]);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -1606,6 +1606,14 @@ pub enum Mismatch {
|
||||||
RetiresAnApprover {
|
RetiresAnApprover {
|
||||||
operation: usize,
|
operation: usize,
|
||||||
},
|
},
|
||||||
|
/// `Communicate`, `AcquireKnowledge`, `Forget`, or `InstallIncumbent`
|
||||||
|
/// named a retired subject as the one acting, learning, forgetting, or
|
||||||
|
/// taking office. A retired subject is a body, not an actor: it may still
|
||||||
|
/// be a holdings source (looted), a channel member, or a route endpoint,
|
||||||
|
/// but it cannot be the one who speaks, knows, or holds office.
|
||||||
|
RetiredSubjectActed {
|
||||||
|
operation: usize,
|
||||||
|
},
|
||||||
/// `GrantAffordance` or `RevokeAffordance` named a retired or an
|
/// `GrantAffordance` or `RevokeAffordance` named a retired or an
|
||||||
/// `ExternallyControlled` subject: neither holds a grant this patch may
|
/// `ExternallyControlled` subject: neither holds a grant this patch may
|
||||||
/// touch.
|
/// touch.
|
||||||
|
|
@ -4446,6 +4454,12 @@ pub(super) fn resolve_patch(
|
||||||
else {
|
else {
|
||||||
continue;
|
continue;
|
||||||
};
|
};
|
||||||
|
if retired.contains(&incumbent_key) {
|
||||||
|
mismatches.push(Mismatch::RetiredSubjectActed {
|
||||||
|
operation: position,
|
||||||
|
});
|
||||||
|
continue;
|
||||||
|
}
|
||||||
let slot = (institution_key.clone(), office.clone());
|
let slot = (institution_key.clone(), office.clone());
|
||||||
let Some(current) = selection.get(&slot).cloned() else {
|
let Some(current) = selection.get(&slot).cloned() else {
|
||||||
mismatches.push(Mismatch::UnknownOffice {
|
mismatches.push(Mismatch::UnknownOffice {
|
||||||
|
|
@ -4543,6 +4557,12 @@ pub(super) fn resolve_patch(
|
||||||
let (Some(subject_key), Some(fact_key)) = (subject_key, fact_key) else {
|
let (Some(subject_key), Some(fact_key)) = (subject_key, fact_key) else {
|
||||||
continue;
|
continue;
|
||||||
};
|
};
|
||||||
|
if retired.contains(&subject_key) {
|
||||||
|
mismatches.push(Mismatch::RetiredSubjectActed {
|
||||||
|
operation: position,
|
||||||
|
});
|
||||||
|
continue;
|
||||||
|
}
|
||||||
// Evidenced knowledge is knowledge of canon. A receipt cannot
|
// Evidenced knowledge is knowledge of canon. A receipt cannot
|
||||||
// vouch for an assertion the kernel never evaluated.
|
// vouch for an assertion the kernel never evaluated.
|
||||||
if *source == AuthoredSource::Evidenced
|
if *source == AuthoredSource::Evidenced
|
||||||
|
|
@ -4588,6 +4608,12 @@ pub(super) fn resolve_patch(
|
||||||
let (Some(subject_key), Some(fact_key)) = (subject_key, fact_key) else {
|
let (Some(subject_key), Some(fact_key)) = (subject_key, fact_key) else {
|
||||||
continue;
|
continue;
|
||||||
};
|
};
|
||||||
|
if retired.contains(&subject_key) {
|
||||||
|
mismatches.push(Mismatch::RetiredSubjectActed {
|
||||||
|
operation: position,
|
||||||
|
});
|
||||||
|
continue;
|
||||||
|
}
|
||||||
if knowledge.remove(&(subject_key, fact_key)).is_none() {
|
if knowledge.remove(&(subject_key, fact_key)).is_none() {
|
||||||
mismatches.push(Mismatch::NoOperationEffect {
|
mismatches.push(Mismatch::NoOperationEffect {
|
||||||
operation: position,
|
operation: position,
|
||||||
|
|
@ -4622,6 +4648,12 @@ pub(super) fn resolve_patch(
|
||||||
else {
|
else {
|
||||||
continue;
|
continue;
|
||||||
};
|
};
|
||||||
|
if retired.contains(&speaker_key) {
|
||||||
|
mismatches.push(Mismatch::RetiredSubjectActed {
|
||||||
|
operation: position,
|
||||||
|
});
|
||||||
|
continue;
|
||||||
|
}
|
||||||
// Ontology admission: communication reaches only subjects inside
|
// Ontology admission: communication reaches only subjects inside
|
||||||
// the channel's reach, and a speaker outside it is not speaking.
|
// the channel's reach, and a speaker outside it is not speaking.
|
||||||
if !candidate_in_audience(
|
if !candidate_in_audience(
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue