GameCult/EveUnity
Archived
Watch
9
0
Fork
You've already forked EveUnity
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Honor semantic scale for provider prefabs

Browse source
This commit is contained in:
Meta Vens 2026-07-16 04:13:28 +01:00
commit ccb5817a60
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/org.gamecult.eve.unity-scene/Runtime/EveUnityGameObjectPlayableWorldSceneSink.cs
View file

@ -239,9 +239,7 @@ namespace GameCult.Eve.UnityScene
: $"{entity.EntityId} ({entity.Label})";
instance.transform.localPosition = new Vector3(entity.PositionX, entity.PositionY, entity.PositionZ);
instance.transform.localRotation = Quaternion.Euler(0f, entity.RotationY, 0f);
if (entity.Radius > 0f &&
string.Equals(asset.PresentationKind, "unity-generated-placeholder", StringComparison.Ordinal))
instance.transform.localScale = Vector3.one * entity.Radius;
instance.transform.localScale = Vector3.one * (entity.Radius > 0f ? entity.Radius : 1f);
var marker = instance.GetComponent<EveUnityPlayableWorldEntityMarker>();
if (marker == null)

4
packages/org.gamecult.eve.unity-scene/Tests/Editor/EveUnitySceneSurfaceLowererTests.cs
View file

@ -1345,7 +1345,7 @@ namespace GameCult.Eve.UnityScene.Tests
}
[Test]
public void ProviderPrefabKeepsAuthoredScaleWhileFallbackUsesSemanticRadius()
public void SemanticScaleWrapsProviderAuthoredScaleAndFallbackGeometry()
{
var root = new GameObject("world");
var prefab = new GameObject("provider-prefab");
@ -1360,7 +1360,7 @@ namespace GameCult.Eve.UnityScene.Tests
"prefab.ship", "ship", "provider-asset-ref"));
var instance = root.transform.GetChild(0);
Assert.That(instance.localScale, Is.EqualTo(Vector3.one));
Assert.That(instance.localScale, Is.EqualTo(Vector3.one * 12f));
Assert.That(instance.GetChild(0).localScale, Is.EqualTo(new Vector3(2f, 3f, 4f)));
var fallbackSink = new EveUnityGameObjectPlayableWorldSceneSink(