cultnet error contract: one message_invalid code replaces malformed_document_put/delete #41

Merged

libby merged 2 commits from libby/error-message-invalid into main 2026-11-08 09:17:52 +00:00

Conversation 0 Commits 2 Files changed 26 +153 -57

libby commented 2026-11-08 05:54:36 +00:00

Member

Copy link

Closes follow-up for cross-runtime malformed_document_put / malformed_document_delete. Contract chosen: fold into one message_invalid (Q6-A of docs/cultnet-error-contract-cut.md), not two new per-operation codes, because the peer already knows which operation it sent and the code needs to be added to the closed enum either way. Touches write-refusal paths: do not merge until Heimdall has said so.

• Schema (both copies): message_invalid in the code enum; details.field names the request field (message when the frame is unreadable).
• C#: CultNetErrorMessage.ForMessageInvalid; the three codeless "requires a subscriptionId or messageId" sites use it.
• Rust: CultNetErrorCode::MessageInvalid. TS: cultNetMessageInvalidError, code list. Python: message_invalid_error, code lists.
• cultmesh-py and cultmesh-ts malformed put/delete/shard-field refusals now emit it; the out-of-enum codes and TS text-prefix hack are gone.
• Parity: one captured vector (error-vectors.json) checked by the C# test (real serializer bytes), the Rust case, the TS factory test and the Python builder test.
• Verified locally: C# CultNetSchemaContractTests, Subscription and RemoteWrite filters; cultnet-rs error_message + schema discovery; cultmesh-rs cargo check; cultnet-ts (280 pass, 1 esbuild failure also failing on main); cultmesh-ts 177 pass; cultnet-py error/core tests; cultmesh-py write-authority and cultmesh suites.
• Not done: no C# test drives the subscription-id site itself; Python ENOSPC store failure still reports as message_invalid (server fault reported as peer's, pre-existing, noted in the cut doc). Rust cultmesh-rs RUDP server still refuses silently. CHANGELOG line in cultmesh-ts will conflict trivially with #40.
• No tag, no publish. Semver bumps left to the release owner.

🤖 Generated with Claude Code

Closes follow-up for cross-runtime `malformed_document_put` / `malformed_document_delete`. Contract chosen: **fold into one `message_invalid`** (Q6-A of `docs/cultnet-error-contract-cut.md`), not two new per-operation codes, because the peer already knows which operation it sent and the code needs to be added to the closed enum either way. Touches write-refusal paths: **do not merge until Heimdall has said so.** - Schema (both copies): `message_invalid` in the `code` enum; `details.field` names the request field (`message` when the frame is unreadable). - C#: `CultNetErrorMessage.ForMessageInvalid`; the three codeless "requires a subscriptionId or messageId" sites use it. - Rust: `CultNetErrorCode::MessageInvalid`. TS: `cultNetMessageInvalidError`, code list. Python: `message_invalid_error`, code lists. - cultmesh-py and cultmesh-ts malformed put/delete/shard-field refusals now emit it; the out-of-enum codes and TS text-prefix hack are gone. - Parity: one captured vector (`error-vectors.json`) checked by the C# test (real serializer bytes), the Rust case, the TS factory test and the Python builder test. - Verified locally: C# CultNetSchemaContractTests, Subscription and RemoteWrite filters; cultnet-rs error_message + schema discovery; cultmesh-rs cargo check; cultnet-ts (280 pass, 1 esbuild failure also failing on main); cultmesh-ts 177 pass; cultnet-py error/core tests; cultmesh-py write-authority and cultmesh suites. - Not done: no C# test drives the subscription-id site itself; Python `ENOSPC` store failure still reports as `message_invalid` (server fault reported as peer's, pre-existing, noted in the cut doc). Rust cultmesh-rs RUDP server still refuses silently. CHANGELOG line in cultmesh-ts will conflict trivially with #40. - No tag, no publish. Semver bumps left to the release owner. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

libby added 1 commit 2026-11-08 05:54:36 +00:00

cultnet error contract: one message_invalid code replaces malformed_document_put/delete ... 0cfd319b5e

Q6-A of docs/cultnet-error-contract-cut.md. message_invalid joins the closed
cultnet.error.v0 code enum (both schema copies), with details.field naming the
request field at fault ("message" when the whole frame cannot be read).
C# ForMessageInvalid, Rust CultNetErrorCode::MessageInvalid, TS
cultNetMessageInvalidError and Python message_invalid_error all write the same
captured bytes (error-vectors.json plus the C# and Rust cases). cultmesh-py and
cultmesh-ts refuse malformed puts and deletes with it; the C# subscription
servers use it for the missing subscriptionId.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

libby force-pushed libby/error-message-invalid from 0cfd319b5e to a558f3ad3b 2026-11-08 09:17:38 +00:00 Compare

libby merged commit a95b43d48f into main 2026-11-08 09:17:52 +00:00

libby referenced this pull request from a commit 2026-11-08 09:17:53 +00:00

Merge pull request 'cultnet error contract: one message_invalid code replaces malformed_document_put/delete' (#41) from libby/error-message-invalid into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

GameCult/CultLib!41

No description provided.