cultcache-py: single-file store lock, fsync and unique staging; msgpack hard; slot-nil reader #16

Merged

libby merged 3 commits from libby/cultcache-py-store-lock into main 2026-11-07 12:13:22 +00:00

Conversation 0 Commits 3 Files changed 6 +304 -52

libby commented 2026-11-06 20:50:21 +00:00

Member

Copy link

Brief B of the 2026-11-06 parity audit (Python CultCache store).

• push/push_all/delete take the cross-process lock on <path>.lock (flock; LockFileEx whole-file on Windows), as cultcache-ts store-file.ts; staged file <path>.tmp-<pid>-<uuid>, fsync before replace, directory fsync after.
• msgpack is a hard dependency (pyproject already said so); optional-import fallbacks removed.
• Python reads tests/vectors/slot-nil (15 accepted, 2 refused, rewritten bytes equal the reference).

Tests: python -m unittest discover -s tests in packages/cultcache-py: Ran 175 tests, OK (166 before). New tests fail when the rule breaks (checked by mutation: lock disabled -> 3 failures; fsync removed -> 2; fixed staged name -> 1; nullable nil removed -> 1 failure + 14 errors).
A write waits while a flock holder and the real TypeScript withStoreWriteLock (koffi, node 24) hold the lock.
Not run: a Rust holder (no harness; fs2 lock_exclusive is flock on Unix, which the flock holder stands in for) and the Windows LockFileEx path (no Windows here; the ctypes code is unexercised).

🤖 Generated with Claude Code

Brief B of the 2026-11-06 parity audit (Python CultCache store). - push/push_all/delete take the cross-process lock on `<path>.lock` (flock; LockFileEx whole-file on Windows), as cultcache-ts store-file.ts; staged file `<path>.tmp-<pid>-<uuid>`, fsync before replace, directory fsync after. - msgpack is a hard dependency (pyproject already said so); optional-import fallbacks removed. - Python reads tests/vectors/slot-nil (15 accepted, 2 refused, rewritten bytes equal the reference). Tests: `python -m unittest discover -s tests` in packages/cultcache-py: Ran 175 tests, OK (166 before). New tests fail when the rule breaks (checked by mutation: lock disabled -> 3 failures; fsync removed -> 2; fixed staged name -> 1; nullable nil removed -> 1 failure + 14 errors). A write waits while a flock holder and the real TypeScript withStoreWriteLock (koffi, node 24) hold the lock. Not run: a Rust holder (no harness; fs2 lock_exclusive is flock on Unix, which the flock holder stands in for) and the Windows LockFileEx path (no Windows here; the ctypes code is unexercised). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

libby added 3 commits 2026-11-06 20:50:22 +00:00

cultcache-py: msgpack is a hard dependency; drop the optional-import fallbacks ... 9548d51a71

pyproject (and cultnet-py) already declare msgpack as required; the code treated it
as optional behind a cultcache-py[msgpack] extra that does not exist.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-py: single-file store takes the cross-process lock, stages uniquely and fsyncs ... b2434fc7fc

push, push_all and delete hold <path>.lock (flock; LockFileEx over the whole file on
Windows, as cultcache-ts store-file.ts) across the read and the replace. The staged file
is <path>.tmp-<pid>-<uuid>, fsynced before os.replace, with a directory fsync after off
Windows; a failed write removes its staged file and leaves the store.

Tests fail when the rule breaks: a write waits while a flock holder (Rust's lock) and the
TypeScript runtime's withStoreWriteLock hold the lock, three processes lose no writes,
fsync precedes replace, staged names differ, a failed replace leaves no staged file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cultcache-py: read the slot-nil vector; changelog for the store lock and msgpack ... 00ecdcf9e6

tests/vectors/slot-nil was read by TS only. The Python reader accepts the same 15 rows
and refuses the same 2 as the C# reference and rewrites the reference's bytes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

libby merged commit 530acdac20 into main 2026-11-07 12:13:22 +00:00

libby referenced this pull request from a commit 2026-11-07 12:13:23 +00:00

Merge pull request 'cultcache-py: single-file store lock, fsync and unique staging; msgpack hard; slot-nil reader' (#16) from libby/cultcache-py-store-lock into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

GameCult/CultLib!16

No description provided.