CultNet: refuse a binding serializer that returns null #177

Merged
eureka merged 3 commits from hands/cultnet-cs-null-serializer into main 2026-11-19 20:19:22 +00:00
Member

Closes Soul finding cultlib-gaps:finding:cut-bytes-after-cs.s3.null-serializer-silent-fallback.

ToRawRecord used binding?.PayloadSerializer(document) ?? default, so a binding whose serializer returned null silently took the default serializer. Now a binding owns its bytes: null throws InvalidOperationException (type and schema named). CreateRawDocumentPutMessage shares the same check (it previously put a null payload on the wire). Non-null results unchanged.

Test: BytesAfterPathTests.ABindingWhoseSerializerReturnsNullIsRefusedNotDefaulted fails on the old line (Expected InvalidOperationException, was null); full GameCult.Networking.Tests 846 passed, 4 skipped.

🤖 Generated with Claude Code

Closes Soul finding cultlib-gaps:finding:cut-bytes-after-cs.s3.null-serializer-silent-fallback. ToRawRecord used `binding?.PayloadSerializer(document) ?? default`, so a binding whose serializer returned null silently took the default serializer. Now a binding owns its bytes: null throws InvalidOperationException (type and schema named). CreateRawDocumentPutMessage shares the same check (it previously put a null payload on the wire). Non-null results unchanged. Test: BytesAfterPathTests.ABindingWhoseSerializerReturnsNullIsRefusedNotDefaulted fails on the old line (Expected InvalidOperationException, was null); full GameCult.Networking.Tests 846 passed, 4 skipped. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
CultNet: refuse a binding serializer that returns null instead of defaulting
Some checks failed
CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Failing after 16m9s
f4e3359eaf
ToRawRecord's 'binding?.PayloadSerializer(document) ?? default' let the default
serializer silently override a bound owner whose serializer returned null. The
binding path now refuses (InvalidOperationException, naming type and schema);
CreateRawDocumentPutMessage shares the same check instead of putting a null
payload on the wire. Non-null results are unchanged.

Closes cultlib-gaps:finding:cut-bytes-after-cs.s3.null-serializer-silent-fallback

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ci: rerun (leases shard failed after 16m with no log access on f4e3359e; the mesh tests pass locally, 364)
Some checks failed
CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Failing after 30m26s
080aa8aa20
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge branch 'main' into hands/cultnet-cs-null-serializer
All checks were successful
CultMesh portability and performance / ubuntu-latest reactive semantics and leases (pull_request) Successful in 32m21s
95a1610468
eureka merged commit baf4ecf78f into main 2026-11-19 20:19:22 +00:00
eureka deleted branch hands/cultnet-cs-null-serializer 2026-11-19 20:19:23 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/CultLib!177
No description provided.