Heimdall start refusal: log the HTTP status and Heimdall's error code #79

Merged

heimdall merged 2 commits from heimdall/start-refusal-status into main

2026-11-12 14:48:31 +00:00

heimdall commented

2026-11-12 14:26:16 +00:00

Member

HeimdallAuthService.StartAsync threw Heimdall rejected the auth start. with nothing to tell a wrong app secret (401 app_auth_required) from a Heimdall fault. The exception, and so the Heimdall start refused: journal line, now reads Heimdall rejected the auth start (HTTP 401, app_auth_required).

The error code is shown only when Heimdall's body has a string error that is 1-64 chars of [a-z0-9_]; any other body text (detail, non-JSON, nested, hostile) is never echoed, and the app secret is never involved.

Test first: A_refused_start_logs_the_status_and_a_well_formed_error_code_and_nothing_else_from_the_body (5 cases) failed before the change; the existing refusal theory now expects (HTTP 500). Heimdall-filtered suite: 155 pass. Not deployed.

🤖 Generated with Claude Code

`HeimdallAuthService.StartAsync` threw `Heimdall rejected the auth start.` with nothing to tell a wrong app secret (401 `app_auth_required`) from a Heimdall fault. The exception, and so the `Heimdall start refused:` journal line, now reads `Heimdall rejected the auth start (HTTP 401, app_auth_required).` The error code is shown only when Heimdall's body has a string `error` that is 1-64 chars of `[a-z0-9_]`; any other body text (detail, non-JSON, nested, hostile) is never echoed, and the app secret is never involved. Test first: `A_refused_start_logs_the_status_and_a_well_formed_error_code_and_nothing_else_from_the_body` (5 cases) failed before the change; the existing refusal theory now expects `(HTTP 500)`. Heimdall-filtered suite: 155 pass. Not deployed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

heimdall added 1 commit

2026-11-12 14:26:16 +00:00

Heimdall start refusal: log the HTTP status and Heimdall's error code c085cead9d

The journal said only 'Heimdall rejected the auth start', which cannot tell a wrong app secret (401 app_auth_required) from a fault. The message now carries the status and, when the body has one, an error code that is a short snake_case token; no other body text is echoed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

heimdall added 1 commit

2026-11-12 14:41:17 +00:00

Start refusal: bound the body read, survive undecodable bodies, pin the code length cap 87a1bb6b3b

Soul pass on c085cead: a refusal with an unsupported charset escaped as a 500, the body was read without a bound, and the 64-character cap was untested.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

heimdall merged commit b687da954b into main

2026-11-12 14:48:31 +00:00

heimdall referenced this pull request from a commit

2026-11-12 14:48:32 +00:00

Merge pull request 'Heimdall start refusal: log the HTTP status and Heimdall's error code' (#79) from heimdall/start-refusal-status into main

heimdall referenced this pull request

2026-11-12 14:48:42 +00:00

Start refusal: read headers only so the 4 KiB body bound limits the read #80