Dings migration step 5a: neutral fallback id tied to the catalog; steps 2, 3, 5b recorded STOPPED #46

Merged

aqua merged 1 commit from aqua/dings-migration-step5a into main 2026-11-12 11:02:38 +00:00

Conversation 0 Commits 1 Files changed 5 +23 -8

aqua commented 2026-11-12 11:00:10 +00:00

Member

Copy link

Step 5a: NEUTRAL_INSTRUMENT_ID (voices.mjs:11, moved out of a literal in build.mjs; build.mjs imports side-effect-free so a test cannot load it) + tools/dings-voices/src/neutral_instrument.test.mjs asserting it is a tools/aqua-feel/lowered-dings/*.dsp name. Wired into the README Run line (dings-voices has no package.json). neutral-*.wav sha256 identical before/after (dm a3bf9076, invite 4a4652d6, mention 25938d0e, message 26f1d74a).

Doc: Step 2, 3, 5b marked STOPPED with the question/ruling/fact that unblocks each and who supplies it; Status summary added at top.

Ran: neutral_instrument.test.mjs (pass), mutation to bogus-bell (fails as intended), polyphony.test.mjs (pass), build.mjs hash compare. Not run: dotnet (untouched), aqua-feel chain, earcon-workshop/test.mjs. Nothing heard.

🤖 Generated with Claude Code

Step 5a: `NEUTRAL_INSTRUMENT_ID` (voices.mjs:11, moved out of a literal in build.mjs; build.mjs imports side-effect-free so a test cannot load it) + `tools/dings-voices/src/neutral_instrument.test.mjs` asserting it is a `tools/aqua-feel/lowered-dings/*.dsp` name. Wired into the README Run line (dings-voices has no package.json). neutral-*.wav sha256 identical before/after (dm a3bf9076, invite 4a4652d6, mention 25938d0e, message 26f1d74a). Doc: Step 2, 3, 5b marked STOPPED with the question/ruling/fact that unblocks each and who supplies it; Status summary added at top. Ran: neutral_instrument.test.mjs (pass), mutation to bogus-bell (fails as intended), polyphony.test.mjs (pass), build.mjs hash compare. Not run: dotnet (untouched), aqua-feel chain, earcon-workshop/test.mjs. Nothing heard. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

aqua added 1 commit 2026-11-12 11:00:10 +00:00

Dings migration: step 5a ties the neutral fallback id to the catalog mirror; steps 2, 3, 5b recorded as STOPPED with their unblockers ... 7458fbd93c

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

aqua merged commit c0e6b980fe into main 2026-11-12 11:02:38 +00:00

aqua referenced this pull request from a commit 2026-11-12 11:02:40 +00:00

Merge pull request 'Dings migration step 5a: neutral fallback id tied to the catalog; steps 2, 3, 5b recorded STOPPED' (#46) from aqua/dings-migration-step5a into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

GameCult/AquaSynth!46

No description provided.