Aetheria/Assets/Scripts/ServerShared/Behaviors/ConstantWeapon.cs
Meta Vens b4702bbc33 Cut 7: continuous consumers brown out instead of flicking off
docs/stats-and-power-target.md: "Continuous consumers brown out through a
power supply curve on their performance stats." Cut 6 wired the curve
(EquippedItem.PowerSupplyFactor) but every continuous consumer still gated
its own effect on Item.PowerSupply >= 1f, so an 80% grant produced nothing
instead of 80% performance.

- Thruster/AetherDrive: gate narrowed from ">= 1f" to a true-zero floor
  (> 1e-4f, PowerBus's own epsilon); Thrust/Torque are plain Evaluate()
  reads, so a curved stat already degrades once the full-grant demand is
  dropped.
- Radiator: the gate is deleted outright. PumpedHeat is already a curved
  Evaluate() read; waste heat is unaffected, so a starved radiator now falls
  behind instead of refusing to pump, and zero supply already zeroes
  PumpedHeat via the curve with no special case needed.
- ConstantWeapon: the weapon no longer safes itself off (_firing = false)
  on a partial grant -- only true zero still stops it. Damage already
  degrades via base.Execute's own Evaluate() read.
- EnergyDraw: has no performance stat of its own -- its Execute return
  value IS the effect (gates its BehaviorGroup). Narrowed the same way:
  a partial grant still passes, only true zero closes the gate.

InputCapacitor and the three instant consumers (InstantWeapon, Sensor,
Shield) are untouched: all-or-nothing on a partial charge still holds.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-19 04:10:19 +02:00

171 lines
No EOL
5.5 KiB
C#

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
using System;
using MessagePack;
using Newtonsoft.Json;
using CultMath;
using static CultMath.math;
[Inspectable, MessagePackObject, JsonObject(MemberSerialization.OptIn)]
public class ConstantWeaponData : WeaponData
{
[Inspectable, JsonProperty("ammoInterval"), Key(17)]
public float AmmoInterval = 1;
public override Behavior CreateInstance(EquippedItem item)
{
return new ConstantWeapon(this, item);
}
public override Behavior CreateInstance(ConsumableItemEffect item)
{
return new ConstantWeapon(this, item);
}
}
public class ConstantWeapon : Weapon, IProgressBehavior, IEventBehavior, IPowerConsumer
{
private ConstantWeaponData _data;
private int _ammo = 1;
private float _ammoInterval;
private float _reload;
private bool _reloading;
public override int Ammo
{
get => _ammo;
}
public float Progress
{
get { return saturate(_reload); }
}
public override float DamagePerSecond => Damage;
public override float RangeDamagePerSecond(float range)
{
return Damage * _data.DamageCurve.Evaluate(saturate(unlerp(MinRange, Range, range)));
}
public event Action OnReloadBegin;
public event Action OnReloadComplete;
public event Action OnStartFiring;
public event Action OnStopFiring;
public void ResetEvents()
{
OnReloadBegin = null;
OnReloadComplete = null;
OnStartFiring = null;
OnStopFiring = null;
}
public ConstantWeapon(ConstantWeaponData data, EquippedItem item) : base(data, item)
{
_data = data;
}
public ConstantWeapon(ConstantWeaponData data, ConsumableItemEffect item) : base(data, item)
{
_data = data;
}
// Cut 3 (docs/stats-and-power-cut.md): the request the bus needs before Execute runs -- what continuing to
// fire this tick would cost, or nothing when not firing or safed. _firing is set externally (Activate/
// Deactivate) before Entity.Update calls PowerBus.Step, so it is already current when this runs.
public float PowerRequest(float dt) => _firing && StanceAllowsFire ? Evaluate(_data.Energy) * dt : 0f;
// Cut 5 (docs/stats-and-power-cut.md §1.3, PowerTiers.cs): Low -- offense, same as InstantWeapon.
public int DefaultPowerTier => PowerTiers.Low;
public override bool Execute(float dt)
{
base.Execute(dt);
if (_firing && !StanceAllowsFire)
{
// Safed: shooter has a target and hasn't declared hostility toward it.
_firing = false;
OnStopFiring?.Invoke();
return false;
}
if (_firing)
{
// Cut 7 (docs/stats-and-power-target.md): base.Execute(dt) above already re-read Damage through
// Evaluate(_data.Damage), so a Damage stat carrying a PowerSupply term already fires this tick for
// less under a partial grant -- the weapon no longer safes itself off (the "flicking off gear" bug
// the ruling names) just because the grant fell short of 1. Only true zero supply still stops it.
if (Item != null && Item.PowerSupply <= 1e-4f)
{
_firing = false;
OnStopFiring?.Invoke();
return false;
}
if (_data.AmmoType.IsSet())
{
if (_reloading)
{
_reload -= dt / _data.ReloadTime;
if (_reload < 0)
{
_reloading = false;
OnReloadComplete?.Invoke();
}
return false;
}
_ammoInterval -= dt / _data.AmmoInterval;
if (_ammoInterval < 0)
{
_ammoInterval = 1;
if (_data.MagazineSize > 1 && _ammo > 0) _ammo--;
else
{
var cargo = Entity.FindItemInCargo(_data.AmmoType.Key);
if (cargo != null)
{
var item = cargo.ItemsOfType[_data.AmmoType.Key][0];
if (item is SimpleCommodity simpleCommodity)
cargo.Remove(simpleCommodity, 1);
if(_data.MagazineSize > 1)
{
_reloading = true;
_reload = 1;
OnReloadBegin?.Invoke();
_firing = false;
OnStopFiring?.Invoke();
}
}
return false;
}
}
}
CauseWearDamage(dt);
AddHeat(Evaluate(_data.Heat) * dt);
Entity.VisibilitySources[this] = Evaluate(_data.Visibility);
}
return true;
}
public override void Activate()
{
if(!_firing && !_reloading)
{
_firing = true;
OnStartFiring?.Invoke();
}
}
public override void Deactivate()
{
if (_firing)
{
_firing = false;
OnStopFiring?.Invoke();
}
}
}