GameCult/Aetheria
Watch
9
0
Fork
You've already forked Aetheria
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Retire the Wwise catalog fields (SoundBank, AudioStats, faction music) #4

Merged
nibu merged 1 commit from nibu/remove-wwise-catalog-fields into master 2026-11-10 17:50:48 +00:00
Conversation 1 Commits 1 Files changed 3 +7 -26
nibu commented 2026-11-10 05:52:11 +00:00
Member
Copy link

Closes follow-up aetheria-release/wwise-catalog-fields.

Deleted: EquippableItemData.SoundBank (key 21), AudioStats (key 22) with AudioStat, Faction.OverworldMusic/CombatMusic/BossMusic (keys 13-15). Keys left as never-reuse comments. RpmAudioParameter/TorqueRatioAudioParameter were already gone.

Checked:

  • Grep over code, tests, Unity assets/prefabs, tools, mod packages: only declarations matched; no reader or writer. Same on origin/eureka/aetheria-release-audio-1 (declarations only) and current master (a4be037a4).
  • Shipped catalog loaded through the test harness: 29/73 equippables hold a SoundBank value, 0 hold AudioStats, 2/16 factions hold music ids. Stored but unread.
  • Mod package aetheria.nakovalnya composes with no exclusions.
  • No catalog rewrite: the reader skips unknown keys and the next catalog write drops the old values.

Tests: full Aetheria.Shared.Tests 16 failed / 2904 with the change, and 16 failed on unmodified master (pinned digests and physics numerics; only 3 failing names compared individually, the rest by count).

Docs: docs/aetheria-release-map.md AU1 updated. Aqua's audio presenter untouched.

🤖 Generated with Claude Code

Closes follow-up aetheria-release/wwise-catalog-fields. **Deleted:** `EquippableItemData.SoundBank` (key 21), `AudioStats` (key 22) with `AudioStat`, `Faction.OverworldMusic`/`CombatMusic`/`BossMusic` (keys 13-15). Keys left as never-reuse comments. `RpmAudioParameter`/`TorqueRatioAudioParameter` were already gone. **Checked:** - Grep over code, tests, Unity assets/prefabs, tools, mod packages: only declarations matched; no reader or writer. Same on `origin/eureka/aetheria-release-audio-1` (declarations only) and current master (`a4be037a4`). - Shipped catalog loaded through the test harness: 29/73 equippables hold a SoundBank value, 0 hold AudioStats, 2/16 factions hold music ids. Stored but unread. - Mod package `aetheria.nakovalnya` composes with no exclusions. - No catalog rewrite: the reader skips unknown keys and the next catalog write drops the old values. **Tests:** full `Aetheria.Shared.Tests` 16 failed / 2904 with the change, and 16 failed on unmodified master (pinned digests and physics numerics; only 3 failing names compared individually, the rest by count). Docs: `docs/aetheria-release-map.md` AU1 updated. Aqua's audio presenter untouched. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Nothing reads or writes them (audio is native Unity plus AquaSynth). Keys 21, 22 and 13 to 15 stay
reserved as never-reuse comments, as with the earlier retirements. The shipped catalog still holds old
values; the reader skips unknown keys.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nibu commented 2026-11-10 17:50:47 +00:00
Author
Member
Copy link

Steward check before merge (nibu, 2026-11-10).

  • Applies to master; mergeable (touches no file #2/#3 touched).
  • dotnet test tests/Aetheria.Shared.Tests on the PR head: 2887 pass, 17 fail. Master: 15 fail, the same pre-existing red set. The two extras are EconomyCommandTests flakes (shared console and catalog capture under parallel runs); EconomyCommandTests alone on this head: 47/47 pass.
  • Falsification: the claim that matters is that the shipped GameData/Aetheria.cc, which still carries keys 13-15/21/22 values, loads after the fields are gone. The whole shipped-catalog suite (hundreds of tests that load it) passes on this head with the same failures as master, so the reader does skip them. A grep of every *.cs for SoundBank|AudioStats?|OverworldMusic|CombatMusic|BossMusic finds only commented-out code and docs history; no Unity-only script reads the removed fields. Keys stay as never-reuse comments.
  • Merged. Unity (not available on this host) is unbuilt for this and the other Aetheria PRs; recorded, not a gate.
Steward check before merge (nibu, 2026-11-10). - Applies to master; mergeable (touches no file #2/#3 touched). - `dotnet test tests/Aetheria.Shared.Tests` on the PR head: 2887 pass, 17 fail. Master: 15 fail, the same pre-existing red set. The two extras are `EconomyCommandTests` flakes (shared console and catalog capture under parallel runs); `EconomyCommandTests` alone on this head: 47/47 pass. - Falsification: the claim that matters is that the shipped `GameData/Aetheria.cc`, which still carries keys 13-15/21/22 values, loads after the fields are gone. The whole shipped-catalog suite (hundreds of tests that load it) passes on this head with the same failures as master, so the reader does skip them. A grep of every `*.cs` for `SoundBank|AudioStats?|OverworldMusic|CombatMusic|BossMusic` finds only commented-out code and docs history; no Unity-only script reads the removed fields. Keys stay as never-reuse comments. - Merged. Unity (not available on this host) is unbuilt for this and the other Aetheria PRs; recorded, not a gate.
nibu merged commit 9f8452818d into master 2026-11-10 17:50:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Aetheria!4
No description provided.