GameCult/Aetheria
Watch
9
0
Fork
You've already forked Aetheria
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ship-authoring stats --top-speed adds the VelocityLimit a bare hull lacks #3

Merged
nibu merged 1 commit from nibu/ship-authoring-top-speed-adds into master 2026-11-10 17:39:10 +00:00
Conversation 1 Commits 1 Files changed 2 +9 -4
2 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/Aetheria.Shared.Tests/ShipProductTests.cs
View file

@ -353,8 +353,6 @@ public sealed class ShipProductTests : IDisposable
RefusedAndUntouched(path, "--mass", "5", "--mass", "6");
// A valid flag beside a bad one writes nothing.
RefusedAndUntouched(path, "--mass", "5", "--durability", "-2");
RefusedAndUntouched(bare, "--top-speed", "50");
RefusedAndUntouched(bare, "--mass", "5", "--top-speed", "50");
// Two VelocityLimits leave no one top speed to set.
RefusedAndUntouched(twin, "--top-speed", "50");
@ -385,6 +383,10 @@ public sealed class ShipProductTests : IDisposable
Assert.Equal((1f, 0f, 8000f), (ShipAuthoringStore.Load(path).Hull.Mass, ShipAuthoringStore.Load(path).Hull.Drag, ShipAuthoringStore.Load(path).Hull.Durability));
Assert.Equal(0, Run("stats", bare, "--armor", "12").Code);
Assert.Equal(12f, ShipAuthoringStore.Load(bare).Hull.Armor);
// A hull with no top speed (create without --like) gets its one VelocityLimit from the first --top-speed.
Assert.Equal(0, Run("stats", bare, "--top-speed", "50").Code);
var added = ShipAuthoringStore.Load(bare).Hull.Behaviors.OfType<VelocityLimitData>().Single().TopSpeed;
Assert.Equal((50f, 50f), (added.Min, added.Max));
}
[Fact]

7
tools/AetherDb/ShipAuthoringCommands.cs
View file

@ -110,8 +110,11 @@ public static class ShipAuthoringCommands
var (hull, ship, _) = ShipAuthoringStore.Load(args[1]);
if (stats.TryGetValue("--top-speed", out var topSpeed))
{
var limits = (hull.Behaviors ?? new List<BehaviorData>()).OfType<VelocityLimitData>().ToArray();
if (limits.Length != 1) throw new InvalidOperationException($"{ship.Id}: --top-speed needs exactly one VelocityLimit on the hull; it has {limits.Length}.");
hull.Behaviors ??= new List<BehaviorData>();
var limits = hull.Behaviors.OfType<VelocityLimitData>().ToList();
// A hull made without --like has none, and Validate refuses a ship hull without one: the first --top-speed adds it.
if (limits.Count == 0) { limits.Add(new VelocityLimitData()); hull.Behaviors.Add(limits[0]); }
if (limits.Count != 1) throw new InvalidOperationException($"{ship.Id}: --top-speed needs at most one VelocityLimit on the hull; it has {limits.Count}.");
// A fixed top speed, as every shipped hull authors one (Min equal to Max); its terms are kept.
limits[0].TopSpeed.Min = limits[0].TopSpeed.Max = topSpeed;
}