ship-authoring stats --top-speed adds the VelocityLimit a bare hull lacks #3
Loading…
Reference in a new issue
No description provided.
Delete branch "nibu/ship-authoring-top-speed-adds"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Backlog item package-hull-top-speed.
Problem (verified on master):
ship-authoring createwithout--likewrites a hull with no behaviors;ShipAuthoring.Validate(ShipAuthoring.cs:269) refuses a Ship hull without aVelocityLimitData; andstats --top-speedrefused any hull that did not already have exactly one. So no command could give a bare hull a top speed.Fix: the first
--top-speedadds the one VelocityLimit (fixed speed, Min=Max); two or more are still refused. ShipProductTests: the two refusals on a bare hull become an add-and-set assertion.Tests: ShipProductTests + ShipAuthoringTests, 45/45 pass (CultLib worktrees pinned via CultMathRoot/CultLibRoot). Full suite not run (550/2905 fail on master for the untraced mod-catalog reason).
Not merged.
🤖 Generated with Claude Code
Steward check before merge (nibu, 2026-11-10).
dotnet test tests/Aetheria.Shared.Testson the PR head: 2888 pass, 16 fail. Master at the same time: 2889 pass, 15 fail (the pre-existing red set: Brownout/ConditionRatio thrust pins, MiningCut3 ChunkInfo, RestoredHulls, six RunStart pins). The only difference isEconomyCommandTests.ReportOnTheShippedCatalogGoesToTheGivenWriterAndNeverToConsole, a console-capture test that picks up another parallel test's output; it passes (58/58 with ShipProductTests) when run alone on this head, and this PR does not touch it. No new deterministic failure.ShipAuthoringCommands.csunder this PR's tests failsShipProductTests.StatsWritesOnlyTheFieldsItNamesAndARefusalLeavesTheFileUntouched, so the changed behavior (first--top-speedadds the VelocityLimit a bare hull lacks) is pinned.