From 4a462859d22dbfcb9db8c43fd743d9ced3273a04 Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Thu, 4 Jun 2026 22:00:51 +0100 Subject: [PATCH] Tolerate legacy moderation cursor state --- packages/core/src/void-self-state-domain.ts | 41 ++++++++++++++++++- ...d-state-boundary-normalization-fixture.ps1 | 8 ++++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/packages/core/src/void-self-state-domain.ts b/packages/core/src/void-self-state-domain.ts index 25e540c..087509d 100644 --- a/packages/core/src/void-self-state-domain.ts +++ b/packages/core/src/void-self-state-domain.ts @@ -443,7 +443,41 @@ export const voidSelfProfileSchema = z.object({ updatedAt: timestampSchema, }).strict(); -export const voidModerationCursorSchema = z.object({ +const legacyModerationCursorEpoch = "1970-01-01T00:00:00.000Z"; + +function isUnknownRecord(value: unknown): value is Record { + return typeof value === "object" && value !== null && !Array.isArray(value); +} + +function latestUserStatusTimestamp(userStatuses: unknown[]): string | undefined { + const timestamps = userStatuses + .map((entry) => isUnknownRecord(entry) ? entry.updatedAt : undefined) + .filter((value): value is string => typeof value === "string" && value.trim().length > 0) + .sort(); + return timestamps.at(-1); +} + +function normalizeLegacyModerationCursorInput(value: unknown): unknown { + if (!isUnknownRecord(value) || value.schemaVersion !== undefined || !Array.isArray(value.userStatuses)) { + return value; + } + + return { + schemaVersion: 1, + lastReviewedMessageId: + typeof value.lastReviewedMessageId === "string" ? value.lastReviewedMessageId : undefined, + lastReviewedTimestamp: + typeof value.lastReviewedTimestamp === "string" ? value.lastReviewedTimestamp : undefined, + openCases: Array.isArray(value.openCases) ? value.openCases : [], + userStatuses: value.userStatuses, + repoActivityCursor: Array.isArray(value.repoActivityCursor) ? value.repoActivityCursor : [], + updatedAt: typeof value.updatedAt === "string" + ? value.updatedAt + : latestUserStatusTimestamp(value.userStatuses) ?? legacyModerationCursorEpoch, + }; +} + +const voidModerationCursorPayloadSchema = z.object({ schemaVersion: z.literal(1), lastReviewedMessageId: z.string().trim().min(1).optional(), lastReviewedTimestamp: timestampSchema.optional(), @@ -453,6 +487,11 @@ export const voidModerationCursorSchema = z.object({ updatedAt: timestampSchema, }).strict(); +export const voidModerationCursorSchema = z.preprocess( + normalizeLegacyModerationCursorInput, + voidModerationCursorPayloadSchema, +); + export const voidSpeechReceiptsSchema = z.object({ schemaVersion: z.literal(1), recentReceipts: z.array(deliveryReceiptSchema).default([]), diff --git a/scripts/smoke-void-state-boundary-normalization-fixture.ps1 b/scripts/smoke-void-state-boundary-normalization-fixture.ps1 index 624e50e..01dfbc1 100644 --- a/scripts/smoke-void-state-boundary-normalization-fixture.ps1 +++ b/scripts/smoke-void-state-boundary-normalization-fixture.ps1 @@ -98,6 +98,8 @@ try { $state = $stateJson | ConvertFrom-Json $memory = @($state.thoughtMemory.shortTerm | Where-Object { $_.memoryId -eq "fixture-future-short-term" })[0] $candidate = @($state.candidateInterventions.interventions | Where-Object { $_.interventionId -eq "fixture-targetless-queued" })[0] + $legacyCursorJson = Invoke-NodeChecked -Arguments @("-e", "const core=require('./packages/core/dist/index.js'); const parsed=core.voidModerationCursorSchema.parse({ userStatuses: [{ userId: 'fixture-user', userName: 'Fixture User', status: 'watched', summary: 'Legacy bare status patch should decode as a cursor document.', updatedAt: '2026-06-04T00:00:00.000Z' }] }); console.log(JSON.stringify(parsed));") + $legacyCursor = $legacyCursorJson | ConvertFrom-Json if ($memory.createdAt -eq "2999-01-01T00:00:00.000Z" -or $memory.updatedAt -eq "2999-01-01T00:00:00.000Z") { throw "Short-term memory kept model-authored future timestamps." @@ -111,6 +113,12 @@ try { if (-not @($candidate.tags).Contains("normalized:targetless-queued-to-deferred")) { throw "Targetless queued candidate was deferred without a normalization tag." } + if ($legacyCursor.schemaVersion -ne 1 -or @($legacyCursor.openCases).Count -ne 0 -or @($legacyCursor.repoActivityCursor).Count -ne 0) { + throw "Legacy bare moderation userStatuses patch did not normalize to a canonical cursor document." + } + if ($legacyCursor.updatedAt -ne "2026-06-04T00:00:00.000Z") { + throw "Legacy bare moderation cursor did not inherit the latest status timestamp." + } Assert-NotFutureTimestamp -Timestamp $candidate.createdAt -Label "candidate createdAt" Assert-NotFutureTimestamp -Timestamp $candidate.updatedAt -Label "candidate updatedAt"