Extract Persona turn assembler

This commit is contained in:
Meta Vens 2026-07-16 03:51:43 +01:00
commit 059f9b39df
6 changed files with 133 additions and 63 deletions

View file

@ -19,7 +19,6 @@ import {
} from "@voidbot/core";
import { createTextEmbedder, createVectorStores, RetrievalService } from "@voidbot/rag";
import {
type PromptImageAttachment,
type SourceMessage,
} from "@voidbot/shared";
import {
@ -59,12 +58,12 @@ import {
import { projectPersonaMemorySurface } from "../apps/persona-scheduler/dist/persona-memory-projector.js";
import { readPersonaCuriosityEvidence } from "../apps/persona-scheduler/dist/persona-curiosity-context-source.js";
import { projectPersonaCuriosityContext } from "../apps/persona-scheduler/dist/persona-curiosity-projector.js";
import { projectPersonaConversation } from "../apps/persona-scheduler/dist/persona-conversation-projector.js";
import { buildPersonaJurisdictionDiveDirective, buildPersonaTurnPrompt, renderPersonaIdentityDoctrine } from "../apps/persona-scheduler/dist/persona-turn-prompt-projector.js";
import { renderPersonaIdentityDoctrine } from "../apps/persona-scheduler/dist/persona-turn-prompt-projector.js";
import { projectGamecultPersonaState, projectNativePersonaBody } from "../apps/persona-scheduler/dist/persona-standard-state-projector.js";
import type { PersonaHumanPronounGuidance as RepoFaceHumanPronounGuidance } from "../apps/persona-scheduler/dist/persona-social-context-projector.js";
import { projectPersonaStatePacket } from "../apps/persona-scheduler/dist/persona-state-packet-projector.js";
import { projectPersonaText } from "../apps/persona-scheduler/dist/persona-text-projection-actuator.js";
import { assemblePersonaTurn } from "../apps/persona-scheduler/dist/persona-turn-assembler.js";
import { readPersonaHumanPronounGuidance } from "../apps/persona-scheduler/dist/persona-social-context-source.js";
import {
readDiscordActivitySnapshot,
@ -433,46 +432,32 @@ async function queueRepoFaceTurn(input: {
? projectNativePersonaBody(identity)
: renderRepoActivityObservation(readRepoActivity({ identity, storageRoot: input.config.storageRoot }));
const globalAgentDoctrine = await loadGlobalAgentDoctrine();
const conversationProjection = projectPersonaConversation({
identity,
recentMessages,
channelSnapshots,
pendingMentions: input.pendingMentions,
channelPlan,
});
const conversationMemorySurface = conversationProjection.transcript;
const prompt = buildPersonaTurnPrompt({
const assembly = assemblePersonaTurn({
identity,
channelId,
channelPlan,
channelSnapshots,
recentMessages,
memorySurface,
repoActivitySurface,
conversationMemorySurface,
humanPronounGuidance,
bifrostDigest,
channelSnapshots,
participant: input.participant,
pendingMentions: input.pendingMentions,
jurisdictionDive: buildPersonaJurisdictionDiveDirective(identity, input.participant),
memorySurface,
repoActivitySurface,
humanPronounGuidance,
bifrostDigest,
githubActionsEnabled: input.config.repoFaceGithubActionsEnabled,
globalAgentDoctrine,
});
const imageAttachments = collectPromptImageAttachments([
recentMessages,
...channelSnapshots.map((snapshot) => snapshot.messages),
].flat());
const result = await submitPersonaTurn({
jobQueue: input.storage.jobQueue,
provider: input.config.repoFaceHeartbeats.provider,
identityId: identity.id,
queuedAt: input.queuedAt,
channelId,
prompt,
prompt: assembly.prompt,
recentMessages,
conversationFocus: conversationProjection.focus,
conversationThreads: conversationProjection.threads,
imageAttachments,
conversationFocus: assembly.conversation.focus,
conversationThreads: assembly.conversation.threads,
imageAttachments: assembly.imageAttachments,
});
return {
@ -698,18 +683,12 @@ async function assembleRepoFaceTurnPrompt(input: {
const globalAgentDoctrine = await loadGlobalAgentDoctrine();
const conversationMemorySurface = input.conversationSurfacePath
? await readOptionalMemorySurface(input.conversationSurfacePath)
: projectPersonaConversation({
identity,
recentMessages,
channelSnapshots,
pendingMentions: [],
channelPlan,
}).transcript;
: undefined;
const participant = buildInspectionParticipant(
identity,
input.config.repoFaceHeartbeats.baseRecoveryMinutes,
);
const prompt = buildPersonaTurnPrompt({
const assembly = assemblePersonaTurn({
identity,
channelId,
channelPlan,
@ -723,7 +702,6 @@ async function assembleRepoFaceTurnPrompt(input: {
bifrostDigest,
participant,
pendingMentions: [],
jurisdictionDive: buildPersonaJurisdictionDiveDirective(identity, participant),
githubActionsEnabled: input.config.repoFaceGithubActionsEnabled,
globalAgentDoctrine,
});
@ -731,13 +709,13 @@ async function assembleRepoFaceTurnPrompt(input: {
if (input.outPath) {
const outPath = resolve(input.outPath);
await mkdir(dirname(outPath), { recursive: true });
await writeFile(outPath, prompt, "utf8");
await writeFile(outPath, assembly.prompt, "utf8");
}
return {
ok: true,
identityId: identity.id,
promptLength: prompt.length,
promptLength: assembly.prompt.length,
outPath: input.outPath ? resolve(input.outPath) : undefined,
memorySurfacePath: input.memorySurfacePath ? resolve(input.memorySurfacePath) : undefined,
conversationSurfacePath: input.conversationSurfacePath ? resolve(input.conversationSurfacePath) : undefined,
@ -965,31 +943,6 @@ function renderRepoActivityObservation(observation: RepoActivityObservation): st
return observation.digest || `- No recent ${observation.sourceRepoName} activity was reported.`;
}
function collectPromptImageAttachments(messages: SourceMessage[]): PromptImageAttachment[] {
const seen = new Set<string>();
const images: PromptImageAttachment[] = [];
for (const message of messages) {
for (const attachment of message.attachments ?? []) {
if (attachment.kind !== "image" || !attachment.localPath) {
continue;
}
const key = attachment.localPath;
if (seen.has(key)) {
continue;
}
seen.add(key);
images.push({
messageId: message.id,
authorName: message.authorName,
filename: attachment.filename,
contentType: attachment.contentType,
localPath: attachment.localPath,
});
}
}
return images.slice(0, 8);
}
async function readOptionalMemorySurface(path: string | undefined): Promise<string | undefined> {
if (!path) {
return undefined;

View file

@ -70,6 +70,7 @@ import { readPersonaCuriosityEvidence } from "../apps/persona-scheduler/dist/per
import { projectPersonaCuriosityContext } from "../apps/persona-scheduler/dist/persona-curiosity-projector.js";
import { projectPersonaConversation, renderPersonaRoomTopicSaturation } from "../apps/persona-scheduler/dist/persona-conversation-projector.js";
import { buildPersonaJurisdictionDiveDirective, buildPersonaTurnPrompt } from "../apps/persona-scheduler/dist/persona-turn-prompt-projector.js";
import { assemblePersonaTurn } from "../apps/persona-scheduler/dist/persona-turn-assembler.js";
import { projectGamecultPersonaState } from "../apps/persona-scheduler/dist/persona-standard-state-projector.js";
import { projectPersonaStatePacket } from "../apps/persona-scheduler/dist/persona-state-packet-projector.js";
import { extractLastPersonaProjectionMessage, isRetryablePersonaProjectionFailure } from "../apps/persona-scheduler/dist/persona-text-projection-actuator.js";
@ -681,6 +682,41 @@ const projectedTurnPrompt = buildPersonaTurnPrompt({
globalAgentDoctrine: "Global doctrine.",
});
assert.match(projectedTurnPrompt, /A direct call is tugging at you[\s\S]*Nibu, answer this/, "the pure turn-prompt projector owns situation and pending-call policy from supplied facts");
const assembledTurn = assemblePersonaTurn({
identity: routedIdentity,
channelId: "lore",
channelPlan,
channelSnapshots: [{ channelId: "aquarium", messages: [{
id: "duplicate-image",
authorId: "human-2",
authorName: "Neighbor",
content: "same image nearby",
timestamp: "2026-07-15T21:09:00.000Z",
isBot: false,
channelId: "aquarium",
attachments: [{ kind: "image", filename: "same.png", contentType: "image/png", localPath: "C:/cache/same.png" }],
}] }],
recentMessages: Array.from({ length: 9 }, (_, index) => ({
id: `image-${index}`,
authorId: "human",
authorName: "Operator",
content: `image evidence ${index}`,
timestamp: `2026-07-15T21:${String(index).padStart(2, "0")}:00.000Z`,
isBot: false,
channelId: "lore",
attachments: [{ kind: "image" as const, filename: `${index}.png`, contentType: "image/png", localPath: index === 0 ? "C:/cache/same.png" : `C:/cache/${index}.png` }],
})),
participant: promptParticipant,
pendingMentions: [],
conversationMemorySurface: "Inspection supplied conversation authority.",
githubActionsEnabled: false,
globalAgentDoctrine: "Global doctrine.",
});
assert.match(assembledTurn.prompt, /Inspection supplied conversation authority\./, "queued and inspection paths share one assembler with an explicit conversation override");
assert.doesNotMatch(assembledTurn.prompt, /Visible cross-channel chronology/, "the assembler does not let its derived transcript override an explicit inspection surface");
assert.equal(assembledTurn.imageAttachments.length, 8, "the assembler owns the bounded image evidence budget");
assert.equal(assembledTurn.imageAttachments.filter((attachment) => attachment.localPath === "C:/cache/same.png").length, 1, "the assembler deduplicates image evidence across room and nearby snapshots");
assert.equal(assembledTurn.conversation.focus?.channelId, "aquarium", "the assembler returns the same newest-evidence conversation projection supplied to the turn actuator");
assert.equal(personaChannelSpeedMultiplier(routedIdentity), 3, "scheduler speed projection uses the routing organ's bounded channel policy");
assert.equal(newestPendingMentionChannel([
{ identityId: "nibu", channelId: "older", queuedAt: "2026-07-15T20:00:00.000Z" },