GameCult/Thing
Watch
9
0
Fork
You've already forked Thing
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enforce optional nested plugin requirements

Browse source
This commit is contained in:
Meta Vens 2026-07-09 17:42:50 +01:00
commit b03ddc1083
5 changed files with 73 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tools/parity/run-parity.mjs
View file

@ -971,6 +971,7 @@ function validateProviderPluginRequirements(provider, requirements, pluginResult
const errors = [];
const pluginById = new Map((pluginResults || []).map(plugin => [plugin.pluginId, plugin]));
for (const requirement of requirements) {
errors.push(...validateProviderPluginRequirementShape(provider, requirement));
const plugin = pluginById.get(requirement.pluginId);
const optional = requirement.availability && requirement.availability !== "required";
if (!plugin) {
@ -991,6 +992,28 @@ function validateProviderPluginRequirements(provider, requirements, pluginResult
return errors;
}
function validateProviderPluginRequirementShape(provider, requirement) {
const label = `${provider.advertisementPath}:${requirement.surfaceId}:plugin:${requirement.pluginId || "unknown"}`;
const errors = [];
const availability = requirement.availability || "required";
if (!requirement.pluginId) errors.push(`${label}:pluginId:missing`);
if (availability === "required" && !requirement.requiredCapabilities.length) {
errors.push(`${label}:requiredCapabilities:missing`);
}
if (availability === "optional-nested") {
if (requirement.requiredCapabilities.length) {
errors.push(`${label}:optional-nested:requiredCapabilities:must-be-empty`);
}
if (!requirement.optionalCapabilities.length) {
errors.push(`${label}:optional-nested:optionalCapabilities:missing`);
}
}
return errors;
}
async function readJsonDocument(documentPath) {
return JSON.parse(await readFile(path.join(repoRoot, documentPath), "utf8"));
}