settings: no window at import (fixes soundscape test on dev) #37

Merged

void merged 1 commit from void/settings-without-window into dev 2026-11-09 10:59:10 +00:00

Conversation 0 Commits 1 Files changed 1 +3 -1

void commented 2026-11-09 10:59:10 +00:00

Member

Copy link

dev failed soundscape.test.ts > ships off, muted with ReferenceError: window is not defined (settings.ts:76, from the composer-spellcheck merge). One guard; 244/244 pass.

🤖 Generated with Claude Code

dev failed `soundscape.test.ts > ships off, muted` with `ReferenceError: window is not defined` (settings.ts:76, from the composer-spellcheck merge). One guard; 244/244 pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

void added 1 commit 2026-11-09 10:59:10 +00:00

settings: do not read window at import when there is none ... c7d6c388d3

dev's settings default reads window.matchMedia at module load (composer-spellcheck merge);
soundscape.test.ts imports settings in a node environment, so "ships off, muted" threw
ReferenceError on dev itself. No window means no coarse-pointer query.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

void merged commit 82dc0d0a9b into dev 2026-11-09 10:59:10 +00:00

void referenced this pull request from a commit 2026-11-09 10:59:11 +00:00

Merge pull request 'settings: no window at import (fixes soundscape test on dev)' (#37) from void/settings-without-window into dev

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

GameCult/Ratatoskr!37

No description provided.