GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Phone hit: repo-wide guard for bare IconButtons, PhoneHitInPlace for preview arrows, drop dead Editor.preview #141

Merged
void merged 1 commit from void/phone-hit-guard into dev 2026-11-13 13:51:43 +00:00
Conversation 0 Commits 1 Files changed 6 +80 -90
void commented 2026-11-13 13:46:51 +00:00
Member
Copy link

Closes the audit buildout (follow_up phone-hit-audit-buildout a, b, c).

  • phoneHit.coverage.test.ts: every IconButton under src/app has a PhoneHit class or is named with its reason (EstateNavigator Find a room, LobbyHeader Members). Mutation: stripping a class from call/Controls.tsx fails it.
  • PhoneHitInPlace: hit area only, no position: relative; UrlPreviewCard's two absolute arrows carry it (pinned by consumer-side expectPhoneHitClasses).
  • Deleted components/editor/Editor.preview.tsx (imported nowhere, 11 bare IconButtons).

Not rendered on a phone: the arrows sit at the edge of a Scroll, so the outer part of their 44 px area may be clipped.

🤖 Generated with Claude Code

Closes the audit buildout (follow_up phone-hit-audit-buildout a, b, c). - `phoneHit.coverage.test.ts`: every IconButton under src/app has a PhoneHit class or is named with its reason (EstateNavigator Find a room, LobbyHeader Members). Mutation: stripping a class from call/Controls.tsx fails it. - `PhoneHitInPlace`: hit area only, no `position: relative`; UrlPreviewCard's two absolute arrows carry it (pinned by consumer-side `expectPhoneHitClasses`). - Deleted `components/editor/Editor.preview.tsx` (imported nowhere, 11 bare IconButtons). Not rendered on a phone: the arrows sit at the edge of a Scroll, so the outer part of their 44 px area may be clipped. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Phone hit: a repo-wide guard for bare IconButtons, PhoneHitInPlace for the preview arrows, drop the dead Editor.preview
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 3m22s
Details
d5a0c1b4ff 
phoneHit.coverage.test.ts walks every .tsx under src/app and fails on any IconButton without a PhoneHit class
unless it is named with its reason (EstateNavigator Find a room, LobbyHeader Members). UrlPreviewCard's two
absolute arrows take PhoneHitInPlace, which adds the hit area without PhoneHit's position: relative.
Editor.preview.tsx was imported nowhere and held 11 bare IconButtons.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
void merged commit 8ba407cd2a into dev 2026-11-13 13:51:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!141
No description provided.