GameCult/Ratatoskr
Watch
9
0
Fork
You've already forked Ratatoskr
 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Phone hit: room/space settings, lobby, message search, explore (group 7) #137

Merged
void merged 2 commits from void/phone-hit-room-space into dev 2026-11-13 12:58:50 +00:00
Conversation 0 Commits 2 Files changed 11 +53 -7
void commented 2026-11-13 07:16:32 +00:00
Member
Copy link

Group 7 of the IconButton phone-hit audit. Each button gets a 44 px phone hit area through the foundation variants; nothing drawn changes on desktop, and phone-only margin grows only for the Spread variant.

Changed

File Button Variant Why
room-settings/RoomSettings.tsx close (mobile only) PhoneHit 40 px, alone at header end
room-settings/general/General.tsx close PhoneHit 40 px, alone
room-settings/permissions/Permissions.tsx close PhoneHit 40 px, alone
space-settings/SpaceSettings.tsx close (mobile only) PhoneHit as room
space-settings/general/General.tsx close PhoneHit as room
space-settings/permissions/Permissions.tsx close PhoneHit as room
lobby/HierarchyItemMenu.tsx options (vertical dots) PhoneHitSpread24 16 px icon + 8 padding = 24 px; beside tappable chips (Open Room 12 px away in a room card, Add Room/Add Space 8 px away in a space card), so the row opens 10 px each side. Audit proposed PhoneHit; with the 8 px gap a plain 44 px area would overlap the Add chip by 2 px
lobby/Lobby.tsx scroll to top PhoneHit 30 px, floating, alone, 8 px below the scroller top (7 px overhang fits)
message-search/MessageSearch.tsx scroll to top PhoneHit same, shared ScrollTopContainer
pages/client/explore/Explore.tsx Add Server dialog close PhoneHit 32 px (24 icon + 8), alone; Header has 8 px right padding, overhang 6 px

No vertical stacks in this group. Test: src/app/phoneHit.roomSpace.test.ts pins the variant per file and ties the Spread size to the drawn size; no allow-list entries.

Skipped

None in these files. (LobbyHeader.tsx is not in this group.)

Mutation check

HierarchyItemMenu Spread24 -> Spread32: dies. Spread24 -> PhoneHit: dies. Lobby PhoneHit -> Spread24: dies (class test and size tie). Explore className removed: dies. Restored; 20/20 pass.

Not measured on a real phone

No device or browser run: hit-area overlap with the chips in hierarchy cards, and the 7/6 px overhangs against the scroller and dialog edges, are derived from source and CSS only.

🤖 Generated with Claude Code

Group 7 of the IconButton phone-hit audit. Each button gets a 44 px phone hit area through the foundation variants; nothing drawn changes on desktop, and phone-only margin grows only for the Spread variant. ## Changed | File | Button | Variant | Why | |---|---|---|---| | room-settings/RoomSettings.tsx | close (mobile only) | PhoneHit | 40 px, alone at header end | | room-settings/general/General.tsx | close | PhoneHit | 40 px, alone | | room-settings/permissions/Permissions.tsx | close | PhoneHit | 40 px, alone | | space-settings/SpaceSettings.tsx | close (mobile only) | PhoneHit | as room | | space-settings/general/General.tsx | close | PhoneHit | as room | | space-settings/permissions/Permissions.tsx | close | PhoneHit | as room | | lobby/HierarchyItemMenu.tsx | options (vertical dots) | PhoneHitSpread24 | 16 px icon + 8 padding = 24 px; beside tappable chips (Open Room 12 px away in a room card, Add Room/Add Space 8 px away in a space card), so the row opens 10 px each side. Audit proposed PhoneHit; with the 8 px gap a plain 44 px area would overlap the Add chip by 2 px | | lobby/Lobby.tsx | scroll to top | PhoneHit | 30 px, floating, alone, 8 px below the scroller top (7 px overhang fits) | | message-search/MessageSearch.tsx | scroll to top | PhoneHit | same, shared ScrollTopContainer | | pages/client/explore/Explore.tsx | Add Server dialog close | PhoneHit | 32 px (24 icon + 8), alone; Header has 8 px right padding, overhang 6 px | No vertical stacks in this group. Test: src/app/phoneHit.roomSpace.test.ts pins the variant per file and ties the Spread size to the drawn size; no allow-list entries. ## Skipped None in these files. (LobbyHeader.tsx is not in this group.) ## Mutation check HierarchyItemMenu Spread24 -> Spread32: dies. Spread24 -> PhoneHit: dies. Lobby PhoneHit -> Spread24: dies (class test and size tie). Explore className removed: dies. Restored; 20/20 pass. ## Not measured on a real phone No device or browser run: hit-area overlap with the chips in hierarchy cards, and the 7/6 px overhangs against the scroller and dialog edges, are derived from source and CSS only. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Phone hit: room/space settings, lobby, message search, explore icon buttons
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 4m25s
Details
84ee800e3f 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge branch 'dev' into void/phone-hit-room-space
All checks were successful
Build pull request / Build pull request (pull_request) Successful in 3m14s
Details
91993ace99
void merged commit f0c8dc2122 into dev 2026-11-13 12:58:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
GameCult/Ratatoskr!137
No description provided.