Phone hit: page back buttons (group 3) #133

Merged

void merged 3 commits from void/phone-hit-pages into dev 2026-11-13 13:43:43 +00:00

Conversation 0 Commits 3 Files changed 11 +51 -10

void commented 2026-11-13 07:16:03 +00:00

Member

Copy link

Adds the PhoneHit variant (44 px phone hit area, nothing drawn changes) to the IconButtons of group 3 of the audit.

Changed (all plain PhoneHit: alone in their row, vertical stacks have no variant)

• Back buttons, 40 px drawn (default IconButton + default Icon), alone in a shrink=No box at the header start: LobbyHeader, JoinBeforeNavigate, space/Search, explore/Server, explore/Featured, home/CreateRoom, home/Search, inbox/Notifications, inbox/Invites, direct/DirectCreate.
• LobbyHeader More Options (40 px): on a phone it is the only button at the header end (Members is hidden on Mobile), so PhoneHit not a Spread.
• Notifications scroll-to-top pill (30 px: size 300 + Icon 300): floats alone at top centre of a relative box, 8 px below the top, so the 44 px area stays inside; PhoneHit.

Skipped

• LobbyHeader Members button: rendered only when screenSize !== Mobile.
• explore/Explore.tsx is in the audit's group 7, not here.

Test: src/app/phoneHit.pages.test.ts pins each button's variant per file in source order plus expectSizeTie (no allow-list needed). Mutants (all killed): Invites PhoneHit->PhoneHitSpread40; LobbyHeader back button className removed; home/Search className removed; Notifications import renamed to a non-exported name. Kit fix: expectPhoneHitClasses now accepts null entries (a deliberately variant-less button) and skips them in the import check; previously a null made the import check demand null.

Unmeasured on a real phone: whether the 44 px areas overlap the header title or the neighbouring balance box in practice, and the scroll-to-top pill against the on-screen keyboard/safe areas.

🤖 Generated with Claude Code

Adds the PhoneHit variant (44 px phone hit area, nothing drawn changes) to the IconButtons of group 3 of the audit. **Changed (all plain `PhoneHit`: alone in their row, vertical stacks have no variant)** - Back buttons, 40 px drawn (default IconButton + default Icon), alone in a `shrink=No` box at the header start: LobbyHeader, JoinBeforeNavigate, space/Search, explore/Server, explore/Featured, home/CreateRoom, home/Search, inbox/Notifications, inbox/Invites, direct/DirectCreate. - LobbyHeader More Options (40 px): on a phone it is the only button at the header end (Members is hidden on Mobile), so PhoneHit not a Spread. - Notifications scroll-to-top pill (30 px: size 300 + Icon 300): floats alone at top centre of a relative box, 8 px below the top, so the 44 px area stays inside; PhoneHit. **Skipped** - LobbyHeader Members button: rendered only when screenSize !== Mobile. - explore/Explore.tsx is in the audit's group 7, not here. **Test**: src/app/phoneHit.pages.test.ts pins each button's variant per file in source order plus expectSizeTie (no allow-list needed). Mutants (all killed): Invites PhoneHit->PhoneHitSpread40; LobbyHeader back button className removed; home/Search className removed; Notifications import renamed to a non-exported name. Kit fix: `expectPhoneHitClasses` now accepts `null` entries (a deliberately variant-less button) and skips them in the import check; previously a null made the import check demand `null`. **Unmeasured on a real phone**: whether the 44 px areas overlap the header title or the neighbouring balance box in practice, and the scroll-to-top pill against the on-screen keyboard/safe areas. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

void added 1 commit 2026-11-13 07:16:03 +00:00

Phone hit: page back buttons and Lobby/Notifications lone buttons ... cd90a044ed

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

void added 1 commit 2026-11-13 10:15:50 +00:00

Merge dev into phone-hit-pages (kit: dev's AST reader already accepts null entries) ... ff1a29dbec

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

void added 1 commit 2026-11-13 13:34:35 +00:00

Merge branch 'dev' into void/phone-hit-pages 4e6b4f0c90

void merged commit ad9172a311 into dev 2026-11-13 13:43:43 +00:00

void referenced this pull request from a commit 2026-11-13 13:43:46 +00:00

Merge pull request 'Phone hit: page back buttons (group 3)' (#133) from void/phone-hit-pages into dev

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

GameCult/Ratatoskr!133

No description provided.