GameCult/Odin
Watch
9
0
Fork
You've already forked Odin
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Odin: drop doc lines that restate the code they sit on

Browse source 
One was also wrong: `records` is in key order, not the file's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-30 15:32:41 +02:00
commit f4a1f8900a
2 changed files with 3 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/odin-daemon/src/lib.rs
View file

@ -425,8 +425,6 @@ pub struct OdinStoreSnapshot {
pub trait OdinTopologyStore {
fn read(&self, query: OdinStoreQuery) -> Result<OdinStoreSnapshot>;
/// Replace the queried incarnation's correlation, and its presence when
/// one is given.
fn commit(
&self,
query: &OdinStoreQuery,
@ -526,7 +524,6 @@ impl MemoryOdinTopologyStore {
})
}
/// Every record, in the order the file stores them.
pub fn records(&self) -> Ref<'_, BTreeMap<RecordId, CultCacheEnvelope>> {
self.records.borrow()
}
@ -553,7 +550,6 @@ impl MemoryOdinTopologyStore {
}
}
/// Every incarnation this store holds a correlation for.
pub fn correlated_incarnations(&self) -> BTreeSet<IncarnationRef> {
self.records
.borrow()
@ -584,7 +580,6 @@ impl MemoryOdinTopologyStore {
legacy.len()
}
/// Whether the records differ from what was last loaded or written.
pub fn is_dirty(&self) -> bool {
self.dirty.get()
}

8
crates/odin-daemon/src/main.rs
View file

@ -809,11 +809,9 @@ fn serve(
ended
}
/// The last write before Odin ends. `flush` makes it only while the lease is
/// still current and the file still holds what Odin wrote, so it writes
/// nothing after `WriteLeaseLost` or `ForeignStoreWrite`. A failure is logged
/// and not returned: Odin is ending either way, and the next Odin loads what
/// the file holds.
/// The last write before Odin ends, under `flush`'s own checks: after
/// `WriteLeaseLost` or `ForeignStoreWrite` it writes nothing. A failure is
/// logged, not returned: Odin is ending either way.
fn stop(state: &RuntimeState) {
if let Err(error) = state.flush() {
eprintln!("Odin's final store write was not made: {error:#}");