GameCult/Idunn
Watch
9
0
Fork
You've already forked Idunn
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cut c2b fix: a drain whose stored plan no longer parses is bounded, not unbounded

Browse source 
deadline_for_current_activity's drain arm returned None when parsed_inputs
failed (the running binary re-parses and re-admits the frozen binding), which
left the drain with no deadline, unpaged, and disarmed every waiter behind it.
The retire time is now the promotion plus the drain when the binding parses,
and otherwise now; the frozen committing duration from it bounds the drain.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-19 17:48:03 +02:00
commit 21849eb097
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/control_plane.rs
View file

@ -1775,17 +1775,20 @@ impl DeploymentTransaction {
return None;
}
let plan = self.plan.as_ref()?;
let from = match self
// The retire time needs the binding's drain, which the running
// binary re-parses and re-admits: a plan frozen by an older binary
// may not parse now. That must not leave a drain with no deadline,
// so a retire time that cannot be derived is now, and the
// committing duration from it bounds the drain.
let from = self
.routing
.as_ref()
.and_then(RoutingEvidence::promoted_at_unix_millis)
{
Some(promoted_at) => {
route_drain_deadline(promoted_at, plan.parsed_inputs().ok()?.1.rollout.drain_seconds)
.ok()?
}
None => now,
};
.and_then(|promoted_at| {
let (_, binding) = plan.parsed_inputs().ok()?;
route_drain_deadline(promoted_at, binding.rollout.drain_seconds).ok()
})
.unwrap_or(now);
return Some(PhaseDeadline {
phase: self.phase,
entered_at_unix_millis: now,