From da90d7e74e156773eb69382290060efa1021bd48 Mon Sep 17 00:00:00 2001 From: Eureka Date: Wed, 11 Nov 2026 17:35:49 +0000 Subject: [PATCH] Desk feed door: account ids are lowercase D-format UUIDs; fixtures and a test pin it subject, deciders and answerer are Bifrost UserAccount ids (lowercase D-format, as Bifrost's validator requires and as Huginn names RequestId). The fixtures used "7"/"12"; they now carry synthetic UUIDs, and a test pins the grammar and refuses Matrix ids, emails and handles. The doc states that Huginn's door does not refuse other shapes yet (owed by cut-desk-feed-listing.r4) and that card.deciders echoes the ids. Co-Authored-By: Claude Sonnet 5.5 --- .../huginn-mind/tests/desk_feed_fixtures.rs | 44 ++++++++++++++++-- .../desk-feed/list-counts.request.frame.bin | Bin 278 -> 422 bytes .../desk-feed/list-counts.request.frame.hex | 2 +- .../desk-feed/list-counts.request.payload.hex | 2 +- .../list-counts.request.payload.msgpack | Bin 72 -> 179 bytes .../list-open-cursor.request.frame.bin | Bin 282 -> 426 bytes .../list-open-cursor.request.frame.hex | 2 +- .../list-open-cursor.request.payload.hex | 2 +- .../list-open-cursor.request.payload.msgpack | 2 +- .../desk-feed/list-open.request.frame.bin | Bin 278 -> 422 bytes .../desk-feed/list-open.request.frame.hex | 2 +- .../desk-feed/list-open.request.payload.hex | 2 +- .../list-open.request.payload.msgpack | 2 +- .../fixtures/desk-feed/read.request.frame.bin | Bin 317 -> 462 bytes .../fixtures/desk-feed/read.request.frame.hex | 2 +- .../desk-feed/read.request.payload.hex | 2 +- .../desk-feed/read.request.payload.msgpack | 2 +- .../desk-feed/record-whole.payload.hex | 2 +- .../desk-feed/record-whole.payload.msgpack | Bin 1071 -> 1142 bytes docs/desk-feed-door.md | 16 +++++++ 20 files changed, 67 insertions(+), 17 deletions(-) diff --git a/crates/huginn-mind/tests/desk_feed_fixtures.rs b/crates/huginn-mind/tests/desk_feed_fixtures.rs index 9c6b64a..fc74f4f 100644 --- a/crates/huginn-mind/tests/desk_feed_fixtures.rs +++ b/crates/huginn-mind/tests/desk_feed_fixtures.rs @@ -21,6 +21,11 @@ use huginn_mind::envelope::{OperationFailure, encode_desk_failure, encode_desk_r use huginn_mind::eureka_pipeline::{DeskAuthority, Short, Slug}; const RUNTIME: &str = "huginn-eureka"; +/// Account ids as Bifrost sends them: `UserAccount.Id` rendered lowercase D-format +/// (`DeskEndpoints.cs` `accountId.Value.ToString("D")`; `StartupConfigurationValidator` refuses any +/// other decider). Synthetic values. +const READER: &str = "5f0c2b1e-8a4d-4c3b-9e7f-1a2b3c4d5e6f"; +const OTHER_DECIDER: &str = "0b9d7e3a-6c21-4f58-a0d4-9e8f7a6b5c4d"; /// A question Eureka's mind holds (asked 2026-11-11). The answers, notes and hash in `record()` are /// synthetic: the hash is CultLib's sample digest, not this question's. const FORK: &str = "eureka-substrate:question:desk-listing-authority"; @@ -32,8 +37,8 @@ fn s(text: &str) -> Short { fn forks(status: Option, cursor: Option, limit: u8) -> DeskRequest { DeskRequest::Forks { mind: Slug("eureka".into()), - subject: s("7"), - deciders: vec![s("7"), s("12")], + subject: s(READER), + deciders: vec![s(READER), s(OTHER_DECIDER)], status, cursor: cursor.and_then(ForkCursor::new), limit: ForkLimit::new(limit).unwrap(), @@ -41,7 +46,7 @@ fn forks(status: Option, cursor: Option, limit: u8) -> DeskRequ } fn read() -> DeskRequest { - DeskRequest::Fork { mind: Slug("eureka".into()), subject: s("7"), deciders: vec![s("7"), s("12")], fork_id: FORK.into() } + DeskRequest::Fork { mind: Slug("eureka".into()), subject: s(READER), deciders: vec![s(READER), s(OTHER_DECIDER)], fork_id: FORK.into() } } fn list(open_count: u64, recorded_count: u64) -> DeskResponse { @@ -93,8 +98,8 @@ fn record() -> ForkRecord { options_hash: "7d95fc87d532420611fe415c1def27a3447617bb68235f46e3af130aea361c48".into(), counted_answer_id: Some("n1".into()), answers: vec![ - answer("n1", "Counted", None, "7", "The asker lists her own forks.", "2026-11-11T17:00:00Z"), - answer("n2", "Revision", Some("n1"), "12", "Agreed.", "2026-11-11T17:05:00Z"), + answer("n1", "Counted", None, READER, "The asker lists her own forks.", "2026-11-11T17:00:00Z"), + answer("n2", "Revision", Some("n1"), OTHER_DECIDER, "Agreed.", "2026-11-11T17:05:00Z"), ], } } @@ -190,3 +195,32 @@ fn desk_feed_fixtures_are_what_the_encoders_write() { } } } + +/// The one grammar for `subject`, every `deciders` entry and every `answerer`: a lowercase +/// D-format UUID (8-4-4-4-12 lowercase hex), the grammar Huginn already names for `RequestId` +/// (`eureka-pipeline` `uuid_text`). A Matrix id, an email or a handle never fits it. +fn account_id(text: &str) -> bool { + text.len() == 36 + && text.bytes().enumerate().all(|(at, byte)| match at { + 8 | 13 | 18 | 23 => byte == b'-', + _ => matches!(byte, b'0'..=b'9' | b'a'..=b'f'), + }) +} + +/// Every account id the fixtures carry is a Bifrost account id, never a Matrix id, email or +/// handle. The door does not refuse other shapes yet (`Short`, any 200 bytes); that refusal is owed +/// by `cut-desk-feed-listing.r4`, and this pins the grammar it must enforce. +#[test] +fn every_account_id_in_the_fixtures_is_a_lowercase_d_format_uuid() { + for request in [forks(Some(ListStatus::Open), None, 50), read()] { + let subject = match &request { + DeskRequest::Forks { subject, .. } | DeskRequest::Fork { subject, .. } | DeskRequest::Answer { subject, .. } => subject, + }; + assert!(account_id(&subject.0), "subject"); + assert!(request.deciders().iter().all(|decider| account_id(&decider.0)), "deciders"); + } + assert!(record().answers.iter().all(|answer| account_id(&answer.answerer)), "answerer"); + for shape in ["@heimdall:gamecult.org", "meta@gamecult.org", "heimdall", "7", "5F0C2B1E-8A4D-4C3B-9E7F-1A2B3C4D5E6F", "{5f0c2b1e-8a4d-4c3b-9e7f-1a2b3c4d5e6f}", ""] { + assert!(!account_id(shape), "{shape} is not an account id"); + } +} diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.frame.bin b/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.frame.bin index b5c855dcea675190691239996c47ab8ca6542722..87fae5add38ff5ea47e85766ef0aa333fe1f2913 100644 GIT binary patch delta 225 zcmbQnw2YaBfq`++L>3Lk4-<7&>;1B`{lX*5BdfeJeZxab{M}s*qMQv3BCGr|eL`|_ z{EQ+?e8XKUBeVRn{M-W#qe7x`3*CcqB8_sgqawVjvP($UZxkF@9+{Ps?PnBPY2BlX&Yk?UvVY806j2DCUhH`zESBgG@Es=(c{JSyBQ cH_|w)GTF$ovfMkYI5FI?AjQ$qc4BWQ0Q9a)=>Px# delta 81 zcmZ3+JdKHkfq_wIB8vuN!bDwFYj0QMLieDYNTZzWs0gpB>_S)L{4CeXf;>Ni$cP}r kWV4{MWcRSrf?Pkt#E3x0$+C={0K5VjdjJ3c diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.frame.hex b/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.frame.hex index d0554ad..f11745c 100644 --- a/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.frame.hex +++ b/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.frame.hex @@ -1 +1 @@ -0000011287a96d6573736167654964a36d2d33a96f7065726174696f6ea5666f726b73a77061796c6f6164d9606761564762334a726334616b62576c755a4b5a6c64584a6c6132476e63335669616d566a644b45337147526c59326c6b5a584a7a6b7145336f6a4579706e4e30595852316336527663475675706d4e31636e4e766373436c62476c7461585141af7061796c6f6164456e636f64696e67b26d6573736167657061636b2d626173653634ad7061796c6f6164536368656d61b6687567696e6e2e6465736b5f726571756573742e7631ad736368656d6156657273696f6ebc63756c746e65742e6f7065726174696f6e5f726571756573742e7630a9736572766963654964ab687567696e6e2e6465736b +000001a287a96d6573736167654964a36d2d33a96f7065726174696f6ea5666f726b73a77061796c6f6164d9f06761564762334a726334616b62576c755a4b5a6c64584a6c6132476e63335669616d566a644e6b6b4e575977597a4a694d5755744f4745305a433030597a4e694c546c6c4e3259744d574579596a4e6a4e4751315a545a6d7147526c59326c6b5a584a7a6b746b6b4e575977597a4a694d5755744f4745305a433030597a4e694c546c6c4e3259744d574579596a4e6a4e4751315a545a6d32535177596a6c6b4e32557a59533032597a49784c54526d4e5467745954426b4e4330355a54686d4e324532596a566a4e47536d633352686448567a704739775a57366d5933567963323979774b5673615731706441413daf7061796c6f6164456e636f64696e67b26d6573736167657061636b2d626173653634ad7061796c6f6164536368656d61b6687567696e6e2e6465736b5f726571756573742e7631ad736368656d6156657273696f6ebc63756c746e65742e6f7065726174696f6e5f726571756573742e7630a9736572766963654964ab687567696e6e2e6465736b diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.payload.hex b/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.payload.hex index 60cb15a..804b47e 100644 --- a/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.payload.hex +++ b/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.payload.hex @@ -1 +1 @@ -81a5466f726b7386a46d696e64a6657572656b61a77375626a656374a137a8646563696465727392a137a23132a6737461747573a46f70656ea6637572736f72c0a56c696d697400 +81a5466f726b7386a46d696e64a6657572656b61a77375626a656374d92435663063326231652d386134642d346333622d396537662d316132623363346435653666a8646563696465727392d92435663063326231652d386134642d346333622d396537662d316132623363346435653666d92430623964376533612d366332312d346635382d613064342d396538663761366235633464a6737461747573a46f70656ea6637572736f72c0a56c696d697400 diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.payload.msgpack b/crates/huginn-mind/tests/fixtures/desk-feed/list-counts.request.payload.msgpack index 931ad8d5551e6dfba06304c62e3f992180624569..d79df5f0eb938b431b98771da27ce0eb714928da 100644 GIT binary patch literal 179 zcma*f%MpSw5CBk%;kq*c5c)Nej&v85%7sE=epYEnbpekeatFxwNP_zv#fyoXp(J G5(WSg=M`@N diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-open-cursor.request.frame.bin b/crates/huginn-mind/tests/fixtures/desk-feed/list-open-cursor.request.frame.bin index 55963c3bdf9dcd8269226338428bd4bbb6aedb39..f2479d544ad0275f44632f9291a560f0725df468 100644 GIT binary patch delta 229 zcmb8oO%B086ae7*xr)R_GM1qb-@ zJ?rmA({XCAs@bl6s!r>UN}-^F?Ccndb-oCECOyW;;&INkMxZ~V2_S)L{4CeXf;>Ni$cP}r oWV4{MWcRSrf?Pkt#E8Jk$%>4f04v=a8vp3Lk4-<7&>;1B`{lX*5BdfeJeZxab{M}s*qMQv3BCGr|eL`|_ z{EQ+?e8XKUBeVRn{M-W#qe7x`3*CcqB8_sgqawVjvP($UZxkF@9+{Ps?PnBPY2BlX&Yk?UvVY806j2DCUhH`zESBgG@Es=(c{JSyBQ cH_|w)GTF$ovfMkYI5FI?AjQSgc4BWQ0QBff^Z)<= delta 81 zcmZ3+JdKHkfq_wIB8vuN!bDwFYj0QMLieDYNTZzWs0gpB>_S)L{4CeXf;>Ni$cP}r kWV4{MWcRSrf?Pkt#E8Jk$+C={0KFO+vj6}9 diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.frame.hex b/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.frame.hex index 304b63b..c351ca8 100644 --- a/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.frame.hex +++ b/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.frame.hex @@ -1 +1 @@ -0000011287a96d6573736167654964a36d2d31a96f7065726174696f6ea5666f726b73a77061796c6f6164d9606761564762334a726334616b62576c755a4b5a6c64584a6c6132476e63335669616d566a644b45337147526c59326c6b5a584a7a6b7145336f6a4579706e4e30595852316336527663475675706d4e31636e4e766373436c62476c7461585179af7061796c6f6164456e636f64696e67b26d6573736167657061636b2d626173653634ad7061796c6f6164536368656d61b6687567696e6e2e6465736b5f726571756573742e7631ad736368656d6156657273696f6ebc63756c746e65742e6f7065726174696f6e5f726571756573742e7630a9736572766963654964ab687567696e6e2e6465736b +000001a287a96d6573736167654964a36d2d31a96f7065726174696f6ea5666f726b73a77061796c6f6164d9f06761564762334a726334616b62576c755a4b5a6c64584a6c6132476e63335669616d566a644e6b6b4e575977597a4a694d5755744f4745305a433030597a4e694c546c6c4e3259744d574579596a4e6a4e4751315a545a6d7147526c59326c6b5a584a7a6b746b6b4e575977597a4a694d5755744f4745305a433030597a4e694c546c6c4e3259744d574579596a4e6a4e4751315a545a6d32535177596a6c6b4e32557a59533032597a49784c54526d4e5467745954426b4e4330355a54686d4e324532596a566a4e47536d633352686448567a704739775a57366d5933567963323979774b5673615731706444493daf7061796c6f6164456e636f64696e67b26d6573736167657061636b2d626173653634ad7061796c6f6164536368656d61b6687567696e6e2e6465736b5f726571756573742e7631ad736368656d6156657273696f6ebc63756c746e65742e6f7065726174696f6e5f726571756573742e7630a9736572766963654964ab687567696e6e2e6465736b diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.hex b/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.hex index e8564d6..2006332 100644 --- a/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.hex +++ b/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.hex @@ -1 +1 @@ -81a5466f726b7386a46d696e64a6657572656b61a77375626a656374a137a8646563696465727392a137a23132a6737461747573a46f70656ea6637572736f72c0a56c696d697432 +81a5466f726b7386a46d696e64a6657572656b61a77375626a656374d92435663063326231652d386134642d346333622d396537662d316132623363346435653666a8646563696465727392d92435663063326231652d386134642d346333622d396537662d316132623363346435653666d92430623964376533612d366332312d346635382d613064342d396538663761366235633464a6737461747573a46f70656ea6637572736f72c0a56c696d697432 diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.msgpack b/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.msgpack index 90f32b7..0b18a68 100644 --- a/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.msgpack +++ b/crates/huginn-mind/tests/fixtures/desk-feed/list-open.request.payload.msgpack @@ -1 +1 @@ -�¥Forks†¤mind¦eureka§subject¡7¨deciders’¡7¢12¦status¤open¦cursorÀ¥limit2 \ No newline at end of file +�¥Forks†¤mind¦eureka§subjectÙ$5f0c2b1e-8a4d-4c3b-9e7f-1a2b3c4d5e6f¨deciders’Ù$5f0c2b1e-8a4d-4c3b-9e7f-1a2b3c4d5e6fÙ$0b9d7e3a-6c21-4f58-a0d4-9e8f7a6b5c4d¦status¤open¦cursorÀ¥limit2 \ No newline at end of file diff --git a/crates/huginn-mind/tests/fixtures/desk-feed/read.request.frame.bin b/crates/huginn-mind/tests/fixtures/desk-feed/read.request.frame.bin index 9b114db76c59855abedb6ebb62de897f6d8a8adb..181317a6cb0e7dda51352ad73cb4d043b449c1a2 100644 GIT binary patch delta 278 zcmb7;%~gXi9Kc)KAsoQhlLtt=c<@4tu}H`xL?F2Za)9s$`joy`yf6ckIDrn}!2z5` zR&apd$LH10X1iLgzvu04^Si#DZ*L})#ICZQrS0*e66a0|-h_f%ijD)zUa+d2ixfdk z5p~odg{alNBB|9Ghq7bI|M@}%2d`#XjFpI{Diq36>kko;F59~mC9x9<07fL1Le){W zgr7}Y;NUe!&>-P~$pg^HA4;6oCFY~dIk4{0Re9v-?EcK!We&X!1%Y=%;H*ZsGCA)T T$H_c34<9EzLa&YA&0o_Wjiy}I delta 150 zcmX@dyqAfEfq~I-B8wW+&5nt>D)spxsrgavVOfdcK{?5J{=qF zL6l#1c~nGLWmI@chEIf_VPu}4L2|B}K~zXVMM`*BRf>B~SyEO(c2tC4kxzIsKfhB@BaUr_ xOjrQLGb}YJSaR$IOQ=!L->^PMFJ1G7my)U{h~g}uh74p1wv;tdL9wYz& delta 25 hcmeyyv7Tdt3lq~q^UYaIOBk6K85&K_Vsd0O0swN#2gLvY diff --git a/docs/desk-feed-door.md b/docs/desk-feed-door.md index 8f233ec..9be005c 100644 --- a/docs/desk-feed-door.md +++ b/docs/desk-feed-door.md @@ -94,6 +94,22 @@ Request (`huginn.desk_request.v1`): Huginn keeps no copy. `subject` is the verified Bifrost account id of the reader. The reads carry no `authority`, and a payload that names it is refused whole. +**Account ids.** `subject`, every `deciders` entry and every stored `answerer` are Bifrost account ids: +`UserAccount.Id` in lowercase D-format, 8-4-4-4-12 lowercase hex (Bifrost renders it in +`DeskEndpoints.cs` with `accountId.Value.ToString("D")`, and `StartupConfigurationValidator.cs` +refuses any decider not in that form). That is the same grammar Huginn names for `RequestId` +(`uuid_text`). These ids are opaque random UUIDs. A Matrix id, an email, a display name or any other +handle is never one of them. Bifrost enforces the grammar; Huginn's door does not yet: it reads these +fields as `Short` (any text up to 200 bytes) and would accept `@x:server` or an email. A subject +is stored as `answerer` on an answer, so a wrong value would enter the mind. Refusing every other +shape at decode is owed by `cut-desk-feed-listing.r4`. The test +`every_account_id_in_the_fixtures_is_a_lowercase_d_format_uuid` pins the grammar. The fixtures use +synthetic UUIDs. + +`card.deciders` echoes the call's decider list on every card to every reader. Bifrost masks +`answerer` for a reader who is not a decider (X3), but it must also mask `card.deciders`, or the +same account ids reach that reader through the card. + Response (`huginn.desk_response.v1`): | variant | meaning | Bifrost answers |