From c2c9ff77e85cf0b564733f3388145e2eb85a3275 Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Tue, 22 Sep 2026 18:57:20 +0200 Subject: [PATCH] Correct open_with's release-binary doc: no Idunn recipe pins the build yet The doc on open_with claimed it never compiles into a release binary. That is only true for `cargo build --release -p huginn-daemon`; the test-support feature is unified in by `--all-targets` and `cargo test`, which do produce a huginn-daemon binary carrying open_with. Checked F:\Projects\gamecult-ops\deployment\idunn-bindings and F:\Projects\gamecult-ops\idunn for a Huginn deploy recipe: none exists yet, so nothing currently pins which command ships. State the actual condition instead of a release-only guarantee no recipe backs. Co-Authored-By: Claude Sonnet 5 --- crates/huginn-mind/src/mind.rs | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/crates/huginn-mind/src/mind.rs b/crates/huginn-mind/src/mind.rs index 93f76dc..cefe4d5 100644 --- a/crates/huginn-mind/src/mind.rs +++ b/crates/huginn-mind/src/mind.rs @@ -145,10 +145,18 @@ impl Mind { /// store already in hand (planted directly, or opened by a test through /// `store_path_for`). Gated exactly like `store_path_for`: it compiles /// only under `cfg(test)` in this crate or for a dependent's own tests - /// via the `test-support` feature, never into a release binary. A second - /// in-process owner of one store is not yet sealed for every `MindStore` - /// impl (F2's recorded follow-up); production reaches this sequence only - /// through `Mind::open`, which takes the per-path redb lock first. + /// via the `test-support` feature. `huginn-daemon` enables that feature + /// only in `[dev-dependencies]`, so a plain `cargo build --release -p + /// huginn-daemon` never pulls it into the shipped binary; but + /// `--all-targets` (and `cargo test`) unifies dev-dependency features + /// across the whole invocation, and that build's `huginn-daemon` binary + /// does carry `open_with`. As of this writing no Idunn deploy recipe for + /// Huginn exists to pin which of those commands is the actual shipped + /// build, so treat this as the open question rather than a settled + /// release-only guarantee. A second in-process owner of one store is not + /// yet sealed for every `MindStore` impl (F2's recorded follow-up); + /// production reaches this sequence only through `Mind::open`, which + /// takes the per-path redb lock first. #[cfg(any(test, feature = "test-support"))] pub fn open_with(store: S, instance: &Slug) -> Result { Self::open_checked(store, instance)