GameCult/Huginn
Watch
9
0
Fork
You've already forked Huginn
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Resolution matrix: a target is superseded only by a target of its own campaign

Browse source 
A lone foreign supersession closed a repo-naming target and narrowed membership to the opening set. Refuses IncompatibleResolution, as the cut_spec supersession rule does. Includes the admission tests (not yet verified).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-10-22 18:16:25 +02:00
commit bb4ef404dc
1 changed files with 42 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

42
crates/huginn-mind/src/admission.rs
View file

@ -804,6 +804,16 @@ fn resolution_rule(docs: &Docs, resolution: &PipelineResolution) -> Result<(), M
}
}
}
ResolutionOutcome::Superseded { by } if subject_kind == K::Target => {
let Some(D::Target(subject)) = docs.find(K::Target, subject_id) else { return Ok(()) };
for supersessor in by {
if let Some(D::Target(target)) = docs.find(K::Target, &supersessor.id.0)
&& target.campaign != subject.campaign
{
return Err(incompatible());
}
}
}
ResolutionOutcome::Answered { by } => {
let Some(D::Ruling(ruling)) = docs.find(K::Ruling, &by.id.0) else { return Ok(()) };
if ruling.answers.as_ref().map(|answers| answers.0.as_str()) != Some(subject_id) {
@ -2789,6 +2799,38 @@ mod tests {
committed(admit(&mut mind, vec![spec_on("1", OTHER_REPO)]));
}
/// Another campaign, opened with `repos`, and its own target revision 1 naming `named`.
fn other_campaign(repos: &[&str], named: &[&str]) -> Vec<D> {
let D::Campaign(mut campaign) = campaign(repos) else { panic!("a campaign") };
campaign.slug = "other-campaign".into();
let D::Target(mut target) = target(1, &[INVARIANT]) else { panic!("a target") };
target.campaign = "other-campaign".into();
target.repos = named.iter().map(|name| repo(name)).collect();
vec![D::Campaign(campaign), D::Target(target)]
}
#[test]
fn another_campaigns_target_does_not_widen_membership() {
let mut mind = seeded();
committed(admit(&mut mind, other_campaign(&[REPO], &[REPO, OTHER_REPO])));
assert_eq!(refusal(admit(&mut mind, vec![spec_on("1", OTHER_REPO)])), MindRefusal::RepoNotInCampaign { repo: OTHER_REPO.into() });
}
#[test]
fn a_target_is_superseded_only_within_its_campaign() {
let mut mind = seeded();
committed(admit(&mut mind, repo_revision(2, &[REPO, OTHER_REPO])));
committed(admit(&mut mind, other_campaign(&[REPO], &[])));
let foreign = r(K::Target, "other-campaign:target:r1");
assert_eq!(
refusal(admit(&mut mind, vec![resolution(r(K::Target, &id("target", "r2")), superseded(&[foreign]))])),
MindRefusal::IncompatibleResolution { subject_kind: K::Target, outcome: "Superseded".into() }
);
// Nothing was written: r2 still names the repos, and its own revision still lands.
committed(admit(&mut mind, vec![spec_on("1", OTHER_REPO)]));
committed(admit(&mut mind, repo_revision(3, &[REPO, OTHER_REPO])));
}
#[test]
fn a_hand_off_derives_this_minds_side_only() {
let key = format!("{INSTANCE}:hand_off:{OTHER_INSTANCE}.gamecult_-epiphany.2026-09-16");