From 821bab62ac80df32ecfd03d3a581640615d5e2ea Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Fri, 9 Oct 2026 22:17:41 +0200 Subject: [PATCH] Clippy at the base: allow large_enum_variant on two huginn-mind enums, drop a let-and-return cargo clippy -D warnings failed at df7507b on PipelineDocument (masking these downstream); the two enums are returned once per commit or request, and admission.rs resolution matrix returned a let binding. Builds. Co-Authored-By: Claude Opus 5.5 --- crates/huginn-mind/src/admission.rs | 5 ++--- crates/huginn-mind/src/receipt.rs | 1 + crates/huginn-mind/src/wire.rs | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/huginn-mind/src/admission.rs b/crates/huginn-mind/src/admission.rs index 5a09f4b..5149f77 100644 --- a/crates/huginn-mind/src/admission.rs +++ b/crates/huginn-mind/src/admission.rs @@ -603,7 +603,7 @@ fn matrix(subject: PipelineKind, outcome: &ResolutionOutcome) -> bool { use PipelineKind as K; use ResolutionOutcome as O; let all = |by: &[PipelineRef], kind: K| by.iter().all(|supersessor| supersessor.kind == kind); - let fits = match (subject, outcome) { + match (subject, outcome) { (K::Target, O::Superseded { by }) => all(by, K::Target), (K::Question, O::Answered { by }) => by.kind == K::Ruling, (K::Question, O::Withdrawn { .. }) => true, @@ -621,8 +621,7 @@ fn matrix(subject: PipelineKind, outcome: &ResolutionOutcome) -> bool { (K::Run, O::Recorded { .. } | O::Withdrawn { .. }) => true, (K::Resolution, O::Withdrawn { .. }) => true, _ => false, - }; - fits + } } /// The resolution row: the sequence, the in-force subject, the matrix, the diff --git a/crates/huginn-mind/src/receipt.rs b/crates/huginn-mind/src/receipt.rs index 37b042a..35705d9 100644 --- a/crates/huginn-mind/src/receipt.rs +++ b/crates/huginn-mind/src/receipt.rs @@ -155,6 +155,7 @@ impl HuginnCommitReceipt { /// How a commit ended. An exact replay is decided by admission before the /// commit is attempted, so it is not an exit of the primitive. #[derive(Clone, Debug, PartialEq, Eq)] +#[allow(clippy::large_enum_variant, reason = "one outcome per commit, returned once and matched at once")] pub(crate) enum CommitOutcome { /// The batch and its receipt landed whole. Committed(HuginnCommitReceipt), diff --git a/crates/huginn-mind/src/wire.rs b/crates/huginn-mind/src/wire.rs index a8df61f..5265c0d 100644 --- a/crates/huginn-mind/src/wire.rs +++ b/crates/huginn-mind/src/wire.rs @@ -102,6 +102,7 @@ impl HuginnMindRequest { /// transport failure: the read side carries `Refused`, the write side carries /// the outcome's own `Refused`. #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize, JsonSchema)] +#[allow(clippy::large_enum_variant, reason = "one answer per request; a document view is the answer a reader asked for")] pub enum HuginnMindResponse { Whoami(MindStatus), Admit(PipelineAdmissionOutcome),