GameCult/Huginn
Watch
9
0
Fork
You've already forked Huginn
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Huginn persona: ack nothing once the session has failed, so a line answered after a batch's third refusal cannot ack past it (Soul s3 ack-passes-batch-after-refusal-bound)

Browse source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-11-01 21:18:19 +01:00
commit 64d6edc0f6
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/mind-body/src/persona.rs
View file

@ -1086,13 +1086,14 @@ impl<C: ControlSource, S: ControlSource> SessionInbox for PersonaInbox<'_, C, S>
match step {
Step::Answered(started) => {
// The one ack rule: through the highest answered seq, never past a delivery still told
// and unanswered (a retold batch, or a line written and not yet echoed). Deliveries are
// and unanswered (a retold batch, or a line written and not yet echoed), and nothing once the session has
// failed (a batch's third refusal leaves no retell to hold the ack back). Deliveries are
// told in seq order, so while one is unanswered below an answered seq, everything
// answered lies above it and nothing is acked; the ack follows its answer.
self.answered_through = self.answered_through.max(batch.iter().map(|delivery| delivery.seq).max().unwrap_or(0));
let unanswered = self.retell.iter().flat_map(|retell| &retell.batch).chain(self.written.iter().flat_map(|written| &written.batch)).map(|delivery| delivery.seq).min();
let past_unanswered = unanswered.is_some_and(|lowest| lowest <= self.answered_through);
if !past_unanswered && self.answered_through > self.progress.acked {
if !past_unanswered && self.progress.failure.is_none() && self.answered_through > self.progress.acked {
if self.organs.chat.ack(self.answered_through).is_err() {
self.progress.failure.get_or_insert(Failure::Ack);
return Ok((false, true));