GameCult/Huginn
Watch
9
0
Fork
You've already forked Huginn
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Desk wire envelope delta: decode refuses an empty decider list (minItems 1)

Browse source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Eureka 2026-11-10 20:44:11 +00:00
commit 14a914a634
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/huginn-mind/src/desk_wire.rs
View file

@ -207,7 +207,7 @@ pub const DESK_MAX_RESPONSE_BYTES: usize = 65536;
/// Most deciders one call carries (CultLib `card.deciders` `maxItems`).
pub const DESK_DECIDERS_MAX: usize = 64;
/// A decider list, read whole or not at all: at most `DESK_DECIDERS_MAX`, no subject twice. A
/// A decider list, read whole or not at all: one to `DESK_DECIDERS_MAX` subjects, none twice. A
/// bad list is the decoder's refusal, which names the field and never quotes a subject.
fn deciders<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<Vec<Short>, D::Error> {
struct List;
@ -227,6 +227,9 @@ fn deciders<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<Vec<Sho
}
list.push(subject);
}
if list.is_empty() {
return Err(serde::de::Error::custom("no deciders"));
}
Ok(list)
}
}
@ -237,6 +240,7 @@ fn deciders_schema(generator: &mut schemars::SchemaGenerator) -> schemars::Schem
schemars::json_schema!({
"type": "array",
"items": generator.subschema_for::<Short>(),
"minItems": 1,
"maxItems": DESK_DECIDERS_MAX,
"uniqueItems": true
})
@ -245,7 +249,7 @@ fn deciders_schema(generator: &mut schemars::SchemaGenerator) -> schemars::Schem
/// Every request the desk door answers. The fields are the wire names: the `mind` addressed
/// (the persona and pipeline requests say `instance`; the sets are separate), the verified
/// `subject` and `authority` Bifrost vouches for (door context, never body fields), and the
/// `deciders` of this call, which the Mind never stores. Closed: a key outside the set refuses
/// `deciders` of this call (1 to 64, distinct; the Mind never stores them). Closed: a key outside the set refuses
/// the whole payload. The reads answer in follow-up desk-wire-reads.
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize, JsonSchema)]
#[serde(deny_unknown_fields)]

5
schemas/cultnet/huginn.desk_request.v1.schema.json
View file

@ -1,7 +1,7 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "DeskRequest",
"description": "Every request the desk door answers. The fields are the wire names: the `mind` addressed\n(the persona and pipeline requests say `instance`; the sets are separate), the verified\n`subject` and `authority` Bifrost vouches for (door context, never body fields), and the\n`deciders` of this call, which the Mind never stores. Closed: a key outside the set refuses\nthe whole payload. The reads answer in follow-up desk-wire-reads.",
"description": "Every request the desk door answers. The fields are the wire names: the `mind` addressed\n(the persona and pipeline requests say `instance`; the sets are separate), the verified\n`subject` and `authority` Bifrost vouches for (door context, never body fields), and the\n`deciders` of this call (1 to 64, distinct; the Mind never stores them). Closed: a key outside the set refuses\nthe whole payload. The reads answer in follow-up desk-wire-reads.",
"oneOf": [
{
"type": "object",
@ -18,6 +18,7 @@
"$ref": "#/$defs/Short"
},
"maxItems": 64,
"minItems": 1,
"uniqueItems": true
},
"mind": {
@ -57,6 +58,7 @@
"$ref": "#/$defs/Short"
},
"maxItems": 64,
"minItems": 1,
"uniqueItems": true
},
"mind": {
@ -91,6 +93,7 @@
"$ref": "#/$defs/Short"
},
"maxItems": 64,
"minItems": 1,
"uniqueItems": true
},
"fork_id": {