From ca53defc90f42b8374bfa3048be69ccffd731ccc Mon Sep 17 00:00:00 2001 From: Heimdall Date: Sat, 14 Nov 2026 01:01:37 +0000 Subject: [PATCH] Identity moves: POST /v1/apps/{app}/identity-moves, consumer-side tests and live-PG races The route verifies proofs (resolveBearer, proofTier, proofCovers), maps the store's refusals to fixed codes, and writes the revocation receipts and audit. Tests drive it over HTTP; the store contract runs on memory and live Postgres; opposite concurrent moves over two pools never deadlock. Co-Authored-By: Claude Sonnet 5.5 --- src/app.ts | 217 ++++++++++++++ tests/identity-moves.test.ts | 541 +++++++++++++++++++++++++++++++++++ tests/store.test.ts | 187 +++++++++++- 3 files changed, 943 insertions(+), 2 deletions(-) create mode 100644 tests/identity-moves.test.ts diff --git a/src/app.ts b/src/app.ts index 29fdf19..b3c7755 100644 --- a/src/app.ts +++ b/src/app.ts @@ -47,6 +47,7 @@ import { OAUTH_STATE_SKEW_MS, type CreateAccountInput, type StoredCapabilityGrant, + type StoredIdentityMove, type StoredLinkedIdentity, type UpsertLinkedIdentityInput, } from "./store/types.js"; @@ -1064,6 +1065,184 @@ export async function assertStepUp( }; } +export const MOVE_ID_PATTERN = "^[A-Za-z0-9_-]{16,64}$"; + +export interface MoveIdentitiesBody { + moveId: string; + fromProofs: string[]; + toProof?: string; + identityIds?: string[]; + reversesMoveId?: string; +} + +/** The answer a move gives, derived from its stored row so a replay is byte-identical to the first answer. */ +function moveReceipt(move: StoredIdentityMove) { + const tier = (proofs: { tier: "strong" | "weak" }[]) => (proofs.some((proof) => proof.tier === "strong") ? "strong" : "weak"); + return { + moveId: move.id, + accountId: move.toAccountId, + movedIdentityIds: move.moved.map((moved) => moved.id), + proof: { from: tier(move.proof.from), to: move.proof.to ? move.proof.to.tier : null }, + ...(move.reversesMoveId !== undefined ? { reversesMoveId: move.reversesMoveId } : {}), + }; +} + +/** + * POST /v1/apps/{app}/identity-moves: the one sanctioned way a login changes + * account. The caller's secret and its profile's identityMoves grant open the + * route; the accounts come only from the proofs (live bearers of this app, + * fresh by proofTier), never from the body, an email or a name. A proof + * through login X moves X; only an asserted account proof (the profile's + * accountProofMethods) speaks for the whole account. The store decides and + * commits; this route verifies, maps refusals to fixed codes, then writes the + * revocation receipts the move owes (revokeLiveGrants stays their one writer) + * and the audit row. A replayed moveId is answered before the proofs are + * verified, because the first success revoked the source's sessions. + */ +export async function moveIdentitiesRoute( + ctx: Pick, + revokeLiveGrants: (accountId: string, provider: Provider, receipts: Parameters[0], at: string) => Promise, + appSlug: AppSlug, + headers: Record, + body: MoveIdentitiesBody +): Promise { + const { config, keys, store } = ctx; + const refuse = (statusCode: number, error: string, extra: Record = {}): HandlerResult => ({ statusCode, body: { error, ...extra } }); + if (!resolveAppCaller(config, appSlug, headers)) return refuse(401, "app_auth_required"); + const grant = getAppProfile(appSlug)?.identityMoves; + if (!grant) return refuse(403, "not_allowed_for_app"); + + // The providers a move carried away from its source that the source no longer holds: their grants are taken back under the source. + const settleGrants = async (move: StoredIdentityMove) => { + const held = new Set((await store.listStoredLinkedIdentitiesForAccount(move.fromAccountId)).map((identity) => identity.provider)); + const at = new Date().toISOString(); + for (const provider of new Set(move.moved.map((moved) => moved.provider))) { + if (!held.has(provider)) await revokeLiveGrants(move.fromAccountId, provider, await store.listConsentReceipts(move.fromAccountId), at); + } + }; + + const existing = await store.findIdentityMove(body.moveId); + if (existing) { + const signedFor = (token: string | undefined, accountId: string) => { + const verification = token ? verifyJwt(token, keys.publicKey) : null; + return ( + verification?.valid === true && + verification.payload.typ === "heimdall_access" && + verification.payload.iss === config.issuer && + verification.payload.aud === appSlug && + verification.payload.account_id === accountId + ); + }; + const same = + existing.appSlug === appSlug && + existing.reversesMoveId === body.reversesMoveId && + body.fromProofs.every((token) => signedFor(token, existing.fromAccountId)) && + (existing.reversesMoveId !== undefined ? body.toProof === undefined : signedFor(body.toProof, existing.toAccountId)); + if (!same) return refuse(409, "move_id_conflict"); + await settleGrants(existing); + return { statusCode: 200, body: moveReceipt(existing) }; + } + + let forward: StoredIdentityMove | null = null; + if (body.reversesMoveId !== undefined) { + forward = await store.findIdentityMove(body.reversesMoveId); + if (!forward || forward.appSlug !== appSlug || forward.reversesMoveId !== undefined) return refuse(409, "not_reversible"); + } + + const nowS = nowEpochSeconds(); + const resolve = (token: string) => resolveBearer(ctx, `Bearer ${token}`, appSlug); + const fromBearers = []; + for (const token of body.fromProofs) { + const bearer = await resolve(token); + if (!bearer) return refuse(403, "proof_invalid", { proof: "from" }); + fromBearers.push(bearer); + } + const fromAccountId = fromBearers[0]!.accountId; + if (fromBearers.some((bearer) => bearer.accountId !== fromAccountId)) return refuse(403, "proof_invalid", { proof: "from" }); + let toBearer: ResolvedBearer | null = null; + if (forward === null) { + toBearer = await resolve(body.toProof!); + if (!toBearer) return refuse(403, "proof_invalid", { proof: "to" }); + } else if (fromAccountId !== forward.toAccountId) { + return refuse(409, "not_reversible"); + } + const toAccountId = toBearer?.accountId ?? forward!.fromAccountId; + if (fromAccountId === toAccountId) return refuse(409, "same_account"); + + const proofOf = (bearer: ResolvedBearer, tier: "strong" | "weak") => ({ + tier, + method: tier === "strong" && typeof bearer.claims.step_up_method === "string" ? bearer.claims.step_up_method : null, + identityId: typeof bearer.claims.auth_identity_id === "string" ? bearer.claims.auth_identity_id : null, + }); + const fromProof = []; + for (const bearer of fromBearers) { + const tier = proofTier(bearer.claims, nowS); + if (!tier) return refuse(403, "proof_stale", { proof: "from" }); + fromProof.push(proofOf(bearer, tier)); + } + const toTier = toBearer ? proofTier(toBearer.claims, nowS) : null; + if (toBearer && !toTier) return refuse(403, "proof_stale", { proof: "to" }); + + const coverage = fromBearers.map((bearer) => proofCovers(bearer.claims, grant.accountProofMethods, nowS)); + if (coverage.every((covered) => covered === null)) return refuse(403, "identity_not_proved"); + const covers = coverage.includes("account") ? "account" : coverage.filter((covered): covered is string => covered !== null); + + const at = new Date().toISOString(); + const result = await store.moveIdentities({ + moveId: body.moveId, + appSlug, + fromAccountId, + toAccountId, + identityIds: forward ? forward.moved.map((moved) => moved.id) : (body.identityIds ?? "all"), + covers, + proofSessions: [...fromBearers, ...(toBearer ? [toBearer] : [])].map((bearer) => ({ + appSlug, + sessionId: bearer.claims.sid as string, + accountId: bearer.accountId, + accessRevision: bearer.claims.access_revision as number, + })), + ...(body.reversesMoveId !== undefined ? { reversesMoveId: body.reversesMoveId } : {}), + proof: { from: fromProof, to: toBearer && toTier ? proofOf(toBearer, toTier) : null }, + at, + }); + switch (result.kind) { + case "proof_lapsed": + return refuse(403, "proof_invalid"); + case "already_moved": + case "not_reversible": + case "move_id_conflict": + return refuse(409, result.kind); + case "provider_conflict": + return refuse(409, "provider_conflict", { provider: result.provider }); + case "identity_not_found": + return refuse(404, "identity_not_found"); + case "identity_not_proved": + return refuse(403, "identity_not_proved"); + case "replayed": + await settleGrants(result.move); + return { statusCode: 200, body: moveReceipt(result.move) }; + case "moved": { + const { move } = result; + await settleGrants(move); + await store.createAuditEvent({ + accountId: move.fromAccountId, + appSlug, + eventType: "identity_moved", + eventPayloadJson: { + moveId: move.id, + toAccountId: move.toAccountId, + movedIdentityIds: move.moved.map((moved) => moved.id), + providers: move.moved.map((moved) => moved.provider), + tiers: { from: moveReceipt(move).proof.from, to: moveReceipt(move).proof.to }, + reversesMoveId: move.reversesMoveId ?? null, + }, + createdAt: at, + }); + return { statusCode: 200, body: moveReceipt(move) }; + } + } +} + const grantsPageTokenType = "heimdall_grants_page"; const grantsPageTokenTtlSeconds = 600; @@ -2951,6 +3130,44 @@ export async function buildApp(options: BuildAppOptions = {}): Promise( + "/v1/apps/:appSlug/identity-moves", + { + schema: { + params: { + type: "object", + required: ["appSlug"], + additionalProperties: false, + properties: { appSlug: { type: "string", enum: [...appSlugs] } }, + }, + body: { + type: "object", + required: ["moveId", "fromProofs"], + additionalProperties: false, + properties: { + moveId: { type: "string", pattern: MOVE_ID_PATTERN }, + fromProofs: { type: "array", minItems: 1, maxItems: 8, items: { type: "string", minLength: 1, maxLength: 8192 } }, + toProof: { type: "string", minLength: 1, maxLength: 8192 }, + identityIds: { type: "array", minItems: 1, maxItems: 32, uniqueItems: true, items: { type: "string", minLength: 1 } }, + reversesMoveId: { type: "string", pattern: MOVE_ID_PATTERN }, + }, + // A forward move names its destination proof; a reversal names the move and nothing else about who or what. + oneOf: [ + { required: ["toProof"], not: { anyOf: [{ required: ["reversesMoveId"] }] } }, + { required: ["reversesMoveId"], not: { anyOf: [{ required: ["toProof"] }, { required: ["identityIds"] }] } }, + ], + }, + }, + }, + async (request, reply) => { + const result = await moveIdentitiesRoute({ config, keys, store }, revokeLiveGrants, request.params.appSlug, request.headers, request.body); + reply.code(result.statusCode).header("cache-control", "no-store"); + return result.body; + } + ); + // The signed-in surface for consent: every grant and receipt the account // holds, and the one-click way to take each back. app.get<{ Querystring: { t?: string } }>( diff --git a/tests/identity-moves.test.ts b/tests/identity-moves.test.ts new file mode 100644 index 0000000..9ccd1ca --- /dev/null +++ b/tests/identity-moves.test.ts @@ -0,0 +1,541 @@ +import { mkdtempSync, rmSync } from "node:fs"; +import { tmpdir } from "node:os"; +import { join } from "node:path"; +import { afterAll, afterEach, describe, expect, it, vi } from "vitest"; +import { buildApp } from "../src/app.js"; +import { builtInAppProfiles } from "../src/app-profiles.js"; +import { AUTH_PROOF_TTL_SECONDS, issueAccessClaim } from "../src/claims.js"; +import { type AppSlug, type Provider } from "../src/contracts.js"; +import { type OAuthProviderRuntime } from "../src/oauth.js"; +import { createRuntimeKeyMaterial } from "../src/signing.js"; +import { InMemoryStore } from "../src/store/index.js"; +import { type CreateAuditEventInput } from "../src/store/types.js"; +import { createTestConfig, launchFlow } from "./oauth-flow.js"; + +// POST /v1/apps/{app}/identity-moves, driven over HTTP the way Bifrost would +// call it: the proofs are real access tokens whose claims say how and through +// which login the member signed in; the answers are what a caller can see. + +const now = "2026-11-14T12:00:00.000Z"; +const appAuth = { "x-heimdall-app-secret": "bifrost-secret" }; +const moveId = (tag: string) => `move-${tag}`.padEnd(20, "x"); +const nowS = () => Math.floor(Date.now() / 1000); + +const dir = mkdtempSync(join(tmpdir(), "heimdall-identity-moves-")); +const config = { ...createTestConfig(), signingPrivateKeyPath: join(dir, "signing.pem"), bootstrapSigningPrivateKeyOnMissing: true }; +afterAll(() => rmSync(dir, { recursive: true, force: true })); + +const apps: Awaited>[] = []; +afterEach(async () => { + vi.useRealTimers(); + vi.restoreAllMocks(); + await Promise.all(apps.splice(0).map((app) => app.close())); +}); + +function twitchRuntime(providerUserId: string): OAuthProviderRuntime { + return { + async exchangeAuthorizationCode() { + return { accessToken: "at", refreshToken: "rt", tokenType: "Bearer", scope: ["user:read:email"], raw: {} }; + }, + async resolveIdentity() { + return { provider: "twitch", providerUserId, username: providerUserId, profile: { id: providerUserId } }; + }, + async evaluateEntitlements() { + return { facts: [], snapshots: [] }; + }, + }; +} + +async function rig(twitchUser = "t-signin") { + const store = new InMemoryStore(); + const audit: CreateAuditEventInput[] = []; + const realAudit = store.createAuditEvent.bind(store); + store.createAuditEvent = async (input) => { + audit.push(structuredClone(input)); + return realAudit(input); + }; + const app = await buildApp({ config, store, oauthRuntimes: { twitch: twitchRuntime(twitchUser) } }); + apps.push(app); + const keys = createRuntimeKeyMaterial({ ...config, bootstrapSigningPrivateKeyOnMissing: false }); + return { app, store, keys, audit }; +} +type Rig = Awaited>; + +let seq = 0; +/** An account holding the given logins, each with a credential, and one live-session proof factory. */ +async function acct(r: Rig, held: Array<[Provider, string?]>) { + seq += 1; + const account = await r.store.createAccount({ createdAt: now, lastSeenAt: now, displayName: "DISPLAY-CANARY", primaryEmail: "canary@example.test" }); + const rows = []; + for (const [provider, user] of held) { + rows.push( + await r.store.upsertLinkedIdentity({ + accountId: account.id, + provider, + providerUserId: user ?? `${provider}-${seq}`, + scopes: ["identify"], + accessTokenEncrypted: "ACCESS-CIPHERTEXT", + refreshTokenEncrypted: "REFRESH-CIPHERTEXT", + profileJson: {}, + createdAt: now, + updatedAt: now, + }) + ); + } + return { account, rows }; +} +type Acct = Awaited>; + +interface ProofOptions { + app?: AppSlug; + /** Seconds since the sign-in; null mints a token with no sign-in claim (a refresh or link would). */ + signedInAgo?: number | null; + via?: number; + stepUp?: { agoS?: number; method: string }; +} +/** A live session for the account and the access token it would hold. */ +async function proof(r: Rig, a: Acct, o: ProofOptions = {}) { + const ago = o.signedInAgo === undefined ? 0 : o.signedInAgo; + const issued = await issueAccessClaim({ + config, + keys: r.keys, + store: r.store, + input: { + appSlug: o.app ?? "bifrost", + accountId: a.account.id, + linkedIdentities: a.rows.map((row) => ({ provider: row.provider, providerUserId: row.providerUserId })), + facts: [], + ...(ago === null ? {} : { authAt: nowS() - ago, authIdentityId: a.rows[o.via ?? 0]!.id }), + ...(o.stepUp ? { stepUpAt: nowS() - (o.stepUp.agoS ?? 0), stepUpMethod: o.stepUp.method } : {}), + }, + }); + return { token: issued.accessToken, sid: issued.session.sessionId }; +} +const passkey = { method: "bifrost-passkey" }; + +const move = (r: Rig, body: object, headers: Record = appAuth, app = "bifrost") => + r.app.inject({ method: "POST", url: `/v1/apps/${app}/identity-moves`, headers, payload: body }); +const held = async (r: Rig, a: Acct) => (await r.store.listStoredLinkedIdentitiesForAccount(a.account.id)).map((i) => i.id).sort(); +const err = (res: { statusCode: number; json(): { error?: string } }) => [res.statusCode, res.json().error]; + +/** Source with discord+google, destination with patreon: a passkey on the source and any fresh proof on the destination. */ +async function scene(r: Rig) { + const from = await acct(r, [["discord"], ["google"]]); + const to = await acct(r, [["patreon"]]); + return { + from, + to, + fromProof: await proof(r, from, { stepUp: passkey }), + toProof: await proof(r, to), + }; +} + +describe("a sanctioned move", () => { + it("two fresh proofs move every login of the source and answer the receipt, with no token, email or name", async () => { + const r = await rig(); + const s = await scene(r); + const sourceIds = await held(r, s.from); + const res = await move(r, { moveId: moveId("a"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }); + expect(res.statusCode).toBe(200); + expect(res.headers["cache-control"]).toBe("no-store"); + expect(res.json()).toEqual({ + moveId: moveId("a"), + accountId: s.to.account.id, + movedIdentityIds: expect.arrayContaining(sourceIds), + proof: { from: "strong", to: "weak" }, + }); + expect(res.json().movedIdentityIds).toHaveLength(2); + expect(res.body).not.toMatch(/CIPHERTEXT|canary|DISPLAY|ey[A-Za-z0-9_-]{20,}\./); + expect(await held(r, s.from)).toEqual([]); + expect(await held(r, s.to)).toEqual(expect.arrayContaining(sourceIds)); + expect(await held(r, s.to)).toHaveLength(3); + expect(r.audit.find((e) => e.eventType === "identity_moved")).toMatchObject({ + accountId: s.from.account.id, + eventPayloadJson: { moveId: moveId("a"), toAccountId: s.to.account.id, providers: ["discord", "google"], reversesMoveId: null }, + }); + }); + + it("answers the identical body for the same moveId after the source's sessions are revoked, and changes nothing twice", async () => { + const r = await rig(); + const s = await scene(r); + const body = { moveId: moveId("b"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }; + const first = await move(r, body); + expect(first.statusCode).toBe(200); + const session = await r.store.findSession("bifrost", s.fromProof.sid); + expect(Date.parse(session!.expiresAt), "the source's session is already dead").toBeLessThanOrEqual(Date.now()); + const again = await move(r, body); + expect([again.statusCode, again.body]).toEqual([200, first.body]); + expect(r.audit.filter((e) => e.eventType === "identity_moved")).toHaveLength(1); + }); + + it("a moveId reused for another account pair, another proof owner or another reversesMoveId is 409 move_id_conflict and changes nothing", async () => { + const r = await rig(); + const s = await scene(r); + const other = await acct(r, [["twitch"]]); + await move(r, { moveId: moveId("c"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }); + const otherProof = await proof(r, other); + const toStranger = await move(r, { moveId: moveId("c"), fromProofs: [s.fromProof.token], toProof: otherProof.token }); + expect(err(toStranger)).toEqual([409, "move_id_conflict"]); + const fromStranger = await move(r, { moveId: moveId("c"), fromProofs: [otherProof.token], toProof: s.toProof.token }); + expect(err(fromStranger)).toEqual([409, "move_id_conflict"]); + const asReversal = await move(r, { moveId: moveId("c"), fromProofs: [s.toProof.token], reversesMoveId: moveId("zz") }); + expect(err(asReversal)).toEqual([409, "move_id_conflict"]); + expect(await held(r, other)).toHaveLength(1); + expect(await held(r, s.to)).toHaveLength(3); + }); + + it("an app without the secret is 401; streampixels with its own secret is 403 not_allowed_for_app", async () => { + const r = await rig(); + const s = await scene(r); + const body = { moveId: moveId("d"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }; + expect(err(await move(r, body, {}))).toEqual([401, "app_auth_required"]); + expect(err(await move(r, body, { "x-heimdall-app-secret": "nope" }))).toEqual([401, "app_auth_required"]); + expect(err(await move(r, body, { "x-heimdall-app-secret": "streampixels-secret" }, "streampixels"))).toEqual([403, "not_allowed_for_app"]); + expect(await held(r, s.from)).toHaveLength(2); + }); + + it("only bifrost is granted moves, and its account proofs are methods it may assert", () => { + const granted = Object.values(builtInAppProfiles).filter((p) => p.identityMoves !== undefined); + expect(granted.map((p) => p.slug)).toEqual(["bifrost"]); + const bifrost = granted[0]!; + expect(bifrost.identityMoves!.accountProofMethods.every((m) => bifrost.stepUpAssertion!.methods.includes(m))).toBe(true); + expect(bifrost.identityMoves!.accountProofMethods).not.toContain("bifrost-email-code"); + }); +}); + +describe("what a proof must be", () => { + it("another app's token, a revoked session and a forged signature are 403 proof_invalid and nothing moves", async () => { + const r = await rig(); + const s = await scene(r); + const foreign = await proof(r, s.from, { app: "streampixels", stepUp: passkey }); + const revoked = await proof(r, s.from, { stepUp: passkey }); + await r.store.revokeSession("bifrost", revoked.sid, s.from.account.id, 1, new Date().toISOString()); + const forged = s.fromProof.token.slice(0, -6) + "AAAAAA"; + for (const [fromProofs, toProof, who] of [ + [[foreign.token], s.toProof.token, "from"], + [[revoked.token], s.toProof.token, "from"], + [[forged], s.toProof.token, "from"], + [[s.fromProof.token], forged, "to"], + ] as const) { + const res = await move(r, { moveId: moveId("e"), fromProofs, toProof }); + expect([res.statusCode, res.json()]).toEqual([403, { error: "proof_invalid", proof: who }]); + } + expect(await held(r, s.from)).toHaveLength(2); + }); + + it("a sign-in 300 s old passes and 301 s is proof_stale; a token with no sign-in claim (refresh, link) is proof_stale; a step-up inside 600 s reports strong", async () => { + const r = await rig(); + vi.useFakeTimers({ toFake: ["Date"] }); + vi.setSystemTime(new Date(now)); + const to = await acct(r, [["patreon"]]); + const toProof = await proof(r, to); + const providers: Provider[] = ["discord", "google", "twitch", "github", "spotify", "youtube"]; + const attempt = async (tag: string, o: ProofOptions) => { + const from = await acct(r, [[providers.shift()!]]); + const p = await proof(r, from, o); + return move(r, { moveId: moveId(tag), fromProofs: [p.token], toProof: toProof.token }); + }; + const edge = await attempt("edge", { signedInAgo: AUTH_PROOF_TTL_SECONDS }); + expect([edge.statusCode, edge.json().proof]).toEqual([200, { from: "weak", to: "weak" }]); + const late = await attempt("late", { signedInAgo: AUTH_PROOF_TTL_SECONDS + 1 }); + expect([late.statusCode, late.json()]).toEqual([403, { error: "proof_stale", proof: "from" }]); + const none = await attempt("none", { signedInAgo: null }); + expect(err(none)).toEqual([403, "proof_stale"]); + const strong = await attempt("strong", { signedInAgo: 5_000, stepUp: { agoS: 600, method: "provider:twitch" } }); + expect([strong.statusCode, strong.json().proof.from]).toEqual([200, "strong"]); + const stale = await attempt("stale", { signedInAgo: 5_000, stepUp: { agoS: 601, method: "bifrost-passkey" } }); + expect(err(stale)).toEqual([403, "proof_stale"]); + // The destination's proof is held to the same rule. + const from = await acct(r, [["google"]]); + const fresh = await proof(r, from); + const staleTo = await proof(r, to, { signedInAgo: AUTH_PROOF_TTL_SECONDS + 1 }); + const res = await move(r, { moveId: moveId("sto"), fromProofs: [fresh.token], toProof: staleTo.token }); + expect([res.statusCode, res.json()]).toEqual([403, { error: "proof_stale", proof: "to" }]); + }); + + it("fromProofs naming two accounts is 403 proof_invalid; one account on both sides is 409 same_account", async () => { + const r = await rig(); + const s = await scene(r); + const split = await move(r, { moveId: moveId("f"), fromProofs: [s.fromProof.token, s.toProof.token], toProof: s.toProof.token }); + expect([split.statusCode, split.json()]).toEqual([403, { error: "proof_invalid", proof: "from" }]); + const twice = await proof(r, s.from, { stepUp: passkey }); + const same = await move(r, { moveId: moveId("g"), fromProofs: [s.fromProof.token], toProof: twice.token }); + expect(err(same)).toEqual([409, "same_account"]); + expect(await held(r, s.from)).toHaveLength(2); + }); + + it("the body is closed: a forward move needs toProof, a reversal takes no toProof or identityIds, ids are patterned", async () => { + const r = await rig(); + const s = await scene(r); + const t = s.fromProof.token; + for (const body of [ + { moveId: moveId("h"), fromProofs: [t] }, + { moveId: "short", fromProofs: [t], toProof: t }, + { moveId: moveId("h"), fromProofs: [], toProof: t }, + { moveId: moveId("h"), fromProofs: [t], toProof: t, reversesMoveId: moveId("i") }, + { moveId: moveId("h"), fromProofs: [t], reversesMoveId: moveId("i"), identityIds: ["x"] }, + ]) { + expect((await move(r, body)).statusCode, JSON.stringify(Object.keys(body))).toBe(400); + } + }); +}); + +describe("accounts come only from proofs", () => { + it("a stray accountId in the body steers nothing", async () => { + const r = await rig(); + const s = await scene(r); + const stranger = await acct(r, [["twitch"]]); + const res = await move(r, { moveId: moveId("y"), fromProofs: [s.fromProof.token], toProof: s.toProof.token, accountId: stranger.account.id, toAccountId: stranger.account.id }); + expect([res.statusCode, res.json().accountId]).toEqual([200, s.to.account.id]); + expect(await held(r, stranger)).toHaveLength(1); + }); +}); + +describe("which logins a proof moves", () => { + async function multi(r: Rig) { + const from = await acct(r, [["discord"], ["google"], ["twitch"]]); + const to = await acct(r, [["patreon"]]); + return { from, to, toProof: await proof(r, to) }; + } + + it("a sign-in through login X moves X and cannot move the source's other logins", async () => { + const r = await rig(); + const s = await multi(r); + const [discord, google] = s.from.rows; + const viaDiscord = await proof(r, s.from, { via: 0 }); + const all = await move(r, { moveId: moveId("j"), fromProofs: [viaDiscord.token], toProof: s.toProof.token }); + expect(err(all)).toEqual([403, "identity_not_proved"]); + const other = await move(r, { moveId: moveId("j"), fromProofs: [viaDiscord.token], toProof: s.toProof.token, identityIds: [google!.id] }); + expect(err(other)).toEqual([403, "identity_not_proved"]); + expect(await held(r, s.from)).toHaveLength(3); + const only = await move(r, { moveId: moveId("j"), fromProofs: [viaDiscord.token], toProof: s.toProof.token, identityIds: [discord!.id] }); + expect([only.statusCode, only.json().movedIdentityIds]).toEqual([200, [discord!.id]]); + expect((await held(r, s.from)).sort()).toEqual([google!.id, s.from.rows[2]!.id].sort()); + }); + + it("one proof per login moves them all; an asserted passkey covers the whole account; an email code covers only its own login", async () => { + const r = await rig(); + let s = await multi(r); + const perLogin = await Promise.all(s.from.rows.map((_, via) => proof(r, s.from, { via }))); + const res = await move(r, { moveId: moveId("k"), fromProofs: perLogin.map((p) => p.token), toProof: s.toProof.token }); + expect([res.statusCode, res.json().movedIdentityIds]).toHaveLength(2); + expect(res.json().proof.from).toBe("weak"); + expect(await held(r, s.from)).toEqual([]); + + s = await multi(r); + const byPasskey = await proof(r, s.from, { stepUp: passkey }); + expect((await move(r, { moveId: moveId("l"), fromProofs: [byPasskey.token], toProof: s.toProof.token })).statusCode).toBe(200); + + s = await multi(r); + const byEmail = await proof(r, s.from, { stepUp: { method: "bifrost-email-code" } }); + const refused = await move(r, { moveId: moveId("m"), fromProofs: [byEmail.token], toProof: s.toProof.token }); + expect(err(refused)).toEqual([403, "identity_not_proved"]); + expect(await held(r, s.from)).toHaveLength(3); + }); + + it("a provider held on both sides is 409 provider_conflict naming only the provider, and nothing moves", async () => { + const r = await rig(); + const from = await acct(r, [["discord"], ["google"]]); + const to = await acct(r, [["discord"]]); + const res = await move(r, { moveId: moveId("n"), fromProofs: [(await proof(r, from, { stepUp: passkey })).token], toProof: (await proof(r, to)).token }); + expect([res.statusCode, res.json()]).toEqual([409, { error: "provider_conflict", provider: "discord" }]); + expect(res.body).not.toContain(from.account.id); + expect(await held(r, from)).toHaveLength(2); + expect(await held(r, to)).toHaveLength(1); + }); + + it("naming an identity the source does not hold is 404 identity_not_found", async () => { + const r = await rig(); + const s = await scene(r); + const res = await move(r, { moveId: moveId("o"), fromProofs: [s.fromProof.token], toProof: s.toProof.token, identityIds: [s.to.rows[0]!.id] }); + expect(err(res)).toEqual([404, "identity_not_found"]); + }); +}); + +describe("what a move leaves behind", () => { + it("strips the moved credentials, expires the source's sessions, pending links and unredeemed completions, and leaves the destination live", async () => { + const r = await rig(); + const s = await scene(r); + const linkInput = { appSlug: "bifrost" as const, provider: "discord" as const, providerUserId: "d-x", identity: { accountId: "x", provider: "discord" as const, providerUserId: "d-x", scopes: [], profileJson: {}, createdAt: now, updatedAt: now }, returnTo: "https://bifrost.gamecult.org/x", createdAt: now, expiresAt: "2099-01-01T00:00:00.000Z" }; + const srcLink = await r.store.createPendingLink({ ...linkInput, accountId: s.from.account.id }); + const dstLink = await r.store.createPendingLink({ ...linkInput, accountId: s.to.account.id }); + const completion = (accountId: string) => + r.store.createAuthCompletion({ appSlug: "bifrost", provider: "discord", mode: "sign_in", accountId, sessionId: "sess", returnTo: "https://bifrost.gamecult.org/x", createdAt: now, expiresAt: "2099-01-01T00:00:00.000Z", payloadJson: {} }); + const srcCompletion = await completion(s.from.account.id); + const dstCompletion = await completion(s.to.account.id); + const res = await move(r, { moveId: moveId("p"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }); + expect(res.statusCode).toBe(200); + const movedIds = new Set(s.from.rows.map((row) => row.id)); + for (const row of (await r.store.listStoredLinkedIdentitiesForAccount(s.to.account.id)).filter((row) => movedIds.has(row.id))) { + expect(row.accessTokenEncrypted).toBeUndefined(); + expect(row.refreshTokenEncrypted).toBeUndefined(); + } + const record = await r.store.findIdentityMove(moveId("p")); + expect(record?.moved.map((m) => m.credentialStripped)).toEqual([true, true]); + expect((await r.store.findSession("bifrost", s.fromProof.sid))!.accessRevision).toBe(2); + expect((await r.store.findSession("bifrost", s.toProof.sid))!.accessRevision).toBe(1); + expect(Date.parse((await r.store.findSession("bifrost", s.toProof.sid))!.expiresAt)).toBeGreaterThan(Date.now()); + expect(await r.store.consumePendingLink("bifrost", srcLink.id, s.from.account.id, new Date().toISOString())).toBeNull(); + expect(await r.store.consumePendingLink("bifrost", dstLink.id, s.to.account.id, new Date().toISOString())).not.toBeNull(); + expect(await r.store.consumeAuthCompletion("bifrost", srcCompletion.code, new Date().toISOString())).toBeNull(); + expect(await r.store.consumeAuthCompletion("bifrost", dstCompletion.code, new Date().toISOString())).not.toBeNull(); + }); + + it("revokes the source's live grants for the providers it no longer holds, leaves the destination's receipts, and a replay heals a crash after commit", async () => { + const r = await rig(); + const s = await scene(r); + const grant = (accountId: string, provider: Provider) => + r.store.createConsentReceipt({ kind: "grant", accountId, appSlug: "bifrost", provider, createdAt: now, scopesAsked: ["identify"], scopesGranted: ["identify"], consentPageDigest: "d", consentText: "t" }); + await grant(s.from.account.id, "discord"); + await grant(s.to.account.id, "patreon"); + const receiptsOf = async (a: Acct) => (await r.store.listConsentReceipts(a.account.id)).map((x) => `${x.kind}:${x.provider}`); + const body = { moveId: moveId("q"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }; + vi.spyOn(r.store, "createConsentReceipt").mockRejectedValueOnce(new Error("crash after commit")); + expect((await move(r, body)).statusCode).toBe(500); + expect(await held(r, s.from), "the move itself committed").toEqual([]); + expect(await receiptsOf(s.from)).toEqual(["grant:discord"]); + const healed = await move(r, body); + expect(healed.statusCode).toBe(200); + expect(await receiptsOf(s.from)).toEqual(["grant:discord", "revocation:discord"]); + expect(await receiptsOf(s.to)).toEqual(["grant:patreon"]); + expect((await move(r, body)).body, "and it is idempotent").toBe(healed.body); + expect(await receiptsOf(s.from)).toHaveLength(2); + }); + + it("the destination never loses an identity, whatever is refused", async () => { + const r = await rig(); + const s = await scene(r); + const before = (await held(r, s.to)).length; + const refusals = [ + { moveId: moveId("r1"), fromProofs: [s.fromProof.token], toProof: s.toProof.token, identityIds: ["nope"] }, + { moveId: moveId("r2"), fromProofs: [s.fromProof.token], toProof: s.fromProof.token }, + { moveId: moveId("r3"), fromProofs: [s.toProof.token], toProof: s.toProof.token }, + ]; + for (const body of refusals) { + await move(r, body); + expect((await held(r, s.to)).length).toBeGreaterThanOrEqual(before); + } + expect((await move(r, { moveId: moveId("r4"), fromProofs: [s.fromProof.token], toProof: s.toProof.token })).statusCode).toBe(200); + expect((await held(r, s.to)).length).toBeGreaterThanOrEqual(before); + }); + + it("a sign-in through a moved login lands on the destination, with no alias lookup", async () => { + const r = await rig("t-moved"); + const from = await acct(r, [["twitch", "t-moved"]]); + const to = await acct(r, [["patreon"]]); + const mv = await move(r, { moveId: moveId("s"), fromProofs: [(await proof(r, from, { stepUp: passkey })).token], toProof: (await proof(r, to)).token }); + expect(mv.statusCode).toBe(200); + const started = await r.app.inject({ method: "POST", url: "/v1/oauth/twitch/start", payload: { appSlug: "streampixels", mode: "sign_in", returnTo: "https://streampixels.gamecult.org/signin/return" } }); + const flow = await launchFlow(r.app, started.json()); + const called = await r.app.inject({ method: "GET", url: `/v1/oauth/twitch/callback?code=c&state=${encodeURIComponent(flow.state)}`, headers: { cookie: flow.cookie, accept: "application/json" } }); + expect(called.statusCode).toBe(201); + expect(called.json().account.id).toBe(to.account.id); + }); +}); + +describe("aliases and reversal", () => { + it("an emptied source is an alias; moving into or out of it is 409 already_moved; resolution is one hop", async () => { + const r = await rig(); + const s = await scene(r); + expect((await move(r, { moveId: moveId("t"), fromProofs: [s.fromProof.token], toProof: s.toProof.token })).statusCode).toBe(200); + expect(await r.store.resolveAccount(s.from.account.id)).toBe(s.to.account.id); + expect(await r.store.resolveAccount(s.to.account.id)).toBe(s.to.account.id); + // A session can outlive its logins only by being minted for an account that holds none, which is how a stale caller would look. + const aliasProof = await proof(r, { account: s.from.account, rows: [s.to.rows[0]!] }, { stepUp: passkey }); + const third = await acct(r, [["github"]]); + const out = await move(r, { moveId: moveId("u"), fromProofs: [aliasProof.token], toProof: (await proof(r, third)).token }); + expect(err(out)).toEqual([409, "already_moved"]); + const aliasTo = await proof(r, { account: s.from.account, rows: [s.to.rows[0]!] }); + const into = await move(r, { moveId: moveId("u2"), fromProofs: [(await proof(r, third, { stepUp: passkey })).token], toProof: aliasTo.token }); + expect(err(into)).toEqual([409, "already_moved"]); + expect(await held(r, third)).toHaveLength(1); + }); + + it("a reversal through a moved login moves exactly those logins back; a second reversal is not_reversible; credentials stay stripped", async () => { + const r = await rig(); + const s = await scene(r); + const sourceIds = await held(r, s.from); + await move(r, { moveId: moveId("v"), fromProofs: [s.fromProof.token], toProof: s.toProof.token }); + const [discord, google] = s.from.rows; + // The destination now holds the moved logins: a sign-in through one of them is a proof of the destination. + const viaMoved = await proof(r, { account: s.to.account, rows: [discord!, google!] }, { via: 0 }); + const own = await proof(r, s.to, { via: 0 }); + const denied = await move(r, { moveId: moveId("w"), fromProofs: [own.token], reversesMoveId: moveId("v") }); + expect(err(denied), "the destination's own login does not speak for the moved ones").toEqual([403, "identity_not_proved"]); + const viaBoth = [viaMoved, await proof(r, { account: s.to.account, rows: [discord!, google!] }, { via: 1 })]; + const back = await move(r, { moveId: moveId("w"), fromProofs: viaBoth.map((p) => p.token), reversesMoveId: moveId("v") }); + expect(back.statusCode, back.body).toBe(200); + expect(back.json()).toEqual({ moveId: moveId("w"), accountId: s.from.account.id, movedIdentityIds: expect.arrayContaining(sourceIds), proof: { from: "weak", to: null }, reversesMoveId: moveId("v") }); + expect(await held(r, s.from)).toEqual(sourceIds); + expect(await held(r, s.to)).toHaveLength(1); + expect((await r.store.listStoredLinkedIdentitiesForAccount(s.from.account.id)).every((i) => i.accessTokenEncrypted === undefined)).toBe(true); + expect(await r.store.resolveAccount(s.from.account.id)).toBe(s.from.account.id); + const own2 = await proof(r, s.to, { via: 0 }); + const again = await move(r, { moveId: moveId("w2"), fromProofs: [own2.token], reversesMoveId: moveId("v") }); + expect(err(again)).toEqual([409, "not_reversible"]); + const reverseTheReversal = await move(r, { moveId: moveId("w3"), fromProofs: [(await proof(r, s.from)).token], reversesMoveId: moveId("w") }); + expect(err(reverseTheReversal)).toEqual([409, "not_reversible"]); + const unknown = await move(r, { moveId: moveId("w4"), fromProofs: [(await proof(r, s.from)).token], reversesMoveId: moveId("nothere") }); + expect(err(unknown)).toEqual([409, "not_reversible"]); + }); +}); + +describe("what a refusal says", () => { + it("no refusal body names an account id, an email, a name or an identity the caller did not send", async () => { + const r = await rig(); + const s = await scene(r); + const stranger = await acct(r, [["discord", "d-stranger"]]); + const bodies = [ + await move(r, { moveId: moveId("x1"), fromProofs: [s.fromProof.token], toProof: "garbage" }), + await move(r, { moveId: moveId("x2"), fromProofs: [(await proof(r, s.from, { via: 0 })).token], toProof: s.toProof.token }), + await move(r, { moveId: moveId("x3"), fromProofs: [s.fromProof.token], toProof: s.toProof.token, identityIds: [stranger.rows[0]!.id] }), + await move(r, { moveId: moveId("x4"), fromProofs: [s.toProof.token], toProof: s.toProof.token }), + await move(r, { moveId: moveId("x5"), fromProofs: [s.fromProof.token], reversesMoveId: moveId("nothere") }), + await move(r, { moveId: moveId("x6"), fromProofs: [(await proof(r, s.from, { signedInAgo: 9_999 })).token], toProof: s.toProof.token }), + ]; + const ids = [s.from, s.to, stranger].flatMap((a) => [a.account.id, ...a.rows.map((row) => row.id), ...a.rows.map((row) => row.providerUserId)]); + for (const res of bodies) { + expect(res.statusCode).toBeGreaterThanOrEqual(400); + for (const id of ids) expect(res.body).not.toContain(id); + expect(res.body).not.toMatch(/canary|DISPLAY/); + expect(Object.keys(res.json()).every((k) => ["error", "detail", "proof", "provider"].includes(k))).toBe(true); + } + }); +}); + +describe("claims: which sign-in a token came from", () => { + const returnTo = "https://streampixels.gamecult.org/signin/return"; + async function twitchSignIn(r: Rig) { + const started = await r.app.inject({ method: "POST", url: "/v1/oauth/twitch/start", payload: { appSlug: "streampixels", mode: "sign_in", returnTo } }); + const flow = await launchFlow(r.app, started.json()); + const called = await r.app.inject({ method: "GET", url: `/v1/oauth/twitch/callback?code=c&state=${encodeURIComponent(flow.state)}`, headers: { cookie: flow.cookie, accept: "application/json" } }); + expect(called.statusCode).toBe(201); + const redeemed = await r.app.inject({ method: "POST", url: "/v1/apps/streampixels/auth-completions/redeem", payload: { completionCode: called.json().completion.code } }); + expect(redeemed.statusCode).toBe(201); + return redeemed.json() as { refreshToken: string; claimSet: Record }; + } + + it("a sign_in stamps auth_at and the login it came through; a refresh does not renew them", async () => { + const r = await rig("t-claims"); + const before = nowS(); + const signed = await twitchSignIn(r); + const row = await r.store.findStoredLinkedIdentity("twitch", "t-claims"); + expect(signed.claimSet.auth_identity_id).toBe(row!.id); + expect(signed.claimSet.auth_at).toBeGreaterThanOrEqual(before); + expect(signed.claimSet.auth_at).toBeLessThanOrEqual(nowS()); + expect(signed.claimSet.step_up_at).toBeUndefined(); + const refreshed = await r.app.inject({ method: "POST", url: "/v1/apps/streampixels/sessions/refresh", payload: { refreshToken: signed.refreshToken } }); + expect(refreshed.statusCode).toBe(201); + expect(refreshed.json().claimSet.auth_at).toBeUndefined(); + expect(refreshed.json().claimSet.auth_identity_id).toBeUndefined(); + }); + + it("an asserted step-up carries the bearer's auth claims through unchanged", async () => { + const r = await rig(); + const a = await acct(r, [["discord"], ["google"]]); + const p = await proof(r, a, { via: 1, signedInAgo: 30 }); + const res = await r.app.inject({ method: "POST", url: "/v1/apps/bifrost/step-up", headers: { ...appAuth, authorization: `Bearer ${p.token}` }, payload: { method: "bifrost-passkey", nonce: "n".repeat(32) } }); + expect(res.statusCode).toBe(201); + expect(res.json().claimSet).toMatchObject({ auth_identity_id: a.rows[1]!.id, auth_at: nowS() - 30, step_up_method: "bifrost-passkey" }); + }); +}); diff --git a/tests/store.test.ts b/tests/store.test.ts index 0e4dcac..a0682dc 100644 --- a/tests/store.test.ts +++ b/tests/store.test.ts @@ -249,6 +249,10 @@ describe.each(unlinkStores)("linked_identities writes, %s", (_name, make) => { expect(await store.listStoredLinkedIdentitiesForAccount(b.id)).toEqual([]); }); + it.skipIf(realPostgresOnly)("moveIdentities keeps one contract: moved, replayed, conflict, lapsed proof, coverage, reversal", async () => { + await exerciseMoveContract(await make()); + }); + it("upsert by the holder still refreshes its own row, keeping its id", async () => { const { store, a } = await twoAccounts(); const first = await store.upsertLinkedIdentity(input(a.id, "u1", { username: "one" })); @@ -477,9 +481,10 @@ describe("PostgresStore.checkSchema", () => { "capability_grants", "entitlement_snapshots", "consent_receipts", + "identity_moves", "audit_events", ]); - expect(REQUIRED_COLUMNS).toHaveLength(113); + expect(REQUIRED_COLUMNS).toHaveLength(121); expect(REQUIRED_COLUMNS).toEqual( expect.arrayContaining([ { table: "auth_completions", column: "code", type: "TEXT", nullable: false }, @@ -490,7 +495,7 @@ describe("PostgresStore.checkSchema", () => { { table: "auth_completions", column: "attempt_id", type: "TEXT", nullable: true }, ]) ); - expect(REQUIRED_KEYS).toHaveLength(17); + expect(REQUIRED_KEYS).toHaveLength(19); expect(REQUIRED_KEYS).toEqual( expect.arrayContaining([ { table: "linked_identities", columns: "provider,provider_user_id", predicate: "" }, @@ -498,6 +503,7 @@ describe("PostgresStore.checkSchema", () => { { table: "oauth_state_uses", columns: "jti,phase", predicate: "" }, { table: "consent_receipts", columns: "revokes_receipt_id", predicate: "revokes_receipt_id IS NOT NULL" }, { table: "consent_receipts", columns: "account_id,id", predicate: "" }, + { table: "identity_moves", columns: "reverses_move_id", predicate: "reverses_move_id IS NOT NULL" }, { table: "entitlement_snapshots", columns: "account_id,provider,scope", predicate: "" }, { table: "auth_completions", columns: "app_slug,attempt_id", predicate: "attempt_id IS NOT NULL AND consumed_at IS NULL" }, ]) @@ -648,9 +654,108 @@ async function exerciseStore(store: PostgresStore): Promise> { expect(second.receipt.id).toBe(first.receipt.id); expect((await s.listConsentReceipts(account.id)).map((r) => r.kind)).toEqual(["grant", "revocation"]); await s.createAuditEvent({ eventType: "probe", eventPayloadJson: {}, createdAt: now }); + const target = await s.createAccount({ createdAt: now, lastSeenAt: now }); + await s.upsertLinkedIdentity({ ...identity, accountId: target.id, provider: "patreon", providerUserId: "u-target" }); + const moveId = `move-${randomUUID()}`; + expect((await s.moveIdentities({ moveId, appSlug: "bifrost", fromAccountId: account.id, toAccountId: target.id, identityIds: "all", covers: "account", proofSessions: [], proof: { from: [], to: null }, at: now })).kind).toBe("moved"); + expect((await s.findIdentityMove(moveId))?.id).toBe(moveId); + expect(await s.resolveAccount(account.id)).toBe(target.id); return called; } +/** + * The move contract both stores keep, once. Each case builds its own accounts, + * so the order of cases proves nothing and a store holding earlier moves is fine. + */ +async function exerciseMoveContract(store: HeimdallStore): Promise { + const at = "2026-11-14T12:00:00.000Z"; + const later = "2999-01-01T00:00:00.000Z"; + const proofTiers = { from: [{ tier: "strong" as const, method: "bifrost-passkey", identityId: null }], to: { tier: "weak" as const, method: null, identityId: null } }; + const side = async (providers: Array<"discord" | "google" | "patreon">) => { + const account = await store.createAccount({ createdAt: at, lastSeenAt: at }); + const rows = []; + for (const provider of providers) { + rows.push(await store.upsertLinkedIdentity({ accountId: account.id, provider, providerUserId: `${provider}-${randomUUID()}`, accessTokenEncrypted: "A", refreshTokenEncrypted: "R", scopes: [], profileJson: {}, createdAt: at, updatedAt: at })); + } + const sessionId = randomUUID(); + await store.createSession({ id: sessionId, accountId: account.id, appSlug: "bifrost", createdAt: at, lastSeenAt: at, expiresAt: later, accessRevision: 1, claimsJson: {} }); + return { account, rows, proofSession: { appSlug: "bifrost" as const, sessionId, accountId: account.id, accessRevision: 1 } }; + }; + const input = (from: Awaited>, to: Awaited>, extra: Record = {}) => ({ + moveId: `move-${randomUUID()}`, + appSlug: "bifrost" as const, + fromAccountId: from.account.id, + toAccountId: to.account.id, + identityIds: "all" as const, + covers: "account" as const, + proofSessions: [from.proofSession, to.proofSession], + proof: proofTiers, + at, + ...extra, + }); + const held = async (a: { account: { id: string } }) => (await store.listStoredLinkedIdentitiesForAccount(a.account.id)).map((i) => i.id).sort(); + + // Moved: rows, credentials, sessions and the record. + const a = await side(["discord", "google"]); + const b = await side(["patreon"]); + const first = input(a, b); + const moved = await store.moveIdentities(first); + expect(moved.kind).toBe("moved"); + expect(await held(a)).toEqual([]); + expect(await held(b)).toEqual([...a.rows.map((r) => r.id), ...b.rows.map((r) => r.id)].sort()); + for (const row of await store.listStoredLinkedIdentitiesForAccount(b.account.id)) { + if (a.rows.some((r) => r.id === row.id)) expect([row.accessTokenEncrypted, row.refreshTokenEncrypted]).toEqual([undefined, undefined]); + else expect(row.accessTokenEncrypted, "the destination's own credential is untouched").toBe("A"); + } + const record = await store.findIdentityMove(first.moveId); + expect(record).toMatchObject({ id: first.moveId, fromAccountId: a.account.id, toAccountId: b.account.id, proof: proofTiers, createdAt: at }); + expect(record!.moved.map((m) => m.credentialStripped)).toEqual([true, true]); + expect((await store.findSession("bifrost", a.proofSession.sessionId))!.accessRevision).toBe(2); + expect((await store.findSession("bifrost", b.proofSession.sessionId))!.accessRevision).toBe(1); + expect(await store.resolveAccount(a.account.id)).toBe(b.account.id); + expect(await store.resolveAccount(b.account.id)).toBe(b.account.id); + + // Replay answers from the row, even though the proof session is gone; a different pair is a conflict. + expect(await store.moveIdentities(first)).toEqual({ kind: "replayed", move: record }); + const c = await side(["discord"]); + expect(await store.moveIdentities({ ...first, toAccountId: c.account.id })).toEqual({ kind: "move_id_conflict" }); + expect(await store.moveIdentities({ ...first, reversesMoveId: "x" })).toEqual({ kind: "move_id_conflict" }); + + // Into or out of an alias. + expect((await store.moveIdentities(input(a, c, { proofSessions: [c.proofSession] }))).kind).toBe("already_moved"); + expect((await store.moveIdentities(input(c, a, { proofSessions: [c.proofSession] }))).kind).toBe("already_moved"); + + // A proof session that was revoked, or has moved on a revision, has lapsed. + const d = await side(["google"]); + const e = await side(["patreon"]); + await store.revokeSession("bifrost", e.proofSession.sessionId, e.account.id, 1, at); + expect((await store.moveIdentities(input(d, e))).kind).toBe("proof_lapsed"); + expect(await held(d)).toHaveLength(1); + + // Coverage and conflict. + const f = await side(["discord", "google"]); + const g = await side(["patreon"]); + expect((await store.moveIdentities(input(f, g, { covers: [f.rows[0]!.id] }))).kind).toBe("identity_not_proved"); + expect((await store.moveIdentities(input(f, g, { identityIds: ["nope"] }))).kind).toBe("identity_not_found"); + const h = await side(["discord"]); + expect(await store.moveIdentities(input(f, h))).toEqual({ kind: "provider_conflict", provider: "discord" }); + expect(await held(f)).toHaveLength(2); + const onlyDiscord = await store.moveIdentities(input(f, g, { identityIds: [f.rows[0]!.id], covers: [f.rows[0]!.id] })); + expect(onlyDiscord.kind).toBe("moved"); + expect(await held(f)).toEqual([f.rows[1]!.id]); + + // Reversal: moves exactly what the forward carried, once, and a reversal is not itself reversible. + const forward = (moved as { move: { id: string } }).move; + const back = input(b, a, { reversesMoveId: forward.id, proofSessions: [], identityIds: a.rows.map((r) => r.id), covers: a.rows.map((r) => r.id) }); + const reversed = await store.moveIdentities(back); + expect(reversed.kind).toBe("moved"); + expect(await held(a)).toEqual(a.rows.map((r) => r.id).sort()); + expect(await held(b)).toEqual(b.rows.map((r) => r.id)); + expect(await store.resolveAccount(a.account.id)).toBe(a.account.id); + expect((await store.moveIdentities({ ...back, moveId: `move-${randomUUID()}` })).kind).toBe("not_reversible"); + expect((await store.moveIdentities(input(a, b, { reversesMoveId: back.moveId, proofSessions: [], identityIds: "all" }))).kind).toBe("not_reversible"); +} + // Against a real Postgres, through the startup path itself: createStore, with // and without applying the schema. HEIMDALL_TEST_PG_ADMIN_URL names a role // that may create databases and roles. Each case clones a template database @@ -803,6 +908,83 @@ describe.skipIf(!adminUrl)("startup against a live Postgres (HEIMDALL_TEST_PG_AD expect(await start(urlFor(name, role, rolePassword), false)).toBe(refusal("SCHEMA_PRIVILEGES")); }); + it("startup refuses a role that lacks INSERT or SELECT on identity_moves", async () => { + expect(STORE_TABLE_PRIVILEGES.identity_moves).toEqual(["SELECT", "INSERT"]); + for (const [kept, dropped] of [[["SELECT"], "INSERT"], [["INSERT"], "SELECT"]] as const) { + const { name, owner } = await appliedDatabase(); + await grant(owner, { ...STORE_TABLE_PRIVILEGES, identity_moves: kept }); + expect(await start(urlFor(name, role, rolePassword), false), `without ${dropped}`).toBe(refusal("SCHEMA_PRIVILEGES")); + } + }); + + it("on real Postgres: the move contract holds", async () => { + const { owner } = await appliedDatabase(); + await exerciseMoveContract(new PostgresStore(owner)); + }); + + describe("concurrent moves", () => { + const at = "2026-11-14T12:00:00.000Z"; + async function pair(store: PostgresStore) { + const make = async (provider: "discord" | "patreon") => { + const account = await store.createAccount({ createdAt: at, lastSeenAt: at }); + await store.upsertLinkedIdentity({ accountId: account.id, provider, providerUserId: `${provider}-${randomUUID()}`, scopes: [], profileJson: {}, createdAt: at, updatedAt: at }); + const sessionId = randomUUID(); + await store.createSession({ id: sessionId, accountId: account.id, appSlug: "bifrost", createdAt: at, lastSeenAt: at, expiresAt: "2999-01-01T00:00:00.000Z", accessRevision: 1, claimsJson: {} }); + return { id: account.id, proof: { appSlug: "bifrost" as const, sessionId, accountId: account.id, accessRevision: 1 } }; + }; + return { x: await make("discord"), y: await make("patreon") }; + } + const request = (from: { id: string; proof: object }, to: { id: string; proof: object }, moveId: string) => ({ + moveId, + appSlug: "bifrost" as const, + fromAccountId: from.id, + toAccountId: to.id, + identityIds: "all" as const, + covers: "account" as const, + proofSessions: [from.proof, to.proof] as never, + proof: { from: [], to: null }, + at, + }); + + it("opposite moves A->B and B->A over two pools leave one applied and never deadlock, ten rounds", async () => { + const { name, owner } = await appliedDatabase(); + const storeA = new PostgresStore(owner); + const other = fixturePool(urlFor(name)); + cleanup.push(async () => { + await other.end(); + }); + const storeB = new PostgresStore(other); + for (let round = 0; round < 10; round += 1) { + const { x, y } = await pair(storeA); + const results = await Promise.all([ + storeA.moveIdentities(request(x, y, `move-${randomUUID()}`)), + storeB.moveIdentities(request(y, x, `move-${randomUUID()}`)), + ]); + const kinds = results.map((r) => r.kind).sort(); + expect(kinds[0], `round ${round}: ${kinds}`).toBe("moved"); + expect(["already_moved", "proof_lapsed"], `round ${round}: ${kinds}`).toContain(kinds[1]); + const held = (await storeA.listStoredLinkedIdentitiesForAccount(x.id)).length + (await storeA.listStoredLinkedIdentitiesForAccount(y.id)).length; + expect(held, "no identity is lost or duplicated").toBe(2); + } + }); + + it("two concurrent identical moveIds: one moved, one replayed", async () => { + const { name, owner } = await appliedDatabase(); + const storeA = new PostgresStore(owner); + const other = fixturePool(urlFor(name)); + cleanup.push(async () => { + await other.end(); + }); + const storeB = new PostgresStore(other); + for (let round = 0; round < 5; round += 1) { + const { x, y } = await pair(storeA); + const body = request(x, y, `move-${randomUUID()}`); + const results = await Promise.all([storeA.moveIdentities(body), storeB.moveIdentities(body)]); + expect(results.map((r) => r.kind).sort(), `round ${round}`).toEqual(["moved", "replayed"]); + } + }); + }); + it("on real Postgres: an upsert never moves an identity, and concurrent unlinks of the last two leave one", async () => { const { name, owner } = await appliedDatabase(); const clientA = new PostgresStore(owner); @@ -920,6 +1102,7 @@ describe.skipIf(!adminUrl)("startup against a live Postgres (HEIMDALL_TEST_PG_AD const appliedByIndex = { auth_completions_attempt_unconsumed_unique_idx: "auth_completions", consent_receipts_revokes_unique_idx: "consent_receipts", + identity_moves_reverses_unique_idx: "identity_moves", }; const partialKeys = REQUIRED_KEYS.flatMap((key, index) => (key.predicate === "" ? [] : [{ key, index }])); expect(partialKeys.map(({ key }) => key.table).sort()).toEqual(Object.values(appliedByIndex).sort());