GameCult/Heimdall
Watch
9
0
Fork
You've already forked Heimdall
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Vendor CultLib as a gitlink so Heimdall's source can be sealed

Browse source 
Heimdall took CultLib as file:../CultLib/packages/*, a sibling checkout
outside this repository. Nothing pinned which CultLib a given Heimdall
commit was built against, and a sealed source could not reach it. The
deploy manifest worked around this by cloning CultLib separately to
/srv/build/CultLib with cultlib_commit=5cefa0db hardcoded in shell -- the
pin existed, it just lived in an untyped place where no build could see it.

vendor/CultLib is now a submodule pinned at exactly 5cefa0db, the commit
the manifest already used, so this change is purely structural: the
dependency does not move. Bumping to a current CultLib is a separate
change, and should be, or a failure could not be attributed.

This also uncovered that the build was never reproducible from a clean
checkout. The sibling directory had dist/ present because someone had
built it by hand at some point; a fresh CultLib clone has none, and the
packages' main/types point straight at dist/. Building Heimdall against a
fresh CultLib fails with thirteen TS2307s. The manifest knew -- it runs
npm ci then npm run build for cultcache-ts, cultnet-ts and cultmesh-ts
before touching Heimdall -- but that knowledge lived only in the shell
script. It belongs in the recipe's steps, which is where it goes next.

Verified end to end on a fresh submodule clone: the three CultLib packages
build, pnpm install resolves, tsc exits 0, dist/src/index.js is produced
(the exact path heimdall.service runs), and vitest passes 38 tests in 9
files.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Meta Vens 2026-09-06 00:42:45 +02:00
commit 214ccba85c
4 changed files with 30 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

10
package.json
View file

@ -18,9 +18,9 @@
"dependencies": {
"@fastify/cors": "^11.2.0",
"@msgpack/msgpack": "^3.1.3",
"cultcache-ts": "file:../CultLib/packages/cultcache-ts",
"cultmesh-ts": "file:../CultLib/packages/cultmesh-ts",
"cultnet-ts": "file:../CultLib/packages/cultnet-ts",
"cultcache-ts": "file:vendor/CultLib/packages/cultcache-ts",
"cultmesh-ts": "file:vendor/CultLib/packages/cultmesh-ts",
"cultnet-ts": "file:vendor/CultLib/packages/cultnet-ts",
"fastify": "^5.8.5",
"pg": "^8.20.0",
"zod": "^3.25.76"
@ -35,8 +35,8 @@
},
"pnpm": {
"overrides": {
"cultcache-ts": "file:../CultLib/packages/cultcache-ts",
"cultnet-ts": "file:../CultLib/packages/cultnet-ts"
"cultcache-ts": "file:vendor/CultLib/packages/cultcache-ts",
"cultnet-ts": "file:vendor/CultLib/packages/cultnet-ts"
}
}
}