From f8738eea51887b2d70b317d6e1dee7b7a4f021b2 Mon Sep 17 00:00:00 2001 From: Meta Vens Date: Wed, 13 May 2026 19:53:23 +0100 Subject: [PATCH] Remove Codex Apps connector readiness loop --- notes/fresh-workspace-handoff.md | 7 +++++++ state/ledgers.msgpack | Bin 104038 -> 104358 bytes state/map.yaml | 8 ++++++-- vendor/codex/codex-rs/core/src/connectors.rs | 3 --- vendor/codex/codex-rs/tui/src/chatwidget.rs | 13 ++----------- 5 files changed, 15 insertions(+), 16 deletions(-) diff --git a/notes/fresh-workspace-handoff.md b/notes/fresh-workspace-handoff.md index 0bc75579..184d2ebf 100644 --- a/notes/fresh-workspace-handoff.md +++ b/notes/fresh-workspace-handoff.md @@ -826,6 +826,13 @@ stale MCP tests for the deleted Codex Apps cache/startup snapshot/provenance path were removed. If attribution returns, it belongs in an Epiphany-owned typed adapter receipt, not as universal connector state. +The Codex Apps readiness flag is gone as well. `AccessibleConnectorsStatus` no +longer carries `codex_apps_ready`, the TUI no longer schedules a second forced +connector fetch waiting for a deleted app cache, and `connectors_enabled()` is +hard-off. Connector listing remains an inert compatibility stub until the whole +app connector surface is deleted or replaced by an Epiphany-owned typed MCP +adapter. + That husk has now been cut from `codex-core`. The root core crate no longer exports `plugins`, no longer depends on `codex-core-plugins` or `codex-plugin`, and the core plugin manager / marketplace add-remove-sync modules and tests diff --git a/state/ledgers.msgpack b/state/ledgers.msgpack index 7f308b2b5e60fc8533b2682455312891696f125f..0bc8a33f67e7f34ab507ffe9b537298dc34e9e62 100644 GIT binary patch delta 287 zcmYk%u}T9$5C&k@BGzJQGazDNF5D$VVQ+ViTe$2VJ99xR1z$igcyC}O zh#=Uc@KtPl4)-LY_5A-gGhffWrS75EG?B z$>bGgzbU$4$qfxur_W{3=be7t2QCq&muKftIIlu^qe10d-3Mtkl+x=+8+l, - pub codex_apps_ready: bool, } pub async fn list_accessible_connectors_from_mcp_tools( @@ -51,7 +50,6 @@ pub async fn list_accessible_connectors_from_mcp_tools_with_options_and_status( ) -> anyhow::Result { Ok(AccessibleConnectorsStatus { connectors: Vec::new(), - codex_apps_ready: true, }) } @@ -62,7 +60,6 @@ pub async fn list_accessible_connectors_from_mcp_tools_with_environment_manager( ) -> anyhow::Result { Ok(AccessibleConnectorsStatus { connectors: Vec::new(), - codex_apps_ready: true, }) } diff --git a/vendor/codex/codex-rs/tui/src/chatwidget.rs b/vendor/codex/codex-rs/tui/src/chatwidget.rs index b14d2bb8..02541b3a 100644 --- a/vendor/codex/codex-rs/tui/src/chatwidget.rs +++ b/vendor/codex/codex-rs/tui/src/chatwidget.rs @@ -61,6 +61,7 @@ use crate::legacy_core::DEFAULT_AGENTS_MD_FILENAME; use crate::legacy_core::config::Config; use crate::legacy_core::config::Constrained; use crate::legacy_core::config::ConstraintResult; +use crate::legacy_core::connectors; #[cfg(target_os = "windows")] use crate::legacy_core::windows_sandbox::WindowsSandboxLevelExt; use crate::mention_codec::LinkedMention; @@ -105,7 +106,6 @@ use codex_app_server_protocol::Turn; use codex_app_server_protocol::TurnCompletedNotification; use codex_app_server_protocol::TurnPlanStepStatus; use codex_app_server_protocol::TurnStatus; -use crate::legacy_core::connectors; use codex_config::ConfigLayerStackOrdering; use codex_config::types::ApprovalsReviewer; use codex_config::types::Notifications; @@ -7773,8 +7773,6 @@ impl ChatWidget { return; } }; - let should_schedule_force_refetch = - !force_refetch && !accessible_result.codex_apps_ready; let accessible_connectors = accessible_result.connectors; app_event_tx.send(AppEvent::ConnectorsLoaded { @@ -7801,12 +7799,6 @@ impl ChatWidget { result, is_final: true, }); - - if should_schedule_force_refetch { - app_event_tx.send(AppEvent::RefreshConnectors { - force_refetch: true, - }); - } }); } @@ -10184,7 +10176,7 @@ impl ChatWidget { } fn connectors_enabled(&self) -> bool { - self.config.features.enabled(Feature::Apps) && self.has_chatgpt_account + false } fn connectors_for_mentions(&self) -> Option<&[AppInfo]> { @@ -10917,7 +10909,6 @@ impl ChatWidget { self.bottom_pane.set_connectors_snapshot(Some(snapshot)); } - pub(crate) fn open_review_popup(&mut self) { let mut items: Vec = Vec::new();