Extract Epiphany result projection from Codex processor
This commit is contained in:
parent
63373aa420
commit
e783f88789
7 changed files with 299 additions and 278 deletions
|
|
@ -407,9 +407,12 @@ they were not enough to make the Codex organ materially smaller. The first real
|
|||
carcass cut has now moved Epiphany launch doctrine, prompt config, launch
|
||||
request builders, output schemas, binding ids, and launch-specific labels into
|
||||
`vendor/codex/codex-rs/app-server/src/epiphany_launch.rs`. The processor is
|
||||
down from about 21,263 lines to 20,596 lines. This is progress, not absolution:
|
||||
handlers, mappers, route orchestration, result projection, coordinator glue,
|
||||
and tests still keep too much Epiphany inside Codex.
|
||||
down from about 21,263 lines to 20,596 lines. The second cut moved role/reorient
|
||||
result projection and note rendering into
|
||||
`vendor/codex/codex-rs/app-server/src/epiphany_results.rs`, taking the processor
|
||||
to about 20,331 lines. This is progress, not absolution: handlers, scene/view
|
||||
mappers, route orchestration, coordinator glue, accept policy plumbing, and
|
||||
tests still keep too much Epiphany inside Codex.
|
||||
|
||||
Also: MCP itself is allowed to be JSON. The target is not "replace MCP JSON";
|
||||
the target is an Epiphany-owned boundary that speaks typed Epiphany
|
||||
|
|
|
|||
|
|
@ -62,6 +62,6 @@ Rule: JSON is allowed at external schema/wire boundaries. Inside Epiphany, live
|
|||
3. Done: replace role `statePatch` JSON with typed map/planning/graph patch documents. `EpiphanyRoleFindingInterpretation` now carries `EpiphanyRoleStatePatchDocument`; app-server maps it to the legacy protocol patch without JSON round-tripping.
|
||||
4. Done: replace runtime job result JSON projections. Runtime-spine results now project through typed role/reorient interpreters instead of `runtime_job_result_to_role_json` and `runtime_job_result_to_reorient_json`.
|
||||
5. Done: replace app-server launch protocol `input_json` / `output_schema_json` with typed launch documents and `output_contract_id`.
|
||||
6. Continue the whale-carcass cut: the first cut moved Epiphany launch doctrine into `epiphany_launch.rs` and reduced `codex_message_processor.rs` from about 21,263 to 20,596 lines. Next move route handlers, result/projection mappers, coordinator glue, and policy-shaped code out of the processor; success means the processor keeps shrinking and ownership gets clearer, not merely better typed.
|
||||
6. Continue the whale-carcass cut: the first cut moved Epiphany launch doctrine into `epiphany_launch.rs`, and the second moved role/reorient result projection into `epiphany_results.rs`, reducing `codex_message_processor.rs` from about 21,263 to 20,331 lines. Next move route handlers, scene/view projection mappers, coordinator glue, and policy-shaped code out of the processor; success means the processor keeps shrinking and ownership gets clearer, not merely better typed.
|
||||
7. Seal MCP payloads behind an Epiphany boundary that speaks typed Epiphany documents internally and MCP JSON externally.
|
||||
8. Audit heartbeat cognition values and either type them or explicitly expire them.
|
||||
|
|
|
|||
Binary file not shown.
|
|
@ -278,5 +278,5 @@ rejected_paths:
|
|||
reason: making Epiphany cleaner inside Codex still preserves the wrong organ; Codex must be starved down to OpenAI subscription auth/model transport, while Epiphany data and subsystem communication move to typed CultCache/CultNet.
|
||||
|
||||
current_status:
|
||||
summary: The Codex starvation pass has five typing receipts plus the first real carcass cut: Epiphany launch doctrine, prompt config, launch request builders, output schemas, binding ids, and launch-specific labels moved from `vendor/codex/codex-rs/app-server/src/codex_message_processor.rs` into `vendor/codex/codex-rs/app-server/src/epiphany_launch.rs`. The processor is down from about 21,263 lines to 20,596 lines. This is progress, not absolution: handlers, mappers, route orchestration, result projection, coordinator glue, and tests still keep too much Epiphany inside Codex. MCP itself is correctly JSON at its protocol edge; the target is typed Epiphany intent/result/receipt wrappers around MCP, not replacing MCP JSON.
|
||||
next_action: Continue the actual whale-carcass cut: extract Epiphany route handlers and result/projection mappers out of `codex_message_processor.rs` into Epiphany-owned app-server modules, moving logic further into `epiphany-core` whenever it owns real policy. Success metric remains a visibly smaller processor and clearer ownership, not merely typed payloads.
|
||||
summary: The Codex starvation pass has five typing receipts plus two real carcass cuts: Epiphany launch doctrine/prompt/builders moved into `vendor/codex/codex-rs/app-server/src/epiphany_launch.rs`, and role/reorient result projection/note rendering moved into `vendor/codex/codex-rs/app-server/src/epiphany_results.rs`. The processor is down from about 21,263 lines to 20,331 lines. This is progress, not absolution: route handlers, scene/view mappers, coordinator glue, accept policy plumbing, and tests still keep too much Epiphany inside Codex. MCP itself is correctly JSON at its protocol edge; the target is typed Epiphany intent/result/receipt wrappers around MCP, not replacing MCP JSON.
|
||||
next_action: Continue the actual whale-carcass cut: extract Epiphany route handlers, scene/view projection mappers, coordinator glue, and remaining policy-shaped code out of `codex_message_processor.rs` into Epiphany-owned app-server modules, moving logic further into `epiphany-core` whenever it owns real policy. Success metric remains a visibly smaller processor and clearer ownership, not merely typed payloads.
|
||||
|
|
|
|||
|
|
@ -24,6 +24,13 @@ use crate::epiphany_launch::epiphany_role_launch_output_schema;
|
|||
use crate::epiphany_launch::epiphany_specialist_prompt_config;
|
||||
use crate::epiphany_launch::pressure_level_label;
|
||||
use crate::epiphany_launch::render_epiphany_coordinator_note;
|
||||
use crate::epiphany_results::map_core_role_result_role_id;
|
||||
use crate::epiphany_results::map_epiphany_reorient_finding;
|
||||
use crate::epiphany_results::map_epiphany_role_finding;
|
||||
use crate::epiphany_results::map_protocol_reorient_finding;
|
||||
use crate::epiphany_results::map_protocol_role_finding;
|
||||
use crate::epiphany_results::render_epiphany_reorient_result_note;
|
||||
use crate::epiphany_results::render_epiphany_role_result_note;
|
||||
use crate::error_code::INPUT_TOO_LARGE_ERROR_CODE;
|
||||
use crate::error_code::INTERNAL_ERROR_CODE;
|
||||
use crate::error_code::INVALID_PARAMS_ERROR_CODE;
|
||||
|
|
@ -245,7 +252,6 @@ use codex_app_server_protocol::ThreadEpiphanyRoleLaunchResponse;
|
|||
use codex_app_server_protocol::ThreadEpiphanyRoleResultParams;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleResultResponse;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleResultStatus;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleSelfPersistenceReview;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleSelfPersistenceStatus;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleStatus;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleWorkerLaunchDocument;
|
||||
|
|
@ -565,7 +571,6 @@ use epiphany_core::EpiphanyPressureStatus as CoreEpiphanyPressureStatus;
|
|||
use epiphany_core::EpiphanyReorientAcceptanceFinding;
|
||||
use epiphany_core::EpiphanyReorientAction as CoreEpiphanyReorientAction;
|
||||
use epiphany_core::EpiphanyReorientCheckpointStatus as CoreEpiphanyReorientCheckpointStatus;
|
||||
use epiphany_core::EpiphanyReorientFindingInterpretation;
|
||||
use epiphany_core::EpiphanyReorientFreshnessStatus as CoreEpiphanyReorientFreshnessStatus;
|
||||
use epiphany_core::EpiphanyReorientInput;
|
||||
use epiphany_core::EpiphanyReorientPressureLevel as CoreEpiphanyReorientPressureLevel;
|
||||
|
|
@ -581,10 +586,6 @@ use epiphany_core::EpiphanyRoleBoardJob;
|
|||
use epiphany_core::EpiphanyRoleBoardJobStatus;
|
||||
use epiphany_core::EpiphanyRoleBoardLane;
|
||||
use epiphany_core::EpiphanyRoleBoardPlanningSummary;
|
||||
use epiphany_core::EpiphanyRoleFindingInterpretation;
|
||||
use epiphany_core::EpiphanyRoleResultRoleId;
|
||||
use epiphany_core::EpiphanyRoleSelfPersistenceReview as CoreEpiphanyRoleSelfPersistenceReview;
|
||||
use epiphany_core::EpiphanyRoleSelfPersistenceStatus as CoreEpiphanyRoleSelfPersistenceStatus;
|
||||
use epiphany_core::EpiphanyRoleStatePatchDocument;
|
||||
use epiphany_core::EpiphanyRoleWorkerLaunchDocument;
|
||||
use epiphany_core::EpiphanyRuntimeJobSnapshot;
|
||||
|
|
@ -615,9 +616,7 @@ use epiphany_core::derive_pressure_view;
|
|||
use epiphany_core::derive_role_board;
|
||||
use epiphany_core::derive_scene;
|
||||
use epiphany_core::imagination_role_state_patch_policy_errors;
|
||||
use epiphany_core::interpret_reorient_finding;
|
||||
use epiphany_core::interpret_reorient_runtime_job_result;
|
||||
use epiphany_core::interpret_role_finding;
|
||||
use epiphany_core::interpret_role_runtime_job_result;
|
||||
use epiphany_core::modeling_role_state_patch_policy_errors;
|
||||
use epiphany_core::recommend_coordinator_action;
|
||||
|
|
@ -12732,109 +12731,6 @@ fn map_core_epiphany_scene_churn(churn: CoreEpiphanySceneChurn) -> ThreadEpiphan
|
|||
}
|
||||
}
|
||||
|
||||
fn map_epiphany_reorient_finding(
|
||||
raw_result: serde_json::Value,
|
||||
job_error: Option<String>,
|
||||
item_error: Option<String>,
|
||||
) -> ThreadEpiphanyReorientFinding {
|
||||
map_protocol_reorient_finding(interpret_reorient_finding(
|
||||
&raw_result,
|
||||
job_error,
|
||||
item_error,
|
||||
))
|
||||
}
|
||||
|
||||
fn map_protocol_reorient_finding(
|
||||
finding: EpiphanyReorientFindingInterpretation,
|
||||
) -> ThreadEpiphanyReorientFinding {
|
||||
ThreadEpiphanyReorientFinding {
|
||||
mode: finding.mode,
|
||||
summary: finding.summary,
|
||||
next_safe_move: finding.next_safe_move,
|
||||
checkpoint_still_valid: finding.checkpoint_still_valid,
|
||||
files_inspected: finding.files_inspected,
|
||||
frontier_node_ids: finding.frontier_node_ids,
|
||||
evidence_ids: finding.evidence_ids,
|
||||
artifact_refs: finding.artifact_refs,
|
||||
runtime_result_id: finding.runtime_result_id,
|
||||
runtime_job_id: finding.runtime_job_id,
|
||||
job_error: finding.job_error,
|
||||
item_error: finding.item_error,
|
||||
}
|
||||
}
|
||||
|
||||
fn map_epiphany_role_finding(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
raw_result: serde_json::Value,
|
||||
job_error: Option<String>,
|
||||
item_error: Option<String>,
|
||||
) -> ThreadEpiphanyRoleFinding {
|
||||
let finding = interpret_role_finding(
|
||||
map_core_role_result_role_id(role_id),
|
||||
&raw_result,
|
||||
None,
|
||||
job_error,
|
||||
item_error,
|
||||
);
|
||||
map_protocol_role_finding(role_id, finding)
|
||||
}
|
||||
|
||||
fn map_protocol_role_finding(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
finding: EpiphanyRoleFindingInterpretation,
|
||||
) -> ThreadEpiphanyRoleFinding {
|
||||
let state_patch = finding.state_patch.map(map_protocol_update_patch);
|
||||
ThreadEpiphanyRoleFinding {
|
||||
role_id,
|
||||
verdict: finding.verdict,
|
||||
summary: finding.summary,
|
||||
next_safe_move: finding.next_safe_move,
|
||||
checkpoint_summary: finding.checkpoint_summary,
|
||||
scratch_summary: finding.scratch_summary,
|
||||
files_inspected: finding.files_inspected,
|
||||
frontier_node_ids: finding.frontier_node_ids,
|
||||
evidence_ids: finding.evidence_ids,
|
||||
artifact_refs: finding.artifact_refs,
|
||||
runtime_result_id: finding.runtime_result_id,
|
||||
runtime_job_id: finding.runtime_job_id,
|
||||
open_questions: finding.open_questions,
|
||||
evidence_gaps: finding.evidence_gaps,
|
||||
risks: finding.risks,
|
||||
state_patch,
|
||||
self_patch: finding.self_patch.map(|patch| {
|
||||
serde_json::to_value(patch)
|
||||
.expect("AgentSelfPatch is a serializable protocol projection")
|
||||
}),
|
||||
self_persistence: finding
|
||||
.self_persistence
|
||||
.map(map_protocol_role_self_persistence_review),
|
||||
job_error: finding.job_error,
|
||||
item_error: finding.item_error,
|
||||
}
|
||||
}
|
||||
|
||||
fn map_protocol_update_patch(patch: EpiphanyRoleStatePatchDocument) -> ThreadEpiphanyUpdatePatch {
|
||||
ThreadEpiphanyUpdatePatch {
|
||||
objective: patch.objective,
|
||||
active_subgoal_id: patch.active_subgoal_id,
|
||||
subgoals: patch.subgoals,
|
||||
invariants: patch.invariants,
|
||||
graphs: patch.graphs,
|
||||
graph_frontier: patch.graph_frontier,
|
||||
graph_checkpoint: patch.graph_checkpoint,
|
||||
scratch: patch.scratch,
|
||||
investigation_checkpoint: patch.investigation_checkpoint,
|
||||
job_bindings: patch.job_bindings,
|
||||
acceptance_receipts: patch.acceptance_receipts,
|
||||
runtime_links: patch.runtime_links,
|
||||
observations: patch.observations,
|
||||
evidence: patch.evidence,
|
||||
churn: patch.churn,
|
||||
mode: patch.mode,
|
||||
planning: patch.planning,
|
||||
}
|
||||
}
|
||||
|
||||
fn map_core_worker_launch_document(
|
||||
document: ThreadEpiphanyWorkerLaunchDocument,
|
||||
) -> EpiphanyWorkerLaunchDocument {
|
||||
|
|
@ -12931,37 +12827,6 @@ fn core_state_patch_from_protocol(
|
|||
}
|
||||
}
|
||||
|
||||
fn map_core_role_result_role_id(role_id: ThreadEpiphanyRoleId) -> EpiphanyRoleResultRoleId {
|
||||
match role_id {
|
||||
ThreadEpiphanyRoleId::Implementation => EpiphanyRoleResultRoleId::Implementation,
|
||||
ThreadEpiphanyRoleId::Imagination => EpiphanyRoleResultRoleId::Imagination,
|
||||
ThreadEpiphanyRoleId::Modeling => EpiphanyRoleResultRoleId::Modeling,
|
||||
ThreadEpiphanyRoleId::Verification => EpiphanyRoleResultRoleId::Verification,
|
||||
ThreadEpiphanyRoleId::Reorientation => EpiphanyRoleResultRoleId::Reorientation,
|
||||
}
|
||||
}
|
||||
|
||||
fn map_protocol_role_self_persistence_review(
|
||||
review: CoreEpiphanyRoleSelfPersistenceReview,
|
||||
) -> ThreadEpiphanyRoleSelfPersistenceReview {
|
||||
ThreadEpiphanyRoleSelfPersistenceReview {
|
||||
status: match review.status {
|
||||
CoreEpiphanyRoleSelfPersistenceStatus::Missing => {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Missing
|
||||
}
|
||||
CoreEpiphanyRoleSelfPersistenceStatus::Accepted => {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Accepted
|
||||
}
|
||||
CoreEpiphanyRoleSelfPersistenceStatus::Rejected => {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Rejected
|
||||
}
|
||||
},
|
||||
target_agent_id: review.target_agent_id,
|
||||
target_path: review.target_path,
|
||||
reasons: review.reasons,
|
||||
}
|
||||
}
|
||||
|
||||
fn epiphany_modeling_finding_has_reviewable_state_patch(
|
||||
finding: &ThreadEpiphanyRoleFinding,
|
||||
) -> bool {
|
||||
|
|
@ -12999,136 +12864,6 @@ fn reorient_finding_runtime_job_id(finding: &ThreadEpiphanyReorientFinding) -> O
|
|||
finding.runtime_job_id.clone()
|
||||
}
|
||||
|
||||
fn render_epiphany_role_result_note(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
status: ThreadEpiphanyRoleResultStatus,
|
||||
finding: Option<&ThreadEpiphanyRoleFinding>,
|
||||
item_error: Option<&str>,
|
||||
) -> String {
|
||||
match status {
|
||||
ThreadEpiphanyRoleResultStatus::Completed => {
|
||||
if let Some(finding) = finding {
|
||||
let next = finding.next_safe_move.as_deref().unwrap_or("not supplied");
|
||||
let self_note =
|
||||
render_epiphany_self_persistence_note(finding.self_persistence.as_ref())
|
||||
.map(|note| format!(" {note}"))
|
||||
.unwrap_or_default();
|
||||
if let Some(item_error) = finding.item_error.as_deref().or(item_error) {
|
||||
format!(
|
||||
"{:?} role specialist completed, but the finding needs repair: {item_error}. Next safe move: {next}.{self_note}",
|
||||
role_id
|
||||
)
|
||||
} else {
|
||||
format!(
|
||||
"{:?} role specialist completed. Next safe move: {next}.{self_note}",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
} else {
|
||||
format!(
|
||||
"{:?} role specialist completed, but no structured result was recorded.",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::Failed => item_error
|
||||
.map(|error| format!("{:?} role specialist failed: {error}", role_id))
|
||||
.unwrap_or_else(|| format!("{:?} role specialist failed.", role_id)),
|
||||
ThreadEpiphanyRoleResultStatus::Cancelled => {
|
||||
format!(
|
||||
"{:?} role specialist was cancelled before producing a result.",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::Running => {
|
||||
format!("{:?} role specialist is still running.", role_id)
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::Pending => {
|
||||
format!(
|
||||
"{:?} role specialist has not produced a result yet.",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::MissingState => {
|
||||
"No authoritative Epiphany state exists for this thread.".to_string()
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::MissingBinding => {
|
||||
"No matching Epiphany role specialist binding exists.".to_string()
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::BackendUnavailable => {
|
||||
"The bound runtime backend is unavailable.".to_string()
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::BackendMissing => {
|
||||
"The bound runtime backend job or item is missing.".to_string()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn render_epiphany_self_persistence_note(
|
||||
review: Option<&ThreadEpiphanyRoleSelfPersistenceReview>,
|
||||
) -> Option<String> {
|
||||
let review = review?;
|
||||
match review.status {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Missing => None,
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Accepted => Some(format!(
|
||||
"Self persistence request is acceptable for {}.",
|
||||
review
|
||||
.target_agent_id
|
||||
.as_deref()
|
||||
.unwrap_or("the role memory file")
|
||||
)),
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Rejected => {
|
||||
let reasons = if review.reasons.is_empty() {
|
||||
"no reason recorded".to_string()
|
||||
} else {
|
||||
review.reasons.join("; ")
|
||||
};
|
||||
Some(format!("Self persistence request was refused: {reasons}."))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn render_epiphany_reorient_result_note(
|
||||
status: ThreadEpiphanyReorientResultStatus,
|
||||
finding: Option<&ThreadEpiphanyReorientFinding>,
|
||||
item_error: Option<&str>,
|
||||
) -> String {
|
||||
match status {
|
||||
ThreadEpiphanyReorientResultStatus::Completed => {
|
||||
if let Some(finding) = finding {
|
||||
let next = finding.next_safe_move.as_deref().unwrap_or("not supplied");
|
||||
format!("Reorientation worker completed. Next safe move: {next}")
|
||||
} else {
|
||||
"Reorientation worker completed, but no structured result was recorded.".to_string()
|
||||
}
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::Failed => item_error
|
||||
.map(|error| format!("Reorientation worker failed: {error}"))
|
||||
.unwrap_or_else(|| "Reorientation worker failed.".to_string()),
|
||||
ThreadEpiphanyReorientResultStatus::Cancelled => {
|
||||
"Reorientation worker was cancelled before producing a result.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::Running => {
|
||||
"Reorientation worker is still running.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::Pending => {
|
||||
"Reorientation worker has not produced a result yet.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::MissingState => {
|
||||
"No authoritative Epiphany state exists for this thread.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::MissingBinding => {
|
||||
"No matching Epiphany reorientation worker binding exists.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::BackendUnavailable => {
|
||||
"The bound runtime backend is unavailable.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::BackendMissing => {
|
||||
"The bound runtime backend job or item is missing.".to_string()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn load_epiphany_role_result_from_runtime_spine_job(
|
||||
job_id: &str,
|
||||
runtime_store_path: Option<&Path>,
|
||||
|
|
|
|||
282
vendor/codex/codex-rs/app-server/src/epiphany_results.rs
vendored
Normal file
282
vendor/codex/codex-rs/app-server/src/epiphany_results.rs
vendored
Normal file
|
|
@ -0,0 +1,282 @@
|
|||
use codex_app_server_protocol::ThreadEpiphanyReorientFinding;
|
||||
use codex_app_server_protocol::ThreadEpiphanyReorientResultStatus;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleFinding;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleId;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleResultStatus;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleSelfPersistenceReview;
|
||||
use codex_app_server_protocol::ThreadEpiphanyRoleSelfPersistenceStatus;
|
||||
use codex_app_server_protocol::ThreadEpiphanyUpdatePatch;
|
||||
use epiphany_core::EpiphanyReorientFindingInterpretation;
|
||||
use epiphany_core::EpiphanyRoleFindingInterpretation;
|
||||
use epiphany_core::EpiphanyRoleResultRoleId;
|
||||
use epiphany_core::EpiphanyRoleSelfPersistenceReview as CoreEpiphanyRoleSelfPersistenceReview;
|
||||
use epiphany_core::EpiphanyRoleSelfPersistenceStatus as CoreEpiphanyRoleSelfPersistenceStatus;
|
||||
use epiphany_core::EpiphanyRoleStatePatchDocument;
|
||||
use epiphany_core::interpret_reorient_finding;
|
||||
use epiphany_core::interpret_role_finding;
|
||||
|
||||
pub(super) fn map_epiphany_reorient_finding(
|
||||
raw_result: serde_json::Value,
|
||||
job_error: Option<String>,
|
||||
item_error: Option<String>,
|
||||
) -> ThreadEpiphanyReorientFinding {
|
||||
map_protocol_reorient_finding(interpret_reorient_finding(
|
||||
&raw_result,
|
||||
job_error,
|
||||
item_error,
|
||||
))
|
||||
}
|
||||
|
||||
pub(super) fn map_protocol_reorient_finding(
|
||||
finding: EpiphanyReorientFindingInterpretation,
|
||||
) -> ThreadEpiphanyReorientFinding {
|
||||
ThreadEpiphanyReorientFinding {
|
||||
mode: finding.mode,
|
||||
summary: finding.summary,
|
||||
next_safe_move: finding.next_safe_move,
|
||||
checkpoint_still_valid: finding.checkpoint_still_valid,
|
||||
files_inspected: finding.files_inspected,
|
||||
frontier_node_ids: finding.frontier_node_ids,
|
||||
evidence_ids: finding.evidence_ids,
|
||||
artifact_refs: finding.artifact_refs,
|
||||
runtime_result_id: finding.runtime_result_id,
|
||||
runtime_job_id: finding.runtime_job_id,
|
||||
job_error: finding.job_error,
|
||||
item_error: finding.item_error,
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) fn map_epiphany_role_finding(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
raw_result: serde_json::Value,
|
||||
job_error: Option<String>,
|
||||
item_error: Option<String>,
|
||||
) -> ThreadEpiphanyRoleFinding {
|
||||
let finding = interpret_role_finding(
|
||||
map_core_role_result_role_id(role_id),
|
||||
&raw_result,
|
||||
None,
|
||||
job_error,
|
||||
item_error,
|
||||
);
|
||||
map_protocol_role_finding(role_id, finding)
|
||||
}
|
||||
|
||||
pub(super) fn map_protocol_role_finding(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
finding: EpiphanyRoleFindingInterpretation,
|
||||
) -> ThreadEpiphanyRoleFinding {
|
||||
let state_patch = finding.state_patch.map(map_protocol_update_patch);
|
||||
ThreadEpiphanyRoleFinding {
|
||||
role_id,
|
||||
verdict: finding.verdict,
|
||||
summary: finding.summary,
|
||||
next_safe_move: finding.next_safe_move,
|
||||
checkpoint_summary: finding.checkpoint_summary,
|
||||
scratch_summary: finding.scratch_summary,
|
||||
files_inspected: finding.files_inspected,
|
||||
frontier_node_ids: finding.frontier_node_ids,
|
||||
evidence_ids: finding.evidence_ids,
|
||||
artifact_refs: finding.artifact_refs,
|
||||
runtime_result_id: finding.runtime_result_id,
|
||||
runtime_job_id: finding.runtime_job_id,
|
||||
open_questions: finding.open_questions,
|
||||
evidence_gaps: finding.evidence_gaps,
|
||||
risks: finding.risks,
|
||||
state_patch,
|
||||
self_patch: finding.self_patch.map(|patch| {
|
||||
serde_json::to_value(patch)
|
||||
.expect("AgentSelfPatch is a serializable protocol projection")
|
||||
}),
|
||||
self_persistence: finding
|
||||
.self_persistence
|
||||
.map(map_protocol_role_self_persistence_review),
|
||||
job_error: finding.job_error,
|
||||
item_error: finding.item_error,
|
||||
}
|
||||
}
|
||||
|
||||
fn map_protocol_update_patch(patch: EpiphanyRoleStatePatchDocument) -> ThreadEpiphanyUpdatePatch {
|
||||
ThreadEpiphanyUpdatePatch {
|
||||
objective: patch.objective,
|
||||
active_subgoal_id: patch.active_subgoal_id,
|
||||
subgoals: patch.subgoals,
|
||||
invariants: patch.invariants,
|
||||
graphs: patch.graphs,
|
||||
graph_frontier: patch.graph_frontier,
|
||||
graph_checkpoint: patch.graph_checkpoint,
|
||||
scratch: patch.scratch,
|
||||
investigation_checkpoint: patch.investigation_checkpoint,
|
||||
job_bindings: patch.job_bindings,
|
||||
acceptance_receipts: patch.acceptance_receipts,
|
||||
runtime_links: patch.runtime_links,
|
||||
observations: patch.observations,
|
||||
evidence: patch.evidence,
|
||||
churn: patch.churn,
|
||||
mode: patch.mode,
|
||||
planning: patch.planning,
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) fn map_core_role_result_role_id(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
) -> EpiphanyRoleResultRoleId {
|
||||
match role_id {
|
||||
ThreadEpiphanyRoleId::Implementation => EpiphanyRoleResultRoleId::Implementation,
|
||||
ThreadEpiphanyRoleId::Imagination => EpiphanyRoleResultRoleId::Imagination,
|
||||
ThreadEpiphanyRoleId::Modeling => EpiphanyRoleResultRoleId::Modeling,
|
||||
ThreadEpiphanyRoleId::Verification => EpiphanyRoleResultRoleId::Verification,
|
||||
ThreadEpiphanyRoleId::Reorientation => EpiphanyRoleResultRoleId::Reorientation,
|
||||
}
|
||||
}
|
||||
|
||||
fn map_protocol_role_self_persistence_review(
|
||||
review: CoreEpiphanyRoleSelfPersistenceReview,
|
||||
) -> ThreadEpiphanyRoleSelfPersistenceReview {
|
||||
ThreadEpiphanyRoleSelfPersistenceReview {
|
||||
status: match review.status {
|
||||
CoreEpiphanyRoleSelfPersistenceStatus::Missing => {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Missing
|
||||
}
|
||||
CoreEpiphanyRoleSelfPersistenceStatus::Accepted => {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Accepted
|
||||
}
|
||||
CoreEpiphanyRoleSelfPersistenceStatus::Rejected => {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Rejected
|
||||
}
|
||||
},
|
||||
target_agent_id: review.target_agent_id,
|
||||
target_path: review.target_path,
|
||||
reasons: review.reasons,
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) fn render_epiphany_role_result_note(
|
||||
role_id: ThreadEpiphanyRoleId,
|
||||
status: ThreadEpiphanyRoleResultStatus,
|
||||
finding: Option<&ThreadEpiphanyRoleFinding>,
|
||||
item_error: Option<&str>,
|
||||
) -> String {
|
||||
match status {
|
||||
ThreadEpiphanyRoleResultStatus::Completed => {
|
||||
if let Some(finding) = finding {
|
||||
let next = finding.next_safe_move.as_deref().unwrap_or("not supplied");
|
||||
let self_note =
|
||||
render_epiphany_self_persistence_note(finding.self_persistence.as_ref())
|
||||
.map(|note| format!(" {note}"))
|
||||
.unwrap_or_default();
|
||||
if let Some(item_error) = finding.item_error.as_deref().or(item_error) {
|
||||
format!(
|
||||
"{:?} role specialist completed, but the finding needs repair: {item_error}. Next safe move: {next}.{self_note}",
|
||||
role_id
|
||||
)
|
||||
} else {
|
||||
format!(
|
||||
"{:?} role specialist completed. Next safe move: {next}.{self_note}",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
} else {
|
||||
format!(
|
||||
"{:?} role specialist completed, but no structured result was recorded.",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::Failed => item_error
|
||||
.map(|error| format!("{:?} role specialist failed: {error}", role_id))
|
||||
.unwrap_or_else(|| format!("{:?} role specialist failed.", role_id)),
|
||||
ThreadEpiphanyRoleResultStatus::Cancelled => {
|
||||
format!(
|
||||
"{:?} role specialist was cancelled before producing a result.",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::Running => {
|
||||
format!("{:?} role specialist is still running.", role_id)
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::Pending => {
|
||||
format!(
|
||||
"{:?} role specialist has not produced a result yet.",
|
||||
role_id
|
||||
)
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::MissingState => {
|
||||
"No authoritative Epiphany state exists for this thread.".to_string()
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::MissingBinding => {
|
||||
"No matching Epiphany role specialist binding exists.".to_string()
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::BackendUnavailable => {
|
||||
"The bound runtime backend is unavailable.".to_string()
|
||||
}
|
||||
ThreadEpiphanyRoleResultStatus::BackendMissing => {
|
||||
"The bound runtime backend job or item is missing.".to_string()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn render_epiphany_self_persistence_note(
|
||||
review: Option<&ThreadEpiphanyRoleSelfPersistenceReview>,
|
||||
) -> Option<String> {
|
||||
let review = review?;
|
||||
match review.status {
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Missing => None,
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Accepted => Some(format!(
|
||||
"Self persistence request is acceptable for {}.",
|
||||
review
|
||||
.target_agent_id
|
||||
.as_deref()
|
||||
.unwrap_or("the role memory file")
|
||||
)),
|
||||
ThreadEpiphanyRoleSelfPersistenceStatus::Rejected => {
|
||||
let reasons = if review.reasons.is_empty() {
|
||||
"no reason recorded".to_string()
|
||||
} else {
|
||||
review.reasons.join("; ")
|
||||
};
|
||||
Some(format!("Self persistence request was refused: {reasons}."))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub(super) fn render_epiphany_reorient_result_note(
|
||||
status: ThreadEpiphanyReorientResultStatus,
|
||||
finding: Option<&ThreadEpiphanyReorientFinding>,
|
||||
item_error: Option<&str>,
|
||||
) -> String {
|
||||
match status {
|
||||
ThreadEpiphanyReorientResultStatus::Completed => {
|
||||
if let Some(finding) = finding {
|
||||
let next = finding.next_safe_move.as_deref().unwrap_or("not supplied");
|
||||
format!("Reorientation worker completed. Next safe move: {next}")
|
||||
} else {
|
||||
"Reorientation worker completed, but no structured result was recorded.".to_string()
|
||||
}
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::Failed => item_error
|
||||
.map(|error| format!("Reorientation worker failed: {error}"))
|
||||
.unwrap_or_else(|| "Reorientation worker failed.".to_string()),
|
||||
ThreadEpiphanyReorientResultStatus::Cancelled => {
|
||||
"Reorientation worker was cancelled before producing a result.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::Running => {
|
||||
"Reorientation worker is still running.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::Pending => {
|
||||
"Reorientation worker has not produced a result yet.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::MissingState => {
|
||||
"No authoritative Epiphany state exists for this thread.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::MissingBinding => {
|
||||
"No matching Epiphany reorientation worker binding exists.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::BackendUnavailable => {
|
||||
"The bound runtime backend is unavailable.".to_string()
|
||||
}
|
||||
ThreadEpiphanyReorientResultStatus::BackendMissing => {
|
||||
"The bound runtime backend job or item is missing.".to_string()
|
||||
}
|
||||
}
|
||||
}
|
||||
1
vendor/codex/codex-rs/app-server/src/lib.rs
vendored
1
vendor/codex/codex-rs/app-server/src/lib.rs
vendored
|
|
@ -77,6 +77,7 @@ mod device_key_api;
|
|||
mod dynamic_tools;
|
||||
mod epiphany_invalidation;
|
||||
mod epiphany_launch;
|
||||
mod epiphany_results;
|
||||
mod error_code;
|
||||
mod external_agent_config_api;
|
||||
mod filters;
|
||||
|
|
|
|||
Reference in a new issue