diff --git a/epiphany-core/src/bin/epiphany-work.rs b/epiphany-core/src/bin/epiphany-work.rs index c0ceef59..1614ef68 100644 --- a/epiphany-core/src/bin/epiphany-work.rs +++ b/epiphany-core/src/bin/epiphany-work.rs @@ -7797,103 +7797,75 @@ fn closure_family_assertions( ); } "repo.maintainer_review_request" => { + let request = parse_repo_maintainer_review_request(&content).ok(); push_assertion( &mut assertions, "maintainer-review-request-schema-present", - content.contains("schema_version = \"epiphany.repo_maintainer_review_request.v0\""), + request + .as_ref() + .is_some_and(RepoMaintainerReviewRequest::has_canonical_identity), "Committed maintainer review request carries the schema version.".to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-family-present", - content.contains("safe_action_family = \"repo.maintainer_review_request\""), + request + .as_ref() + .is_some_and(RepoMaintainerReviewRequest::has_canonical_identity), "Committed maintainer review request carries the safe action family.".to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-summary-present", - content.contains(&compact_summary), + request + .as_ref() + .is_some_and(|request| request.summary == compact_summary), "Committed maintainer review request contains the accepted pressure summary." .to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-awaits-review", - content.contains("[request]") - && content.contains("status = \"awaiting-maintainer-review\"") - && content.contains("requested_owner = \"Maintainer\"") - && content - .contains("requested_effect = \"review-redacted-proof-and-branch-diff\"") - && content.contains("verification_request_ref = ") - && content.contains("publication_request_ref = "), + request + .as_ref() + .is_some_and(RepoMaintainerReviewRequest::awaits_review), "Committed maintainer review request waits for human review before consequence." .to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-antecedents-present", - content.contains("[antecedents]") - && content.contains("closure_review_required = true") - && content.contains("soul_verdict_required = true") - && content.contains("mind_commit_required = true") - && content.contains("public_proof_required = true") - && content.contains("bifrost_publication_request_required = true"), + request.as_ref().is_some_and(RepoMaintainerReviewRequest::has_antecedent_contract), "Committed maintainer review request requires closure, Soul, Mind, proof, and Bifrost request antecedents." .to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-receipt-contract", - content.contains("[required_receipts]") - && content.contains( - "closure_review = \"epiphany.repo_work_closure_review.v0\"", - ) - && content.contains( - "soul_verdict = \"epiphany.soul.verification_verdict\"", - ) - && content.contains("mind_commit = \"epiphany.mind.state_commit_receipt\"") - && content.contains( - "public_proof = \"epiphany.repo_work_public_proof_bundle.v0\"", - ) - && content.contains( - "maintainer_review = \"gamecult.maintainer.review_receipt.v0\"", - ) - && content.contains("bifrost_publication = \"gamecult.bifrost.public_proof_publication_receipt.v0\""), + request.as_ref().is_some_and(RepoMaintainerReviewRequest::has_receipt_contract), "Committed maintainer review request names closure, proof, maintainer, and Bifrost receipts." .to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-review-packet", - content.contains("[review_packet]") - && content.contains("requires_reviewer_identity = true") - && content.contains("requires_review_verdict = true") - && content.contains("allowed_verdicts = [\"approved\", \"changes-requested\", \"rejected\", \"needs-human-context\"]") - && content.contains("requires_changed_path_list = true") - && content.contains("requires_public_proof_ref = true") - && content.contains("requires_private_state_redaction_check = true"), + request.as_ref().is_some_and(RepoMaintainerReviewRequest::has_review_packet), "Committed maintainer review request names reviewer identity, verdict, changed path, proof, and redaction requirements." .to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-authority-seals", - content.contains("[authority]") - && content.contains("maintainer_approval_authorized = false") - && content.contains("merge_authorized = false") - && content.contains("push_authorized = false") - && content.contains("publication_authorized = false") - && content.contains("upstream_sync_authorized = false") - && content.contains("hands_action_authorized = false") - && content.contains("cross_body_mutation_authorized = false") - && content.contains("human_or_maintainer_response_required = true"), + request.as_ref().is_some_and(RepoMaintainerReviewRequest::has_authority_seals), "Committed maintainer review request denies approval/merge/push/publication/sync/action/cross-body authority." .to_string(), ); push_assertion( &mut assertions, "maintainer-review-request-private-seal", - content.contains("private_state_exposed = false"), + request + .as_ref() + .is_some_and(|request| !request.private_state_exposed), "Committed maintainer review request preserves the private-state seal.".to_string(), ); } @@ -15422,6 +15394,7 @@ idunn_deployment_authority_required = true "repo.publication_request", "repo.sync_request", "repo.pr_request", + "repo.maintainer_review_request", "repo.credit_request", "repo.artifact_acceptance_request", "repo.metrics_request", diff --git a/epiphany-core/src/bin/epiphany_work/closure_contracts/external_governance.rs b/epiphany-core/src/bin/epiphany_work/closure_contracts/external_governance.rs index 1802adc8..15bb8286 100644 --- a/epiphany-core/src/bin/epiphany_work/closure_contracts/external_governance.rs +++ b/epiphany-core/src/bin/epiphany_work/closure_contracts/external_governance.rs @@ -687,4 +687,21 @@ impl RepoPrRequest { #[derive(Debug,Deserialize)] struct RepoPrAuthority{branch_local_only:bool,github_pr_authorized:bool,branch_push_authorized:bool,merge_authorized:bool,publication_authorized:bool,upstream_sync_authorized:bool,hands_action_authorized:bool,service_lifecycle_authority:bool,cross_body_mutation_authorized:bool,private_verse_rummaging:bool,bifrost_or_maintainer_authority_required:bool} pub(super) fn parse_repo_pr_request(text:&str)->Result{toml::from_str(text).context("PR request is not valid typed TOML")} +#[derive(Debug,Deserialize)] +pub(super) struct RepoMaintainerReviewRequest{pub(super) schema_version:String,pub(super) safe_action_family:String,pub(super) summary:String,pub(super) private_state_exposed:bool,request:RepoMaintainerReviewBody,antecedents:RepoMaintainerReviewAntecedents,required_receipts:RepoMaintainerReviewReceipts,review_packet:RepoMaintainerReviewPacket,authority:RepoMaintainerReviewAuthority} +impl RepoMaintainerReviewRequest{ +pub(super) fn has_canonical_identity(&self)->bool{self.schema_version=="epiphany.repo_maintainer_review_request.v0"&&self.safe_action_family=="repo.maintainer_review_request"} +pub(super) fn awaits_review(&self)->bool{let r=&self.request;r.status=="awaiting-maintainer-review"&&r.requested_owner=="Maintainer"&&r.requested_effect=="review-redacted-proof-and-branch-diff"&&!r.verification_request_ref.is_empty()&&!r.publication_request_ref.is_empty()} +pub(super) fn has_antecedent_contract(&self)->bool{let a=&self.antecedents;a.closure_review_required&&a.soul_verdict_required&&a.mind_commit_required&&a.public_proof_required&&a.bifrost_publication_request_required} +pub(super) fn has_receipt_contract(&self)->bool{let r=&self.required_receipts;r.closure_review=="epiphany.repo_work_closure_review.v0"&&r.soul_verdict=="epiphany.soul.verification_verdict"&&r.mind_commit=="epiphany.mind.state_commit_receipt"&&r.public_proof=="epiphany.repo_work_public_proof_bundle.v0"&&r.maintainer_review=="gamecult.maintainer.review_receipt.v0"&&r.bifrost_publication=="gamecult.bifrost.public_proof_publication_receipt.v0"} +pub(super) fn has_review_packet(&self)->bool{let p=&self.review_packet;p.requires_reviewer_identity&&p.requires_review_verdict&&p.allowed_verdicts==["approved","changes-requested","rejected","needs-human-context"]&&p.requires_changed_path_list&&p.requires_public_proof_ref&&p.requires_private_state_redaction_check} +pub(super) fn has_authority_seals(&self)->bool{let a=&self.authority;a.branch_local_only&&!a.maintainer_approval_authorized&&!a.merge_authorized&&!a.push_authorized&&!a.publication_authorized&&!a.upstream_sync_authorized&&!a.hands_action_authorized&&!a.service_lifecycle_authority&&!a.cross_body_mutation_authorized&&!a.private_verse_rummaging&&a.human_or_maintainer_response_required} +} +#[derive(Debug,Deserialize)]struct RepoMaintainerReviewBody{status:String,requested_owner:String,requested_effect:String,verification_request_ref:String,publication_request_ref:String} +#[derive(Debug,Deserialize)]struct RepoMaintainerReviewAntecedents{closure_review_required:bool,soul_verdict_required:bool,mind_commit_required:bool,public_proof_required:bool,bifrost_publication_request_required:bool} +#[derive(Debug,Deserialize)]struct RepoMaintainerReviewReceipts{closure_review:String,soul_verdict:String,mind_commit:String,public_proof:String,maintainer_review:String,bifrost_publication:String} +#[derive(Debug,Deserialize)]struct RepoMaintainerReviewPacket{requires_reviewer_identity:bool,requires_review_verdict:bool,allowed_verdicts:Vec,requires_changed_path_list:bool,requires_public_proof_ref:bool,requires_private_state_redaction_check:bool} +#[derive(Debug,Deserialize)]struct RepoMaintainerReviewAuthority{branch_local_only:bool,maintainer_approval_authorized:bool,merge_authorized:bool,push_authorized:bool,publication_authorized:bool,upstream_sync_authorized:bool,hands_action_authorized:bool,service_lifecycle_authority:bool,cross_body_mutation_authorized:bool,private_verse_rummaging:bool,human_or_maintainer_response_required:bool} +pub(super) fn parse_repo_maintainer_review_request(text:&str)->Result{toml::from_str(text).context("maintainer review request is not valid typed TOML")} + include!("external_governance_tests.rs"); diff --git a/notes/conceptual-substitution-audit-2026-07-12.md b/notes/conceptual-substitution-audit-2026-07-12.md index 9c32c717..dd00efe3 100644 --- a/notes/conceptual-substitution-audit-2026-07-12.md +++ b/notes/conceptual-substitution-audit-2026-07-12.md @@ -977,6 +977,16 @@ A malicious typed fixture separately proves that commented Eleven high-authority closure families are now typed; 620 substring assertions remain in the measured closure region. +## Maintainer-review prose substituted for human judgment + +`repo.maintainer_review_request` closure now parses exact typed request, +antecedent, receipt, allowed-verdict, review-packet, and authority semantics. +Maintainer/human judgment remains the consequence owner; Soul, Mind, and +Bifrost receipts remain prerequisites rather than approval substitutes. The +class guard prevents substring fallback. + +Twelve high-authority families are now typed; 582 substring assertions remain. + The same inspection found 33 consecutive duplicate `#[cfg(test)]` attributes on provider constructors/writers and their re-exports. One gate already makes each item test-only; the second owned nothing. The duplicates are removed. diff --git a/notes/fresh-workspace-handoff.md b/notes/fresh-workspace-handoff.md index eac1b6a3..e5525584 100644 --- a/notes/fresh-workspace-handoff.md +++ b/notes/fresh-workspace-handoff.md @@ -304,6 +304,10 @@ class no-substring guard plus an explicit malicious GitHub-grant fixture. Current count: eleven typed high-authority families and 620 remaining closure substring assertions. +Maintainer-review closure is now typed and class-guarded. Current count: twelve +typed high-authority families and 582 remaining substring assertions. Add the +explicit malicious maintainer-approval fixture next. + The latest structural count is 32 closure family branches, 744 remaining substring assertions in the closure region, and 1,284 lines in `closure_contracts.rs`. Do not blindly generate a struct forest for every diff --git a/state/ledgers.msgpack b/state/ledgers.msgpack index 684b0787..49b94178 100644 Binary files a/state/ledgers.msgpack and b/state/ledgers.msgpack differ diff --git a/state/map.yaml b/state/map.yaml index 2804f7ac..c2aa3814 100644 --- a/state/map.yaml +++ b/state/map.yaml @@ -660,4 +660,4 @@ current_status: - Service lifecycle receipt history is now event-only: `load_epiphany_cultmesh_daemon_service_lifecycle_receipts` filters out the `epiphany-local/daemon-service-lifecycle-receipt/latest` mirror, while `load_latest_epiphany_cultmesh_daemon_service_lifecycle_receipt` remains the latest-state reader. Focused unit test `service_lifecycle_receipt_history_excludes_latest_mirror` proves two per-receipt writes return exactly two history records and latest points at the second. Fresh smoke `verse-query-lifecycle-history-filter-smoke` and live overview/triage `local-20260618-145632-497-efac6f0d` / `local-20260618-145632-321-867947af` prove compact swarm sights still expose service lifecycle attention plus the present elevated runbook artifact without daemon pokes or service mutation. Do not use a broad unscoped cargo test filter for this check on Windows; it fans out across bin harnesses and hit a broken pipe during this pass. - `epiphany-verse-query seed-compact` is the compact seed receipt for wrappers and read-only rites. The older `seed` command still prints the full local Verse context for explicit debugging, but compact wrapper modes now avoid full `seed`/final `query` readback after the combined overview proof exposed Windows debug stack overflow from full-context serialization pressure. last_completed_repo_swarm_cut: Huginn live-fire has crossed the first real repo Body from Persona pressure to branch-local Hands commit and Soul/Mind closure, and now has repeatable closure and redacted-public-proof mouths. On `E:\Projects\Huginn` branch `epiphany/huginn/first-awakening`, `tools/epiphany_local_run.ps1 -Mode repo-persona-intake` accepted item `huginn-inspection-readback-livefire`, Weksa/Persona intake remained sealed, and `epiphany-work derive-plan` lowered it to model-authored safe family `repo.status_section` for `README.md` only. `tools/epiphany_local_run.ps1 -Mode repo-swarm-run` advanced four bounded pulses: run-from-plan, adopt-from-plan, execute-from-plan, and close-from-execute. Huginn commit `e9b07c38fceabbdc89ea35c2156326c80c0393a2` updated only `README.md`; closure receipt `.epiphany\work\work-close-huginn-inspection-readback-livefire.json` records status `closed`, Soul verdict `passed`, Mind state commit `repo-work-close-huginn-inspection-readback-livefire-mind-commit`, safe family `repo.status_section`, path scope `README.md`, Bifrost publication gate, and `privateStateExposed=false`. Verification also ran Huginn's TypeScript compiler through concrete Node path: `C:\Program Files\nodejs\node.exe E:\Projects\Huginn\node_modules\typescript\bin\tsc -p tsconfig.json` passed. Native verifier `epiphany-repo-livefire-closure-smoke --workspace E:\Projects\Huginn --item huginn-inspection-readback-livefire --expected-path README.md --expected-family repo.status_section --expected-gate awaiting-publication --expected-blocker bifrost-publication-missing` checks closure receipt, Mind map entry, overview gate/blocker, authority seals, and `git show` changed paths, returning `status=ok`, `soulVerdict=passed`, `publicationGate=Bifrost`, and `privateStateExposed=false`. Wrapper `tools/epiphany_local_run.ps1 -Mode repo-livefire-closure -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exposes the same read-only proof through the local operator mouth; artifact `local-20260621-190156-803-2f85ba15` printed commit, path, gate, blocker, Soul verdict, Mind commit receipt, and `privateStateExposed=False` without push, merge, publication, or target mutation. New wrapper `tools/epiphany_local_run.ps1 -Mode repo-work-public-proof -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exports the redacted proof bundle and repo-local Verse index without publishing; artifact `local-20260621-190645-345-4555b1dc` wrote `.epiphany\public\proof-bundles\repo-work-public-proof-huginn-inspection-readback-livefire.json`, proof id `repo-work-public-proof-huginn-inspection-readback-livefire`, SHA-256 `857545b199f3e37eb06c2e757e5cfc201958e46667bb1f8403fd333a22620f63`, nine artifact rows, zero publication rows, and `privateStateExposed=False`. swarm overview readback `local-20260621-190701-140-b9519ec6` sees the `REPO-WORK-PUBLIC-PROOF` row and action row from Huginn's repo-local Verse with the same SHA-256 while Bifrost publication remains missing. Launcher compact modes are now named compact operator-context modes instead of read-only modes, and `bifrost-public-proof` summaries print item, target public Verse, room, proof SHA-256, review receipts, and credit receipts so publication receipts are auditable without claiming upstream sync. - next_action: Continue the conceptual-substitution pass. Eleven high-authority closure families, now including PR request, are typed and guarded against regaining substring authority; PR has an explicit malicious GitHub-grant fixture. The closure region still has 32 family branches and 620 substring assertions; closure contracts remain a parent-private lexical facade over external_governance and operations authority domains. Prioritize remaining consequence-bearing request families without building a blind struct forest. Provider chronology is explicitly external: Bifrost receipt contracts lack provider timestamp/revision, so Epiphany mirrors know only arrival order; all Rust/operator vocabulary says arrival latest while exactly seven persisted /latest strings remain under a regression invariant. Continue auditing evidence/security mirrors and adapters for borrowed authority. + next_action: Continue the conceptual-substitution pass. Twelve high-authority closure families, now including maintainer review, are typed and guarded against regaining substring authority. The closure region still has 32 family branches and 582 substring assertions; closure contracts remain a parent-private lexical facade over external_governance and operations authority domains. Add the explicit malicious maintainer-approval fixture next, then prioritize remaining consequence-bearing request families without building a blind struct forest. Provider chronology is explicitly external and guarded as arrival order. Continue auditing evidence/security mirrors and adapters for borrowed authority.