GameCult/Epiphany
Archived
Watch
9
0
Fork
You've already forked Epiphany
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Project reorientation terminal disposition

Browse source
This commit is contained in:
Meta Vens 2026-08-25 01:20:17 +02:00
commit dfe3757bfe
2 changed files with 22 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

14
epiphany-core/src/bin/epiphany-mvp-coordinator.rs
View file

@ -1578,16 +1578,10 @@ fn accept_reorient(runtime_store: &Path) -> Result<Value> {
.attempt
.job_id
.ok_or_else(|| anyhow!("reorientation review lost its runtime job"))?;
let job = epiphany_core::runtime_job(runtime_store, &job_id)?
.ok_or_else(|| anyhow!("reorientation review lost its runtime job"))?;
let accepted = match job.status {
epiphany_core::EpiphanyRuntimeJobStatus::Completed => {
epiphany_core::accept_reorientation_result(runtime_store, &job_id, &now())?
}
epiphany_core::EpiphanyRuntimeJobStatus::Failed => {
epiphany_core::record_reorientation_pass_failure(runtime_store, &job_id)?
}
_ => return Err(anyhow!("reorientation work is not terminally reviewable")),
let accepted = if work.terminal_failure {
epiphany_core::record_reorientation_pass_failure(runtime_store, &job_id)?
} else {
epiphany_core::accept_reorientation_result(runtime_store, &job_id, &now())?
};
Ok(json!({
"mindCommitReceipt": accepted,

23
epiphany-core/src/reorientation_work.rs
View file

@ -105,6 +105,7 @@ pub struct EpiphanyReorientationWorkProjection {
pub request: EpiphanyReorientationRequest,
#[serde(flatten)]
pub attempt: crate::EpiphanyAgentPassAttemptProjection,
pub terminal_failure: bool,
}
pub fn request_current_reorientation(
@ -270,12 +271,14 @@ pub(crate) fn current_reorientation_work(
return Ok(Some(EpiphanyReorientationWorkProjection {
request,
attempt: crate::EpiphanyAgentPassAttemptProjection::unattempted(),
terminal_failure: false,
}));
};
let job = cache
.get::<crate::EpiphanyRuntimeJob>(&launch.job_id)?
.ok_or_else(|| anyhow!("reorientation launch lost its runtime job"))?;
let result = cache.get::<crate::EpiphanyRuntimeReorientWorkerResult>(&launch.job_id)?;
let terminal_failure = job.status == EpiphanyRuntimeJobStatus::Failed;
let action = match job.status {
EpiphanyRuntimeJobStatus::Completed if result.is_some() => {
EpiphanyAgentPassContinuationAction::Review
@ -314,6 +317,7 @@ pub(crate) fn current_reorientation_work(
action,
Some(launch.job_id.clone()),
),
terminal_failure,
}));
}
Ok(None)
@ -1010,6 +1014,14 @@ mod tests {
projected_result.finding.and_then(|finding| finding.mode),
Some("regather".into())
);
let review_work = crate::project_current_work(&store)?
.reorientation
.expect("completed Reorientation work");
assert_eq!(
review_work.attempt.action,
EpiphanyAgentPassContinuationAction::Review
);
assert!(!review_work.terminal_failure);
cache.pull_all_backing_stores()?;
cache.put(
@ -1128,13 +1140,14 @@ mod tests {
"2026-08-18T10:00:14Z",
&model_failure.failure_id,
)?;
let failed_review = crate::project_current_work(&store)?
.reorientation
.expect("failed Reorientation work");
assert_eq!(
crate::project_current_work(&store)?
.reorientation
.as_ref()
.map(|work| work.attempt.action),
Some(EpiphanyAgentPassContinuationAction::Review)
failed_review.attempt.action,
EpiphanyAgentPassContinuationAction::Review
);
assert!(failed_review.terminal_failure);
let failure_receipt = record_reorientation_pass_failure(&store, &failed_job)?;
assert_eq!(
record_reorientation_pass_failure(&store, &failed_job)?,