Type credit request closure semantics
This commit is contained in:
parent
0d8afc94f2
commit
bfbe99fb15
6 changed files with 225 additions and 62 deletions
|
|
@ -8056,112 +8056,74 @@ fn closure_family_assertions(
|
|||
);
|
||||
}
|
||||
"repo.credit_request" => {
|
||||
let request = parse_repo_credit_request(&content).ok();
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-schema-present",
|
||||
content.contains("schema_version = \"epiphany.repo_credit_request.v0\""),
|
||||
request
|
||||
.as_ref()
|
||||
.is_some_and(RepoCreditRequest::has_canonical_identity),
|
||||
"Committed credit request carries the schema version.".to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-family-present",
|
||||
content.contains("safe_action_family = \"repo.credit_request\""),
|
||||
request
|
||||
.as_ref()
|
||||
.is_some_and(RepoCreditRequest::has_canonical_identity),
|
||||
"Committed credit request carries the safe action family.".to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-summary-present",
|
||||
content.contains(&compact_summary),
|
||||
request
|
||||
.as_ref()
|
||||
.is_some_and(|request| request.summary == compact_summary),
|
||||
"Committed credit request contains the accepted pressure summary.".to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-awaits-bifrost-review",
|
||||
content.contains("[request]")
|
||||
&& content.contains("status = \"awaiting-bifrost-credit-review\"")
|
||||
&& content.contains("requested_owner = \"Bifrost\"")
|
||||
&& content.contains(
|
||||
"requested_effect = \"record-credit-for-redacted-proof-and-accepted-artifact\"",
|
||||
)
|
||||
&& content.contains("publication_request_ref = ")
|
||||
&& content.contains("maintainer_review_request_ref = ")
|
||||
&& content.contains("pr_request_ref = "),
|
||||
request
|
||||
.as_ref()
|
||||
.is_some_and(RepoCreditRequest::awaits_bifrost_review),
|
||||
"Committed credit request waits for Bifrost credit review before consequence."
|
||||
.to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-antecedents-present",
|
||||
content.contains("[antecedents]")
|
||||
&& content.contains("closure_review_required = true")
|
||||
&& content.contains("soul_verdict_required = true")
|
||||
&& content.contains("mind_commit_required = true")
|
||||
&& content.contains("public_proof_required = true")
|
||||
&& content.contains("maintainer_review_required = true")
|
||||
&& content.contains("accepted_artifact_required = true")
|
||||
&& content.contains("authorship_context_required = true"),
|
||||
request.as_ref().is_some_and(RepoCreditRequest::has_antecedent_contract),
|
||||
"Committed credit request requires closure, Soul, Mind, proof, review, accepted artifact, and authorship antecedents."
|
||||
.to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-receipt-contract",
|
||||
content.contains("[required_receipts]")
|
||||
&& content.contains(
|
||||
"closure_review = \"epiphany.repo_work_closure_review.v0\"",
|
||||
)
|
||||
&& content.contains(
|
||||
"soul_verdict = \"epiphany.soul.verification_verdict\"",
|
||||
)
|
||||
&& content.contains("mind_commit = \"epiphany.mind.state_commit_receipt\"")
|
||||
&& content.contains(
|
||||
"public_proof = \"epiphany.repo_work_public_proof_bundle.v0\"",
|
||||
)
|
||||
&& content.contains(
|
||||
"maintainer_review = \"gamecult.maintainer.review_receipt.v0\"",
|
||||
)
|
||||
&& content.contains(
|
||||
"accepted_artifact = \"gamecult.artifact.acceptance_receipt.v0\"",
|
||||
)
|
||||
&& content.contains("credit_ledger = \"gamecult.bifrost.credit_receipt.v0\"")
|
||||
&& content.contains("credit_readback = \"gamecult.bifrost.credit_readback_receipt.v0\""),
|
||||
request.as_ref().is_some_and(RepoCreditRequest::has_receipt_contract),
|
||||
"Committed credit request names closure, proof, review, accepted artifact, ledger, and readback receipts."
|
||||
.to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-packet-contract",
|
||||
content.contains("[credit_packet]")
|
||||
&& content.contains("requires_author_identity = true")
|
||||
&& content.contains("requires_reviewer_identity = true")
|
||||
&& content.contains("requires_accepted_artifact_ref = true")
|
||||
&& content.contains("requires_public_proof_ref = true")
|
||||
&& content.contains("requires_changed_path_list = true")
|
||||
&& content.contains("requires_credit_ledger_target = true")
|
||||
&& content.contains("requires_private_state_redaction_check = true"),
|
||||
request.as_ref().is_some_and(RepoCreditRequest::has_credit_packet),
|
||||
"Committed credit request names author, reviewer, artifact, proof, path, ledger, and redaction requirements."
|
||||
.to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-authority-seals",
|
||||
content.contains("[authority]")
|
||||
&& content.contains("credit_ledger_authorized = false")
|
||||
&& content.contains("bifrost_publication_authorized = false")
|
||||
&& content.contains("github_pr_authorized = false")
|
||||
&& content.contains("merge_authorized = false")
|
||||
&& content.contains("publication_authorized = false")
|
||||
&& content.contains("upstream_sync_authorized = false")
|
||||
&& content.contains("hands_action_authorized = false")
|
||||
&& content.contains("cross_body_mutation_authorized = false")
|
||||
&& content.contains("bifrost_credit_authority_required = true"),
|
||||
request.as_ref().is_some_and(RepoCreditRequest::has_authority_seals),
|
||||
"Committed credit request denies credit/publication/PR/merge/sync/action/cross-body authority."
|
||||
.to_string(),
|
||||
);
|
||||
push_assertion(
|
||||
&mut assertions,
|
||||
"credit-request-private-seal",
|
||||
content.contains("private_state_exposed = false"),
|
||||
request
|
||||
.as_ref()
|
||||
.is_some_and(|request| !request.private_state_exposed),
|
||||
"Committed credit request preserves the private-state seal.".to_string(),
|
||||
);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -380,6 +380,141 @@ pub(super) fn parse_repo_artifact_acceptance_request(
|
|||
toml::from_str(text).context("artifact acceptance request is not valid typed TOML")
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
pub(super) struct RepoCreditRequest {
|
||||
pub(super) schema_version: String,
|
||||
pub(super) safe_action_family: String,
|
||||
pub(super) summary: String,
|
||||
pub(super) private_state_exposed: bool,
|
||||
request: RepoCreditRequestBody,
|
||||
antecedents: RepoCreditAntecedents,
|
||||
required_receipts: RepoCreditReceipts,
|
||||
credit_packet: RepoCreditPacket,
|
||||
authority: RepoCreditAuthority,
|
||||
}
|
||||
|
||||
impl RepoCreditRequest {
|
||||
pub(super) fn has_canonical_identity(&self) -> bool {
|
||||
self.schema_version == "epiphany.repo_credit_request.v0"
|
||||
&& self.safe_action_family == "repo.credit_request"
|
||||
}
|
||||
pub(super) fn awaits_bifrost_review(&self) -> bool {
|
||||
let r = &self.request;
|
||||
r.status == "awaiting-bifrost-credit-review"
|
||||
&& r.requested_owner == "Bifrost"
|
||||
&& r.requested_effect == "record-credit-for-redacted-proof-and-accepted-artifact"
|
||||
&& !r.publication_request_ref.is_empty()
|
||||
&& !r.maintainer_review_request_ref.is_empty()
|
||||
&& !r.pr_request_ref.is_empty()
|
||||
}
|
||||
pub(super) fn has_antecedent_contract(&self) -> bool {
|
||||
let a = &self.antecedents;
|
||||
a.closure_review_required
|
||||
&& a.soul_verdict_required
|
||||
&& a.mind_commit_required
|
||||
&& a.public_proof_required
|
||||
&& a.maintainer_review_required
|
||||
&& a.accepted_artifact_required
|
||||
&& a.authorship_context_required
|
||||
}
|
||||
pub(super) fn has_receipt_contract(&self) -> bool {
|
||||
let r = &self.required_receipts;
|
||||
r.closure_review == "epiphany.repo_work_closure_review.v0"
|
||||
&& r.soul_verdict == "epiphany.soul.verification_verdict"
|
||||
&& r.mind_commit == "epiphany.mind.state_commit_receipt"
|
||||
&& r.public_proof == "epiphany.repo_work_public_proof_bundle.v0"
|
||||
&& r.maintainer_review == "gamecult.maintainer.review_receipt.v0"
|
||||
&& r.accepted_artifact == "gamecult.artifact.acceptance_receipt.v0"
|
||||
&& r.credit_ledger == "gamecult.bifrost.credit_receipt.v0"
|
||||
&& r.credit_readback == "gamecult.bifrost.credit_readback_receipt.v0"
|
||||
}
|
||||
pub(super) fn has_credit_packet(&self) -> bool {
|
||||
let p = &self.credit_packet;
|
||||
p.requires_author_identity
|
||||
&& p.requires_reviewer_identity
|
||||
&& p.requires_accepted_artifact_ref
|
||||
&& p.requires_public_proof_ref
|
||||
&& p.requires_changed_path_list
|
||||
&& p.requires_credit_ledger_target
|
||||
&& p.requires_private_state_redaction_check
|
||||
}
|
||||
pub(super) fn has_authority_seals(&self) -> bool {
|
||||
let a = &self.authority;
|
||||
a.branch_local_only
|
||||
&& !a.credit_ledger_authorized
|
||||
&& !a.bifrost_publication_authorized
|
||||
&& !a.github_pr_authorized
|
||||
&& !a.merge_authorized
|
||||
&& !a.publication_authorized
|
||||
&& !a.upstream_sync_authorized
|
||||
&& !a.hands_action_authorized
|
||||
&& !a.service_lifecycle_authority
|
||||
&& !a.cross_body_mutation_authorized
|
||||
&& !a.private_verse_rummaging
|
||||
&& a.bifrost_credit_authority_required
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
struct RepoCreditRequestBody {
|
||||
status: String,
|
||||
requested_owner: String,
|
||||
requested_effect: String,
|
||||
publication_request_ref: String,
|
||||
maintainer_review_request_ref: String,
|
||||
pr_request_ref: String,
|
||||
}
|
||||
#[derive(Debug, Deserialize)]
|
||||
struct RepoCreditAntecedents {
|
||||
closure_review_required: bool,
|
||||
soul_verdict_required: bool,
|
||||
mind_commit_required: bool,
|
||||
public_proof_required: bool,
|
||||
maintainer_review_required: bool,
|
||||
accepted_artifact_required: bool,
|
||||
authorship_context_required: bool,
|
||||
}
|
||||
#[derive(Debug, Deserialize)]
|
||||
struct RepoCreditReceipts {
|
||||
closure_review: String,
|
||||
soul_verdict: String,
|
||||
mind_commit: String,
|
||||
public_proof: String,
|
||||
maintainer_review: String,
|
||||
accepted_artifact: String,
|
||||
credit_ledger: String,
|
||||
credit_readback: String,
|
||||
}
|
||||
#[derive(Debug, Deserialize)]
|
||||
struct RepoCreditPacket {
|
||||
requires_author_identity: bool,
|
||||
requires_reviewer_identity: bool,
|
||||
requires_accepted_artifact_ref: bool,
|
||||
requires_public_proof_ref: bool,
|
||||
requires_changed_path_list: bool,
|
||||
requires_credit_ledger_target: bool,
|
||||
requires_private_state_redaction_check: bool,
|
||||
}
|
||||
#[derive(Debug, Deserialize)]
|
||||
struct RepoCreditAuthority {
|
||||
branch_local_only: bool,
|
||||
credit_ledger_authorized: bool,
|
||||
bifrost_publication_authorized: bool,
|
||||
github_pr_authorized: bool,
|
||||
merge_authorized: bool,
|
||||
publication_authorized: bool,
|
||||
upstream_sync_authorized: bool,
|
||||
hands_action_authorized: bool,
|
||||
service_lifecycle_authority: bool,
|
||||
cross_body_mutation_authorized: bool,
|
||||
private_verse_rummaging: bool,
|
||||
bifrost_credit_authority_required: bool,
|
||||
}
|
||||
|
||||
pub(super) fn parse_repo_credit_request(text: &str) -> Result<RepoCreditRequest> {
|
||||
toml::from_str(text).context("credit request is not valid typed TOML")
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tool_request_tests {
|
||||
use super::*;
|
||||
|
|
@ -536,6 +671,64 @@ maintainer_or_bifrost_acceptance_authority_required = true
|
|||
let request = parse_repo_artifact_acceptance_request(text).expect("fixture is typed TOML");
|
||||
assert!(!request.has_authority_seals());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn credit_comment_cannot_counterfeit_ledger_seal() {
|
||||
let text = r#"
|
||||
schema_version = "epiphany.repo_credit_request.v0"
|
||||
safe_action_family = "repo.credit_request"
|
||||
summary = "summary"
|
||||
private_state_exposed = false
|
||||
[request]
|
||||
status = "awaiting-bifrost-credit-review"
|
||||
requested_owner = "Bifrost"
|
||||
requested_effect = "record-credit-for-redacted-proof-and-accepted-artifact"
|
||||
publication_request_ref = "publication"
|
||||
maintainer_review_request_ref = "review"
|
||||
pr_request_ref = "pr"
|
||||
[antecedents]
|
||||
closure_review_required = true
|
||||
soul_verdict_required = true
|
||||
mind_commit_required = true
|
||||
public_proof_required = true
|
||||
maintainer_review_required = true
|
||||
accepted_artifact_required = true
|
||||
authorship_context_required = true
|
||||
[required_receipts]
|
||||
closure_review = "epiphany.repo_work_closure_review.v0"
|
||||
soul_verdict = "epiphany.soul.verification_verdict"
|
||||
mind_commit = "epiphany.mind.state_commit_receipt"
|
||||
public_proof = "epiphany.repo_work_public_proof_bundle.v0"
|
||||
maintainer_review = "gamecult.maintainer.review_receipt.v0"
|
||||
accepted_artifact = "gamecult.artifact.acceptance_receipt.v0"
|
||||
credit_ledger = "gamecult.bifrost.credit_receipt.v0"
|
||||
credit_readback = "gamecult.bifrost.credit_readback_receipt.v0"
|
||||
[credit_packet]
|
||||
requires_author_identity = true
|
||||
requires_reviewer_identity = true
|
||||
requires_accepted_artifact_ref = true
|
||||
requires_public_proof_ref = true
|
||||
requires_changed_path_list = true
|
||||
requires_credit_ledger_target = true
|
||||
requires_private_state_redaction_check = true
|
||||
[authority]
|
||||
branch_local_only = true
|
||||
# credit_ledger_authorized = false
|
||||
credit_ledger_authorized = true
|
||||
bifrost_publication_authorized = false
|
||||
github_pr_authorized = false
|
||||
merge_authorized = false
|
||||
publication_authorized = false
|
||||
upstream_sync_authorized = false
|
||||
hands_action_authorized = false
|
||||
service_lifecycle_authority = false
|
||||
cross_body_mutation_authorized = false
|
||||
private_verse_rummaging = false
|
||||
bifrost_credit_authority_required = true
|
||||
"#;
|
||||
let request = parse_repo_credit_request(text).expect("fixture is typed TOML");
|
||||
assert!(!request.has_authority_seals());
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
|
|
|
|||
|
|
@ -817,6 +817,14 @@ semantics. A commented denial cannot conceal
|
|||
`artifact_acceptance_authorized = true`; Maintainer/Bifrost remains the only
|
||||
named acceptance owner.
|
||||
|
||||
## Credit-request prose substituted for Bifrost authority
|
||||
|
||||
`repo.credit_request` closure previously inferred Bifrost request identity,
|
||||
receipt contracts, packet requirements, and denied ledger authority from text
|
||||
fragments. It now parses a family-specific typed contract and checks exact
|
||||
semantics. A comment cannot conceal `credit_ledger_authorized = true`; Bifrost
|
||||
remains the sole credit consequence owner.
|
||||
|
||||
## Unresolved: provider receipts without chronology
|
||||
|
||||
Bifrost body-change/GitHub publication receipts are externally owned and their
|
||||
|
|
|
|||
|
|
@ -235,9 +235,9 @@ Historical implementation detail belongs in git history, smoke artifacts, and th
|
|||
## Next real move
|
||||
|
||||
Continue the modeling pass beyond receipt writers. Tool-request,
|
||||
metrics-request, and artifact-acceptance-request closure now use typed family
|
||||
contracts and cannot accept comment-counterfeit execution, spend, or acceptance
|
||||
seals.
|
||||
metrics-request, artifact-acceptance-request, and credit-request closure now use
|
||||
typed family contracts and cannot accept comment-counterfeit execution, spend,
|
||||
acceptance, or credit seals.
|
||||
Inventory remaining substring closure families and production paths where a
|
||||
projection, cache, adapter, scheduler, coordinator, or compatibility surface
|
||||
asserts a fact owned elsewhere. For each candidate, name the owner, allowed
|
||||
|
|
|
|||
Binary file not shown.
|
|
@ -660,4 +660,4 @@ current_status:
|
|||
- Service lifecycle receipt history is now event-only: `load_epiphany_cultmesh_daemon_service_lifecycle_receipts` filters out the `epiphany-local/daemon-service-lifecycle-receipt/latest` mirror, while `load_latest_epiphany_cultmesh_daemon_service_lifecycle_receipt` remains the latest-state reader. Focused unit test `service_lifecycle_receipt_history_excludes_latest_mirror` proves two per-receipt writes return exactly two history records and latest points at the second. Fresh smoke `verse-query-lifecycle-history-filter-smoke` and live overview/triage `local-20260618-145632-497-efac6f0d` / `local-20260618-145632-321-867947af` prove compact swarm sights still expose service lifecycle attention plus the present elevated runbook artifact without daemon pokes or service mutation. Do not use a broad unscoped cargo test filter for this check on Windows; it fans out across bin harnesses and hit a broken pipe during this pass.
|
||||
- `epiphany-verse-query seed-compact` is the compact seed receipt for wrappers and read-only rites. The older `seed` command still prints the full local Verse context for explicit debugging, but compact wrapper modes now avoid full `seed`/final `query` readback after the combined overview proof exposed Windows debug stack overflow from full-context serialization pressure.
|
||||
last_completed_repo_swarm_cut: Huginn live-fire has crossed the first real repo Body from Persona pressure to branch-local Hands commit and Soul/Mind closure, and now has repeatable closure and redacted-public-proof mouths. On `E:\Projects\Huginn` branch `epiphany/huginn/first-awakening`, `tools/epiphany_local_run.ps1 -Mode repo-persona-intake` accepted item `huginn-inspection-readback-livefire`, Weksa/Persona intake remained sealed, and `epiphany-work derive-plan` lowered it to model-authored safe family `repo.status_section` for `README.md` only. `tools/epiphany_local_run.ps1 -Mode repo-swarm-run` advanced four bounded pulses: run-from-plan, adopt-from-plan, execute-from-plan, and close-from-execute. Huginn commit `e9b07c38fceabbdc89ea35c2156326c80c0393a2` updated only `README.md`; closure receipt `.epiphany\work\work-close-huginn-inspection-readback-livefire.json` records status `closed`, Soul verdict `passed`, Mind state commit `repo-work-close-huginn-inspection-readback-livefire-mind-commit`, safe family `repo.status_section`, path scope `README.md`, Bifrost publication gate, and `privateStateExposed=false`. Verification also ran Huginn's TypeScript compiler through concrete Node path: `C:\Program Files\nodejs\node.exe E:\Projects\Huginn\node_modules\typescript\bin\tsc -p tsconfig.json` passed. Native verifier `epiphany-repo-livefire-closure-smoke --workspace E:\Projects\Huginn --item huginn-inspection-readback-livefire --expected-path README.md --expected-family repo.status_section --expected-gate awaiting-publication --expected-blocker bifrost-publication-missing` checks closure receipt, Mind map entry, overview gate/blocker, authority seals, and `git show` changed paths, returning `status=ok`, `soulVerdict=passed`, `publicationGate=Bifrost`, and `privateStateExposed=false`. Wrapper `tools/epiphany_local_run.ps1 -Mode repo-livefire-closure -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exposes the same read-only proof through the local operator mouth; artifact `local-20260621-190156-803-2f85ba15` printed commit, path, gate, blocker, Soul verdict, Mind commit receipt, and `privateStateExposed=False` without push, merge, publication, or target mutation. New wrapper `tools/epiphany_local_run.ps1 -Mode repo-work-public-proof -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exports the redacted proof bundle and repo-local Verse index without publishing; artifact `local-20260621-190645-345-4555b1dc` wrote `.epiphany\public\proof-bundles\repo-work-public-proof-huginn-inspection-readback-livefire.json`, proof id `repo-work-public-proof-huginn-inspection-readback-livefire`, SHA-256 `857545b199f3e37eb06c2e757e5cfc201958e46667bb1f8403fd333a22620f63`, nine artifact rows, zero publication rows, and `privateStateExposed=False`. swarm overview readback `local-20260621-190701-140-b9519ec6` sees the `REPO-WORK-PUBLIC-PROOF` row and action row from Huginn's repo-local Verse with the same SHA-256 while Bifrost publication remains missing. Launcher compact modes are now named compact operator-context modes instead of read-only modes, and `bifrost-public-proof` summaries print item, target public Verse, room, proof SHA-256, review receipts, and credit receipts so publication receipts are auditable without claiming upstream sync.
|
||||
next_action: Continue the conceptual-substitution pass. Typed deployment config/request, secret-policy, dependency-policy, tool-request, metrics-request, and artifact-acceptance-request contracts now live in parent-private epiphany_work/closure_contracts.rs; comments cannot counterfeit execution, spend, or acceptance-denial seals. Add future family validators there only when they protect named invariants, never as generic policy mush. Operational/evidence/self-state and operator mirrors follow owned clocks; identity chains are typed; scheduling/runbook selection do not parse prose; verse-query smoke deletion is canonically confined; writerless readiness-review is deleted. Bifrost provider receipts still need provider chronology. Continue auditing remaining substring closure families, destructive path consumers, evidence/security mirrors, and adapters for borrowed authority.
|
||||
next_action: Continue the conceptual-substitution pass. Typed deployment config/request, secret-policy, dependency-policy, tool-request, metrics-request, artifact-acceptance-request, and credit-request contracts now live in parent-private epiphany_work/closure_contracts.rs; comments cannot counterfeit execution, spend, acceptance, or credit-denial seals. Add future family validators there only when they protect named invariants, never as generic policy mush. Operational/evidence/self-state and operator mirrors follow owned clocks; identity chains are typed; scheduling/runbook selection do not parse prose; verse-query smoke deletion is canonically confined; writerless readiness-review is deleted. Bifrost provider receipts still need provider chronology. Continue auditing remaining substring closure families, destructive path consumers, evidence/security mirrors, and adapters for borrowed authority.
|
||||
|
|
|
|||
Reference in a new issue