Harden Epiphany promotion state replacements
This commit is contained in:
parent
8a0c305f88
commit
bb557d1484
8 changed files with 519 additions and 35 deletions
|
|
@ -699,13 +699,15 @@ The app-server handler:
|
|||
7. calls `CodexThread.epiphany_update_state`.
|
||||
8. returns the updated `EpiphanyThreadState`.
|
||||
|
||||
`evaluate_promotion` currently enforces a deliberately small policy:
|
||||
`evaluate_promotion` currently enforces a deliberately small but now map-aware policy:
|
||||
|
||||
1. the patch must contain at least one mutation.
|
||||
2. verifier evidence must have nonempty id/kind/status/summary.
|
||||
3. verifier status must be accepting: `ok`, `accepted`, `verified`, `pass`, or `passed`.
|
||||
4. patch evidence records must be nonempty and unique by id.
|
||||
5. observations must be nonempty, unique by id, and cite existing evidence ids.
|
||||
6. state replacement patches, including map/frontier/checkpoint/churn edits, must include at least one explicit observation and at least one patch evidence record.
|
||||
7. subgoal, invariant, graph, frontier, checkpoint, and churn replacements get lightweight structural validation before they can reach the durable update path.
|
||||
|
||||
Code refs:
|
||||
|
||||
|
|
@ -714,6 +716,7 @@ Code refs:
|
|||
- [codex_message_processor.rs](E:/Projects/EpiphanyAgent/vendor/codex/codex-rs/app-server/src/codex_message_processor.rs:4280)
|
||||
- [codex_message_processor.rs](E:/Projects/EpiphanyAgent/vendor/codex/codex-rs/app-server/src/codex_message_processor.rs:4308)
|
||||
- [epiphany-core/src/promotion.rs](E:/Projects/EpiphanyAgent/epiphany-core/src/promotion.rs:19)
|
||||
- [epiphany-core/src/promotion.rs](E:/Projects/EpiphanyAgent/epiphany-core/src/promotion.rs:122)
|
||||
|
||||
### Output
|
||||
|
||||
|
|
@ -758,9 +761,9 @@ model/tool observations
|
|||
-> durable evidence/map/churn mutation
|
||||
```
|
||||
|
||||
That remaining missing organ is richer map/churn promotion. The typed write path exists, the first deterministic distillation proposal path exists, and the first verifier-backed promotion gate exists. What does not exist yet is a policy that turns accepted observations into graph/frontier/churn edits without drifting into automatic graph fanfic.
|
||||
That remaining missing organ is richer map/churn promotion. The typed write path exists, the first deterministic distillation proposal path exists, and the first verifier-backed promotion gate exists. The first map/churn safety layer now exists too: promotion can reject state replacement patches that are not tied to explicit observations/evidence or that contain structurally broken subgoal, invariant, graph, frontier, checkpoint, or churn fields.
|
||||
|
||||
In natural language: current Epiphany can preserve a map, show a map, retrieve evidence for the map, draft one explicit observation/evidence patch, reject or accept a verified candidate, and apply explicit map/evidence/churn edits. It still cannot safely derive richer map/churn edits from observations by itself. Teeth are installed; chewing is still supervised.
|
||||
In natural language: current Epiphany can preserve a map, show a map, retrieve evidence for the map, draft one explicit observation/evidence patch, reject or accept a verified candidate, apply explicit map/evidence/churn edits, and sanity-check those edits before they hit the ledger. It still does not derive graph edits by itself. Teeth are installed; chewing is still supervised.
|
||||
|
||||
## Verification Hooks
|
||||
|
||||
|
|
@ -771,6 +774,7 @@ Current tests cover the landed flows at useful seams:
|
|||
- explicit out-of-band Epiphany snapshot replay before the first user turn.
|
||||
- deterministic observation/evidence distillation in `epiphany-core`.
|
||||
- verifier-backed promotion policy in `epiphany-core`.
|
||||
- map/churn promotion validation for evidence-backed state replacements in `epiphany-core`.
|
||||
- typed state-update patch application in `codex-core`.
|
||||
- retrieval ranking, fallback, stale manifest detection, and mocked Qdrant/Ollama indexing in `epiphany-core`.
|
||||
- app-server protocol serde for `thread/epiphany/retrieve`, `thread/epiphany/index`, `thread/epiphany/distill`, `thread/epiphany/promote`, and `thread/epiphany/update`.
|
||||
|
|
|
|||
|
|
@ -14,8 +14,9 @@ This note tracks Epiphany as a fork of Codex with an opinionated modeling archit
|
|||
- the heavy Epiphany-owned prompt/replay/retrieval implementation has now been extracted into the repo-owned `epiphany-core` crate, leaving vendored Codex with thin host adapters plus the typed integration seam
|
||||
- a first typed state-update slice that adds explicit loaded-thread-only `thread/epiphany/update`, appends observations/evidence, replaces bounded map/scratch/churn fields, bumps the state revision, and persists an immediate rollout `EpiphanyState` snapshot
|
||||
- a first typed distillation/proposal slice that adds read-only loaded-thread-only `thread/epiphany/distill`, producing deterministic observation/evidence patches for explicit promotion through `thread/epiphany/update`
|
||||
- a first richer promotion-policy slice that treats map/churn/frontier/checkpoint replacements as higher-risk state edits: accepted promotions must be tied to explicit observations and patch evidence, and structural graph/churn mistakes are rejected before the durable update path
|
||||
|
||||
The next job is no longer to prove the retriever exists, sketch the persistent follow-up in prose, invent the first red-pen path, or build the first observation proposal surface. Those parts are landed. The next job is to keep the landing zone honest: do not casually turn `thread/epiphany/retrieve` or `thread/epiphany/distill` into durable Epiphany-state writers, and do not widen the explicit indexing/update paths into watcher-driven or GUI-shaped machinery before they earn it.
|
||||
The next job is no longer to prove the retriever exists, sketch the persistent follow-up in prose, invent the first red-pen path, build the first observation proposal surface, or make promotion notice broken map/churn replacements. Those parts are landed. The next job is to keep the landing zone honest: do not casually turn `thread/epiphany/retrieve` or `thread/epiphany/distill` into durable Epiphany-state writers, and do not widen the explicit indexing/update paths into watcher-driven or GUI-shaped machinery before they earn it.
|
||||
|
||||
## Summary
|
||||
|
||||
|
|
@ -227,6 +228,19 @@ Current bounded shape of that follow-up:
|
|||
- it returns deterministic observation/evidence records inside a `ThreadEpiphanyUpdatePatch`
|
||||
- callers must pass the patch to `thread/epiphany/update` to make it durable
|
||||
|
||||
Follow-up addition now landed after the promotion gate:
|
||||
|
||||
- richer `thread/epiphany/promote` policy for state replacement patches
|
||||
|
||||
Current bounded shape of that follow-up:
|
||||
|
||||
- it keeps the wire protocol stable
|
||||
- it still rejects failed verifier evidence without mutation
|
||||
- it now passes replacement fields into `epiphany-core` policy evaluation instead of reducing them to a generic boolean
|
||||
- map/churn/frontier/checkpoint replacements must include explicit observations and patch evidence, so state edits are tied to a verified observation trail
|
||||
- subgoals, invariants, graphs, graph links, frontier ids, checkpoint ids, and churn fields get lightweight structural validation before accepted patches are sent to `thread/epiphany/update`
|
||||
- it still does not infer graph edits automatically; callers must submit explicit typed replacements
|
||||
|
||||
### 5. Reuse existing exact-search substrate where practical
|
||||
|
||||
Codex already has fuzzy/exact-ish repo search substrate. Reuse what is useful instead of building a second exact-search toy from scratch.
|
||||
|
|
@ -258,9 +272,9 @@ Treat the current retrieval baseline, explicit indexing follow-up, explicit upda
|
|||
2. treat the verified and live-smoked `thread/epiphany/index` slice as the bounded persistent-semantic follow-up
|
||||
3. keep the new `epiphany-core` boundary honest instead of letting vendored Codex re-accumulate the heavy implementation
|
||||
4. do not add durable retrieval-summary writes from `thread/epiphany/retrieve` without a clean out-of-band rollout/update semantic
|
||||
5. build the next layer above the landed distill/update surfaces:
|
||||
5. build the next layer above the landed distill/update/promote surfaces:
|
||||
- richer typed observation distillation from tool/model outputs
|
||||
- promotion policy that decides when to call `thread/epiphany/update` explicitly
|
||||
- promotion policy beyond structural validation, but only when it can stay evidence-backed
|
||||
- verifier-backed acceptance/rejection evidence
|
||||
- no hidden retrieval writes
|
||||
- not GUI work
|
||||
|
|
|
|||
|
|
@ -190,6 +190,7 @@ What is wired right now:
|
|||
- app-server message handling now routes those methods through the core host seam
|
||||
- `thread/epiphany/distill` is the first read-only proposal surface; it returns an `expectedRevision` plus a patch and requires explicit promotion through `thread/epiphany/update`
|
||||
- `thread/epiphany/promote` is the first explicit promotion gate; it rejects failed verifier evidence without mutation and applies accepted candidates through the update path
|
||||
- `thread/epiphany/promote` now has a first richer map/churn safety layer: state replacement patches must carry explicit observations and patch evidence, and subgoal/invariant/graph/frontier/checkpoint/churn structure is validated before the durable update path is called
|
||||
- `thread/epiphany/update` is the first explicit durable Epiphany state write surface; it rejects empty patches, supports optional revision matching, appends observations/evidence, replaces bounded typed fields, increments state revision, and persists immediately
|
||||
- live hydrated `thread.epiphanyState` reads now backfill a lightweight retrieval summary when the thread already has Epiphany state but no persisted retrieval summary yet
|
||||
- basic protocol/core/app-server unit tests were added for the new types and mapping layer
|
||||
|
|
@ -429,7 +430,7 @@ Without that, you get to learn about `symlink_dir failed: ... A required privile
|
|||
|
||||
Do not restart verification from superstition. The current Phase 4 retrieval/indexing/core-extraction baseline is already verified, committed, and pushed.
|
||||
|
||||
The durable state seam exists, the turn loop reads it, clients can load typed Epiphany state directly, the first retrieval slice is real, the explicit persistent-semantic indexing path is landed, and the first distill/promote/update path is live-smoked. The next clean move is richer map/churn promotion policy, not pretending the already-shipped slices still need ceremony.
|
||||
The durable state seam exists, the turn loop reads it, clients can load typed Epiphany state directly, the first retrieval slice is real, the explicit persistent-semantic indexing path is landed, the first distill/promote/update path is live-smoked, and promotion now has a first structural map/churn safety layer. The next clean move is richer observation-to-map proposal machinery, not pretending the already-shipped slices still need ceremony.
|
||||
|
||||
Current next implementation move:
|
||||
|
||||
|
|
@ -438,7 +439,7 @@ Current next implementation move:
|
|||
3. keep `thread/epiphany/retrieve` and `thread/epiphany/distill` read-only
|
||||
4. build the next layer above the distill/promote/update surfaces:
|
||||
- richer map/churn patch generation from verified observations
|
||||
- promotion policy beyond simple evidence-linked observation acceptance
|
||||
- promotion policy beyond structural validation only when the evidence path stays explicit
|
||||
- verifier-backed acceptance/rejection evidence
|
||||
- no GUI, watcher, or specialist-agent machinery yet
|
||||
|
||||
|
|
|
|||
Reference in a new issue