Bind consensus accounting to feedback
This commit is contained in:
parent
98b6147365
commit
9657e89f9b
5 changed files with 107 additions and 6 deletions
|
|
@ -8055,20 +8055,23 @@ fn bifrost_accounting_rows(
|
|||
latest_metrics,
|
||||
);
|
||||
|
||||
let matching_consensus = latest_feedback.and_then(|feedback| {
|
||||
latest_consensus.filter(|receipt| receipt.feedback_id == feedback.feedback_id)
|
||||
});
|
||||
let collaboration_private = latest_feedback
|
||||
.map(|feedback| feedback.private_state_included)
|
||||
.unwrap_or(false)
|
||||
|| latest_consensus
|
||||
|| matching_consensus
|
||||
.map(|receipt| receipt.private_state_exposed)
|
||||
.unwrap_or(false);
|
||||
let collaboration_public_count = latest_feedback
|
||||
.map(|feedback| feedback.public_discussion_refs.len())
|
||||
.unwrap_or(0)
|
||||
+ latest_consensus
|
||||
+ matching_consensus
|
||||
.map(|receipt| receipt.public_feedback_refs.len())
|
||||
.unwrap_or(0);
|
||||
let collaboration_closed =
|
||||
latest_feedback.is_some() && latest_consensus.is_some() && !collaboration_private;
|
||||
latest_feedback.is_some() && matching_consensus.is_some() && !collaboration_private;
|
||||
push_bifrost_accounting_row(
|
||||
&mut rows,
|
||||
&mut tui_rows,
|
||||
|
|
@ -8083,11 +8086,11 @@ fn bifrost_accounting_rows(
|
|||
closure: format!(
|
||||
"feedback={} consensus={} publicRefs={}",
|
||||
present_word(latest_feedback.is_some()),
|
||||
present_word(latest_consensus.is_some()),
|
||||
present_word(matching_consensus.is_some()),
|
||||
collaboration_public_count
|
||||
),
|
||||
ledger_entry_id: "none".to_string(),
|
||||
latest_receipt_id: latest_consensus
|
||||
latest_receipt_id: matching_consensus
|
||||
.map(|receipt| receipt.receipt_id.clone())
|
||||
.or_else(|| latest_feedback.map(|feedback| feedback.feedback_id.clone()))
|
||||
.unwrap_or_else(|| "none".to_string()),
|
||||
|
|
@ -9501,6 +9504,45 @@ mod lifecycle_projection_tests {
|
|||
}
|
||||
}
|
||||
|
||||
fn collaboration_feedback(id: &str) -> EpiphanyCultMeshBifrostCollaborationFeedbackEntry {
|
||||
EpiphanyCultMeshBifrostCollaborationFeedbackEntry {
|
||||
schema_version:
|
||||
epiphany_core::EPIPHANY_CULTMESH_BIFROST_COLLABORATION_FEEDBACK_SCHEMA_VERSION
|
||||
.to_string(),
|
||||
feedback_id: id.to_string(),
|
||||
source_persona_id: "persona-1".to_string(),
|
||||
source_cluster_id: "persona".to_string(),
|
||||
public_room_id: "room-1".to_string(),
|
||||
eve_connection_receipt_id: "eve-1".to_string(),
|
||||
collaboration_topic: "test".to_string(),
|
||||
feedback_summary: "test".to_string(),
|
||||
public_discussion_refs: vec!["discussion-1".to_string()],
|
||||
requested_consensus_route: "imagination.consensus".to_string(),
|
||||
candidate_action_refs: Vec::new(),
|
||||
private_state_included: false,
|
||||
notes: Vec::new(),
|
||||
}
|
||||
}
|
||||
|
||||
fn consensus(feedback_id: &str) -> EpiphanyCultMeshImaginationConsensusReceiptEntry {
|
||||
EpiphanyCultMeshImaginationConsensusReceiptEntry {
|
||||
schema_version:
|
||||
epiphany_core::EPIPHANY_CULTMESH_IMAGINATION_CONSENSUS_RECEIPT_SCHEMA_VERSION
|
||||
.to_string(),
|
||||
receipt_id: "consensus-1".to_string(),
|
||||
feedback_id: feedback_id.to_string(),
|
||||
source_persona_id: "persona-1".to_string(),
|
||||
consensus_route: "imagination.consensus".to_string(),
|
||||
status: "accepted".to_string(),
|
||||
imagination_agent_ids: vec!["imagination-1".to_string()],
|
||||
consensus_packet_ref: "packet-1".to_string(),
|
||||
adoption_gate: "mind-review".to_string(),
|
||||
public_feedback_refs: vec!["public-feedback-1".to_string()],
|
||||
private_state_exposed: false,
|
||||
notes: Vec::new(),
|
||||
}
|
||||
}
|
||||
|
||||
fn receipt(
|
||||
id: &str,
|
||||
status: &str,
|
||||
|
|
@ -9591,4 +9633,39 @@ mod lifecycle_projection_tests {
|
|||
assert!(mismatched[0].closure.contains("publication=missing"));
|
||||
assert!(mismatched[0].closure.contains("github=missing"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn collaboration_accounting_closes_only_matching_feedback_consensus() {
|
||||
let feedback = collaboration_feedback("feedback-1");
|
||||
let matching_consensus = consensus("feedback-1");
|
||||
let (matching, _) = bifrost_accounting_rows(
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
Some(&feedback),
|
||||
Some(&matching_consensus),
|
||||
&[],
|
||||
);
|
||||
assert_eq!(matching.last().unwrap().status, "closed");
|
||||
|
||||
let unrelated_consensus = consensus("another-feedback");
|
||||
let (mismatched, _) = bifrost_accounting_rows(
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
None,
|
||||
Some(&feedback),
|
||||
Some(&unrelated_consensus),
|
||||
&[],
|
||||
);
|
||||
let row = mismatched.last().unwrap();
|
||||
assert_eq!(row.status, "open");
|
||||
assert!(row.closure.contains("consensus=missing"));
|
||||
assert_eq!(row.public_artifact_count, 1);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -671,6 +671,25 @@ Composition now follows the existing typed edges: publication
|
|||
omits unmatched descendants, and accounting reports the lane open with missing
|
||||
links instead of blessing adjacency as completion.
|
||||
|
||||
## Independent collaboration mirrors substituted for consensus
|
||||
|
||||
The collaboration accounting lane closed whenever any latest Persona feedback
|
||||
and any latest Imagination consensus receipt coexisted. It ignored the typed
|
||||
`consensus.feedback_id -> feedback.feedback_id` edge, so consensus for another
|
||||
conversation could complete the current lane and donate unrelated public refs.
|
||||
Closure and consensus-derived counts now use only a receipt whose feedback ID
|
||||
matches the displayed feedback. An unmatched receipt remains visible to raw
|
||||
diagnostics but the lane stays open and names the missing consensus link.
|
||||
|
||||
## Unresolved: artifact and metrics receipts lack request identity
|
||||
|
||||
Bifrost artifact-acceptance and metrics accounting combine latest repo-work
|
||||
requests with latest provider receipts, but those receipt contracts carry no
|
||||
repo-work map/request ID. Item, workspace, branch, and commit fields are not a
|
||||
stable causal identity and must not be promoted into one by consumer inference.
|
||||
The provider contracts need an explicit request/map identity edge before these
|
||||
lanes can truthfully claim request-to-receipt closure under concurrency.
|
||||
|
||||
## Unresolved: provider receipts without chronology
|
||||
|
||||
Bifrost body-change/GitHub publication receipts are externally owned and their
|
||||
|
|
|
|||
|
|
@ -168,6 +168,11 @@ The confirmed conceptual substitutions have been cut:
|
|||
- Bifrost prompt/accounting chains follow typed intent -> publication -> GitHub
|
||||
receipt identity. Independent latest documents cannot close publication,
|
||||
lend review/credit counts, or supply a counterfeit public reference.
|
||||
- Collaboration accounting follows consensus `feedback_id`; unrelated latest
|
||||
consensus cannot close another Persona feedback lane or lend public refs.
|
||||
- Artifact-acceptance and metrics receipts still lack an explicit repo-work
|
||||
request/map identity. Do not infer it from item/workspace/branch/commit;
|
||||
repair the Bifrost-owned contracts before claiming concurrent-safe closure.
|
||||
- Bifrost provider receipt contracts still lack provider timestamp/revision.
|
||||
Do not invent consumer-side ordering; repair that in a Bifrost-owned schema.
|
||||
|
||||
|
|
|
|||
Binary file not shown.
|
|
@ -660,4 +660,4 @@ current_status:
|
|||
- Service lifecycle receipt history is now event-only: `load_epiphany_cultmesh_daemon_service_lifecycle_receipts` filters out the `epiphany-local/daemon-service-lifecycle-receipt/latest` mirror, while `load_latest_epiphany_cultmesh_daemon_service_lifecycle_receipt` remains the latest-state reader. Focused unit test `service_lifecycle_receipt_history_excludes_latest_mirror` proves two per-receipt writes return exactly two history records and latest points at the second. Fresh smoke `verse-query-lifecycle-history-filter-smoke` and live overview/triage `local-20260618-145632-497-efac6f0d` / `local-20260618-145632-321-867947af` prove compact swarm sights still expose service lifecycle attention plus the present elevated runbook artifact without daemon pokes or service mutation. Do not use a broad unscoped cargo test filter for this check on Windows; it fans out across bin harnesses and hit a broken pipe during this pass.
|
||||
- `epiphany-verse-query seed-compact` is the compact seed receipt for wrappers and read-only rites. The older `seed` command still prints the full local Verse context for explicit debugging, but compact wrapper modes now avoid full `seed`/final `query` readback after the combined overview proof exposed Windows debug stack overflow from full-context serialization pressure.
|
||||
last_completed_repo_swarm_cut: Huginn live-fire has crossed the first real repo Body from Persona pressure to branch-local Hands commit and Soul/Mind closure, and now has repeatable closure and redacted-public-proof mouths. On `E:\Projects\Huginn` branch `epiphany/huginn/first-awakening`, `tools/epiphany_local_run.ps1 -Mode repo-persona-intake` accepted item `huginn-inspection-readback-livefire`, Weksa/Persona intake remained sealed, and `epiphany-work derive-plan` lowered it to model-authored safe family `repo.status_section` for `README.md` only. `tools/epiphany_local_run.ps1 -Mode repo-swarm-run` advanced four bounded pulses: run-from-plan, adopt-from-plan, execute-from-plan, and close-from-execute. Huginn commit `e9b07c38fceabbdc89ea35c2156326c80c0393a2` updated only `README.md`; closure receipt `.epiphany\work\work-close-huginn-inspection-readback-livefire.json` records status `closed`, Soul verdict `passed`, Mind state commit `repo-work-close-huginn-inspection-readback-livefire-mind-commit`, safe family `repo.status_section`, path scope `README.md`, Bifrost publication gate, and `privateStateExposed=false`. Verification also ran Huginn's TypeScript compiler through concrete Node path: `C:\Program Files\nodejs\node.exe E:\Projects\Huginn\node_modules\typescript\bin\tsc -p tsconfig.json` passed. Native verifier `epiphany-repo-livefire-closure-smoke --workspace E:\Projects\Huginn --item huginn-inspection-readback-livefire --expected-path README.md --expected-family repo.status_section --expected-gate awaiting-publication --expected-blocker bifrost-publication-missing` checks closure receipt, Mind map entry, overview gate/blocker, authority seals, and `git show` changed paths, returning `status=ok`, `soulVerdict=passed`, `publicationGate=Bifrost`, and `privateStateExposed=false`. Wrapper `tools/epiphany_local_run.ps1 -Mode repo-livefire-closure -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exposes the same read-only proof through the local operator mouth; artifact `local-20260621-190156-803-2f85ba15` printed commit, path, gate, blocker, Soul verdict, Mind commit receipt, and `privateStateExposed=False` without push, merge, publication, or target mutation. New wrapper `tools/epiphany_local_run.ps1 -Mode repo-work-public-proof -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exports the redacted proof bundle and repo-local Verse index without publishing; artifact `local-20260621-190645-345-4555b1dc` wrote `.epiphany\public\proof-bundles\repo-work-public-proof-huginn-inspection-readback-livefire.json`, proof id `repo-work-public-proof-huginn-inspection-readback-livefire`, SHA-256 `857545b199f3e37eb06c2e757e5cfc201958e46667bb1f8403fd333a22620f63`, nine artifact rows, zero publication rows, and `privateStateExposed=False`. swarm overview readback `local-20260621-190701-140-b9519ec6` sees the `REPO-WORK-PUBLIC-PROOF` row and action row from Huginn's repo-local Verse with the same SHA-256 while Bifrost publication remains missing. Launcher compact modes are now named compact operator-context modes instead of read-only modes, and `bifrost-public-proof` summaries print item, target public Verse, room, proof SHA-256, review receipts, and credit receipts so publication receipts are auditable without claiming upstream sync.
|
||||
next_action: Continue the conceptual-substitution modeling pass beyond receipt writers. Operational/evidence/self-state and operator surfaces with owned clocks are event-time ordered; operator receipts bind intents by run identity rather than global chronology; Eve/tool/Bifrost projections join chains only by typed identity; repo-work projections follow owning time; writerless readiness-review is deleted. Bifrost provider receipts still need a provider-owned chronology contract rather than consumer inference. Continue auditing other evidence/security mirrors, service configuration claims, adapters, and destructive path consumers for borrowed authority.
|
||||
next_action: Continue the conceptual-substitution modeling pass beyond receipt writers. Operational/evidence/self-state and operator surfaces with owned clocks are event-time ordered; operator receipts bind intents by run identity rather than global chronology; Eve/tool/Bifrost/collaboration projections join chains only by typed identity; repo-work projections follow owning time; writerless readiness-review is deleted. Bifrost provider receipts still need provider-owned chronology, and artifact/metrics receipts need explicit repo-work request identity rather than consumer inference. Continue auditing other evidence/security mirrors, service configuration claims, adapters, and destructive path consumers for borrowed authority.
|
||||
|
|
|
|||
Reference in a new issue