diff --git a/epiphany-core/src/bin/epiphany-repo-personality-smoke.rs b/epiphany-core/src/bin/epiphany-repo-personality-smoke.rs index 0b60d624..64cebdb1 100644 --- a/epiphany-core/src/bin/epiphany-repo-personality-smoke.rs +++ b/epiphany-core/src/bin/epiphany-repo-personality-smoke.rs @@ -23,8 +23,8 @@ fn run_smoke() -> Result { let artifacts = root .join(".epiphany-smoke") .join("repo-personality-artifacts"); - reset_path(&workspace)?; - reset_path(&artifacts)?; + reset_smoke_path(&root, &workspace)?; + reset_smoke_path(&root, &artifacts)?; let cult_repo = create_repo( &workspace.join("CultTiny"), &[ @@ -717,13 +717,47 @@ fn run_git(repo: &Path, args: &[&str]) -> Result<()> { ) } -fn reset_path(path: &Path) -> Result<()> { +fn reset_smoke_path(root: &Path, path: &Path) -> Result<()> { + let quarantine = root.join(".epiphany-smoke"); + fs::create_dir_all(&quarantine)?; + let quarantine = quarantine.canonicalize()?; + let parent = path.parent().unwrap_or_else(|| Path::new(".")); + fs::create_dir_all(parent)?; + let resolved = if path.exists() { + path.canonicalize()? + } else { + parent.canonicalize()?.join( + path.file_name() + .ok_or_else(|| anyhow!("smoke path has no leaf"))?, + ) + }; + if resolved == quarantine || !resolved.starts_with(&quarantine) { + return Err(anyhow!( + "refusing to reset path outside smoke quarantine: {}", + path.display() + )); + } if path.exists() { fs::remove_dir_all(path).with_context(|| format!("failed to reset {}", path.display()))?; } fs::create_dir_all(path).with_context(|| format!("failed to create {}", path.display())) } +#[cfg(test)] +mod reset_tests { + use super::*; + + #[test] + fn reset_refuses_traversal_outside_smoke_quarantine() -> Result<()> { + let temp = tempfile::tempdir()?; + let escaped = temp.path().join(".epiphany-smoke").join(".."); + let error = reset_smoke_path(temp.path(), &escaped).expect_err("escape must fail"); + assert!(error.to_string().contains("outside smoke quarantine")); + assert!(temp.path().exists()); + Ok(()) + } +} + fn path_value(value: &Value, key: &str) -> Result { value .get(key) diff --git a/notes/conceptual-substitution-audit-2026-07-12.md b/notes/conceptual-substitution-audit-2026-07-12.md index 71952038..959cd5f8 100644 --- a/notes/conceptual-substitution-audit-2026-07-12.md +++ b/notes/conceptual-substitution-audit-2026-07-12.md @@ -842,6 +842,15 @@ families, while collapsing shared envelope syntax only where the shared owner and invariant can be named. Presentation-only markdown checks do not deserve a policy framework merely because they also use strings. +## Fixed smoke-path provenance substituted for deletion scope + +`epiphany-repo-personality-smoke` built workspace and artifact paths beneath a +fixed `.epiphany-smoke` spelling, then recursively deleted them without +resolving containment. A junction at either leaf could redirect deletion beyond +the quarantine. Reset now canonicalizes the quarantine and target immediately +before actuation and requires a strict descendant. A traversal-negative test +proves path spelling cannot grant deletion authority. + ## Unresolved: provider receipts without chronology Bifrost body-change/GitHub publication receipts are externally owned and their diff --git a/notes/fresh-workspace-handoff.md b/notes/fresh-workspace-handoff.md index 59ed0d87..ced914b8 100644 --- a/notes/fresh-workspace-handoff.md +++ b/notes/fresh-workspace-handoff.md @@ -245,6 +245,11 @@ inputs, emitted state, forbidden writers, and negative proof before changing code. Also audit remaining non-receipt smoke binaries for path escape or destructive scope. +`epiphany-repo-personality-smoke` reset is now canonically confined beneath +`.epiphany-smoke`; fixed default provenance no longer authorizes recursive +deletion. Continue the same resolved-containment audit across remaining smoke +reset helpers. + The latest structural count is 32 closure family branches, 744 remaining substring assertions in the closure region, and 1,284 lines in `closure_contracts.rs`. Do not blindly generate a struct forest for every diff --git a/state/ledgers.msgpack b/state/ledgers.msgpack index bb5bbffd..d732e551 100644 Binary files a/state/ledgers.msgpack and b/state/ledgers.msgpack differ diff --git a/state/map.yaml b/state/map.yaml index b1c0aac1..59dbd267 100644 --- a/state/map.yaml +++ b/state/map.yaml @@ -660,4 +660,4 @@ current_status: - Service lifecycle receipt history is now event-only: `load_epiphany_cultmesh_daemon_service_lifecycle_receipts` filters out the `epiphany-local/daemon-service-lifecycle-receipt/latest` mirror, while `load_latest_epiphany_cultmesh_daemon_service_lifecycle_receipt` remains the latest-state reader. Focused unit test `service_lifecycle_receipt_history_excludes_latest_mirror` proves two per-receipt writes return exactly two history records and latest points at the second. Fresh smoke `verse-query-lifecycle-history-filter-smoke` and live overview/triage `local-20260618-145632-497-efac6f0d` / `local-20260618-145632-321-867947af` prove compact swarm sights still expose service lifecycle attention plus the present elevated runbook artifact without daemon pokes or service mutation. Do not use a broad unscoped cargo test filter for this check on Windows; it fans out across bin harnesses and hit a broken pipe during this pass. - `epiphany-verse-query seed-compact` is the compact seed receipt for wrappers and read-only rites. The older `seed` command still prints the full local Verse context for explicit debugging, but compact wrapper modes now avoid full `seed`/final `query` readback after the combined overview proof exposed Windows debug stack overflow from full-context serialization pressure. last_completed_repo_swarm_cut: Huginn live-fire has crossed the first real repo Body from Persona pressure to branch-local Hands commit and Soul/Mind closure, and now has repeatable closure and redacted-public-proof mouths. On `E:\Projects\Huginn` branch `epiphany/huginn/first-awakening`, `tools/epiphany_local_run.ps1 -Mode repo-persona-intake` accepted item `huginn-inspection-readback-livefire`, Weksa/Persona intake remained sealed, and `epiphany-work derive-plan` lowered it to model-authored safe family `repo.status_section` for `README.md` only. `tools/epiphany_local_run.ps1 -Mode repo-swarm-run` advanced four bounded pulses: run-from-plan, adopt-from-plan, execute-from-plan, and close-from-execute. Huginn commit `e9b07c38fceabbdc89ea35c2156326c80c0393a2` updated only `README.md`; closure receipt `.epiphany\work\work-close-huginn-inspection-readback-livefire.json` records status `closed`, Soul verdict `passed`, Mind state commit `repo-work-close-huginn-inspection-readback-livefire-mind-commit`, safe family `repo.status_section`, path scope `README.md`, Bifrost publication gate, and `privateStateExposed=false`. Verification also ran Huginn's TypeScript compiler through concrete Node path: `C:\Program Files\nodejs\node.exe E:\Projects\Huginn\node_modules\typescript\bin\tsc -p tsconfig.json` passed. Native verifier `epiphany-repo-livefire-closure-smoke --workspace E:\Projects\Huginn --item huginn-inspection-readback-livefire --expected-path README.md --expected-family repo.status_section --expected-gate awaiting-publication --expected-blocker bifrost-publication-missing` checks closure receipt, Mind map entry, overview gate/blocker, authority seals, and `git show` changed paths, returning `status=ok`, `soulVerdict=passed`, `publicationGate=Bifrost`, and `privateStateExposed=false`. Wrapper `tools/epiphany_local_run.ps1 -Mode repo-livefire-closure -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exposes the same read-only proof through the local operator mouth; artifact `local-20260621-190156-803-2f85ba15` printed commit, path, gate, blocker, Soul verdict, Mind commit receipt, and `privateStateExposed=False` without push, merge, publication, or target mutation. New wrapper `tools/epiphany_local_run.ps1 -Mode repo-work-public-proof -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exports the redacted proof bundle and repo-local Verse index without publishing; artifact `local-20260621-190645-345-4555b1dc` wrote `.epiphany\public\proof-bundles\repo-work-public-proof-huginn-inspection-readback-livefire.json`, proof id `repo-work-public-proof-huginn-inspection-readback-livefire`, SHA-256 `857545b199f3e37eb06c2e757e5cfc201958e46667bb1f8403fd333a22620f63`, nine artifact rows, zero publication rows, and `privateStateExposed=False`. swarm overview readback `local-20260621-190701-140-b9519ec6` sees the `REPO-WORK-PUBLIC-PROOF` row and action row from Huginn's repo-local Verse with the same SHA-256 while Bifrost publication remains missing. Launcher compact modes are now named compact operator-context modes instead of read-only modes, and `bifrost-public-proof` summaries print item, target public Verse, room, proof SHA-256, review receipts, and credit receipts so publication receipts are auditable without claiming upstream sync. - next_action: Continue the conceptual-substitution pass. Eight high-authority closure families are typed and guarded against regaining substring authority. The closure region still has 32 family branches and 744 substring assertions while closure_contracts.rs is 1,284 lines; do not substitute a blind struct forest for coherent ownership. Prioritize consequence-bearing request families, collapse shared syntax only when a named invariant earns it, and leave presentation-only markdown checks out of policy machinery. Operational/evidence/self-state and operator mirrors follow owned clocks; identity chains are typed; scheduling/runbook selection do not parse prose; verse-query smoke deletion is canonically confined; writerless readiness-review is deleted. Bifrost provider receipts still need provider chronology. Continue auditing destructive path consumers, evidence/security mirrors, and adapters for borrowed authority. + next_action: Continue the conceptual-substitution pass. Eight high-authority closure families are typed and guarded against regaining substring authority. The closure region still has 32 family branches and 744 substring assertions while closure_contracts.rs is 1,284 lines; do not substitute a blind struct forest for coherent ownership. Prioritize consequence-bearing request families, collapse shared syntax only when a named invariant earns it, and leave presentation-only markdown checks out of policy machinery. Repo-personality and verse-query smoke recursive deletion are canonically confined; continue auditing remaining smoke reset helpers for provenance substituted for resolved scope. Operational/evidence/self-state and operator mirrors follow owned clocks; identity chains are typed; scheduling/runbook selection do not parse prose; writerless readiness-review is deleted. Bifrost provider receipts still need provider chronology. Continue auditing evidence/security mirrors and adapters for borrowed authority.