Make Soul own closure verification

This commit is contained in:
Meta Vens 2026-07-12 23:31:59 +01:00
commit 497518160c
5 changed files with 25 additions and 26 deletions

View file

@ -277,9 +277,7 @@ struct CloseArgs {
execute_receipt: Option<PathBuf>,
runtime_store: Option<PathBuf>,
artifact_dir: Option<PathBuf>,
verification_command: Option<String>,
verification_summary: Option<String>,
require_source_grounding: bool,
state_revision: u64,
}
@ -841,9 +839,7 @@ fn parse_close_args(args: impl Iterator<Item = String>) -> Result<CloseArgs> {
let mut execute_receipt = None;
let mut runtime_store = None;
let mut artifact_dir = None;
let mut verification_command = None;
let mut verification_summary = None;
let mut require_source_grounding = false;
let mut state_revision = 0_u64;
let mut args = args.peekable();
@ -856,13 +852,9 @@ fn parse_close_args(args: impl Iterator<Item = String>) -> Result<CloseArgs> {
}
"--runtime-store" => runtime_store = Some(take_path(&mut args, "--runtime-store")?),
"--artifact-dir" => artifact_dir = Some(take_path(&mut args, "--artifact-dir")?),
"--verification-command" => {
verification_command = Some(take_string(&mut args, "--verification-command")?);
}
"--verification-summary" => {
verification_summary = Some(take_string(&mut args, "--verification-summary")?);
}
"--require-source-grounding" => require_source_grounding = true,
"--state-revision" => state_revision = take_u64(&mut args, "--state-revision")?,
other => return Err(anyhow!("unexpected close argument {other:?}")),
}
@ -873,9 +865,7 @@ fn parse_close_args(args: impl Iterator<Item = String>) -> Result<CloseArgs> {
execute_receipt,
runtime_store,
artifact_dir,
verification_command,
verification_summary,
require_source_grounding,
state_revision,
})
}
@ -6320,23 +6310,23 @@ fn closure_family_assertions(
let Some(plan_receipt_path) = path_from_json(execute_receipt, &["planReceiptPath"]) else {
return Ok((
json!({
"status": "skipped",
"status": "failed",
"reason": "execute receipt has no planReceiptPath",
"assertions": []
}),
true,
false,
));
};
let plan_receipt = read_json_if_exists(&plan_receipt_path)?.unwrap_or(Value::Null);
if plan_receipt.is_null() {
return Ok((
json!({
"status": "skipped",
"status": "failed",
"reason": "plan receipt path is missing",
"planReceiptPath": plan_receipt_path,
"assertions": []
}),
true,
false,
));
}
let safe_family = string_from_json(&plan_receipt, &["derivation", "safeActionFamily"])
@ -10976,9 +10966,7 @@ fn run_closure_pipeline(args: CloseArgs, phase: ClosurePhase) -> Result<Value> {
"execute receipt commit sha does not match runtime Hands commit receipt"
));
}
let verification_command = args
.verification_command
.unwrap_or_else(|| format!("git show --stat --oneline {commit_sha}"));
let verification_command = format!("git show --stat --oneline {commit_sha}");
let stdout_artifact = artifact_dir.join(format!("work-close-{item_slug}.stdout.log"));
let stderr_artifact = artifact_dir.join(format!("work-close-{item_slug}.stderr.log"));
let verification = Command::new("powershell")
@ -11023,7 +11011,7 @@ fn run_closure_pipeline(args: CloseArgs, phase: ClosurePhase) -> Result<Value> {
&verification.stdout,
&verification.stderr,
&commit_stat,
args.require_source_grounding,
true,
);
let verification_output_mentions_changed_paths = bool_from_json(
&verification_source_grounding,
@ -11075,7 +11063,7 @@ fn run_closure_pipeline(args: CloseArgs, phase: ClosurePhase) -> Result<Value> {
"commitStat": compact_multiline(&commit_stat),
"commitReceiptMatchedExecuteReceipt": true,
"verificationOutputMentionsChangedPaths": verification_output_mentions_changed_paths,
"sourceGroundingRequired": args.require_source_grounding,
"sourceGroundingRequired": true,
"mindAdoptionPassed": mind_adoption_passed,
"familyAssertionsPassed": family_assertions_passed,
"modelClosurePassed": false
@ -13866,9 +13854,7 @@ fn run_tick(args: TickArgs) -> Result<Value> {
execute_receipt: Some(execute_receipt_path.clone()),
runtime_store: Some(runtime_store.clone()),
artifact_dir: Some(artifact_dir.clone()),
verification_command: None,
verification_summary: None,
require_source_grounding: false,
state_revision: 0,
})?;
status = advanced_result["status"]
@ -13974,9 +13960,7 @@ fn run_tick(args: TickArgs) -> Result<Value> {
execute_receipt: Some(execute_receipt_path.clone()),
runtime_store: args.runtime_store.clone(),
artifact_dir: Some(artifact_dir.clone()),
verification_command: None,
verification_summary: None,
require_source_grounding: false,
state_revision: 0,
})?;
status = advanced_result
@ -15361,13 +15345,15 @@ mod authority_tests {
use epiphany_core::put_repo_work_modeling_finding;
#[test]
fn close_rejects_caller_authored_modeling_echoes() -> Result<()> {
fn close_rejects_caller_authored_verification_and_modeling_authority() -> Result<()> {
for flag in [
"--closure-model-ref",
"--closure-model-verdict",
"--closure-model-finding",
"--model-authored",
"--modeling-summary",
"--verification-command",
"--require-source-grounding",
] {
let error = parse_close_args([flag.to_string(), "counterfeit".to_string()].into_iter())
.expect_err("legacy Modeling echo must be refused");
@ -16208,7 +16194,7 @@ fn print_usage() {
run --workspace <repo> [--item <id>] [--accept-receipt <path>] [--runtime-store <path>] [--requested-path <path>]\n\
adopt --workspace <repo> [--item <id>] [--run-receipt <path>] [--from-plan <path>] [--plan-summary <text>] [--adoption-evidence-ref <ref>] [--mind-adoption-rationale <text>]\n\
execute --workspace <repo> [--item <id>] [--from-plan <path>] [--command <command>] [--changed-path <path>] [--commit-message <text>]\n\
close --workspace <repo> [--item <id>] [--execute-receipt <path>] [--verification-command <command>] [--require-source-grounding]\n\
close --workspace <repo> [--item <id>] [--execute-receipt <path>]\n\
overview --workspace <repo> [--item <id>] [--accept-receipt <path>] [--no-write]\n\
readiness --workspace <repo> [--item <id>] [--accept-receipt <path>] [--public-proof <path>] [--idunn-lifecycle-receipt <path>] [--deployment-aftercare-audit-receipt <path>|--deployment-aftercare-audit-receipt-ref <ref>] [--tool-directory-receipt <path>] [--no-write]\n\
deployment-config-audit --workspace <repo> [--artifact-dir <path>] [--no-write]\n\

View file

@ -381,3 +381,13 @@ the caller fields. The echo fields, review helper, scheduler transcription,
and usage surface are deleted. Full closure now loads the current immutable
Modeling finding directly and refuses absence; caller text cannot stand in for
the Modeling organ even temporarily.
## Caller-selected shell as Soul verification
`close --verification-command` let the caller choose the shell command whose
zero exit status contributed to Soul's verdict; source grounding was optional,
and a missing plan receipt made family assertions `skipped` but passing. The
command and grounding flags are deleted. Soul now performs a fixed Git
consequence inspection, requires source grounding, and fails closure when the
typed plan or its family evidence is missing. Callers may no longer redefine
verification as `exit 0` or obtain a pardon by omitting the plan.

View file

@ -94,6 +94,9 @@ The confirmed conceptual substitutions have been cut:
- repo closure no longer accepts caller echoes of Modeling model ref, verdict,
finding, authorship, or summary. The scheduler no longer transcribes them.
Full closure reads the immutable runtime-spine Modeling finding directly.
- repo closure no longer accepts caller-selected verification commands or an
optional source-grounding flag. Soul uses fixed Git consequence inspection,
mandatory grounding, and fails when typed plan/family evidence is absent.
The presentation boundary is now plain: `swarm overview` is a generic compact read-only projection. Gjallar is a downstream TUI application on Nightwing and is not an Epiphany organ, provider, owner, runtime, or architectural dependency. Eve/CultUI graphs may be lowered or composited downstream without Epiphany caring which presentation client does it.

Binary file not shown.

View file

@ -660,4 +660,4 @@ current_status:
- Service lifecycle receipt history is now event-only: `load_epiphany_cultmesh_daemon_service_lifecycle_receipts` filters out the `epiphany-local/daemon-service-lifecycle-receipt/latest` mirror, while `load_latest_epiphany_cultmesh_daemon_service_lifecycle_receipt` remains the latest-state reader. Focused unit test `service_lifecycle_receipt_history_excludes_latest_mirror` proves two per-receipt writes return exactly two history records and latest points at the second. Fresh smoke `verse-query-lifecycle-history-filter-smoke` and live overview/triage `local-20260618-145632-497-efac6f0d` / `local-20260618-145632-321-867947af` prove compact swarm sights still expose service lifecycle attention plus the present elevated runbook artifact without daemon pokes or service mutation. Do not use a broad unscoped cargo test filter for this check on Windows; it fans out across bin harnesses and hit a broken pipe during this pass.
- `epiphany-verse-query seed-compact` is the compact seed receipt for wrappers and read-only rites. The older `seed` command still prints the full local Verse context for explicit debugging, but compact wrapper modes now avoid full `seed`/final `query` readback after the combined overview proof exposed Windows debug stack overflow from full-context serialization pressure.
last_completed_repo_swarm_cut: Huginn live-fire has crossed the first real repo Body from Persona pressure to branch-local Hands commit and Soul/Mind closure, and now has repeatable closure and redacted-public-proof mouths. On `E:\Projects\Huginn` branch `epiphany/huginn/first-awakening`, `tools/epiphany_local_run.ps1 -Mode repo-persona-intake` accepted item `huginn-inspection-readback-livefire`, Weksa/Persona intake remained sealed, and `epiphany-work derive-plan` lowered it to model-authored safe family `repo.status_section` for `README.md` only. `tools/epiphany_local_run.ps1 -Mode repo-swarm-run` advanced four bounded pulses: run-from-plan, adopt-from-plan, execute-from-plan, and close-from-execute. Huginn commit `e9b07c38fceabbdc89ea35c2156326c80c0393a2` updated only `README.md`; closure receipt `.epiphany\work\work-close-huginn-inspection-readback-livefire.json` records status `closed`, Soul verdict `passed`, Mind state commit `repo-work-close-huginn-inspection-readback-livefire-mind-commit`, safe family `repo.status_section`, path scope `README.md`, Bifrost publication gate, and `privateStateExposed=false`. Verification also ran Huginn's TypeScript compiler through concrete Node path: `C:\Program Files\nodejs\node.exe E:\Projects\Huginn\node_modules\typescript\bin\tsc -p tsconfig.json` passed. Native verifier `epiphany-repo-livefire-closure-smoke --workspace E:\Projects\Huginn --item huginn-inspection-readback-livefire --expected-path README.md --expected-family repo.status_section --expected-gate awaiting-publication --expected-blocker bifrost-publication-missing` checks closure receipt, Mind map entry, overview gate/blocker, authority seals, and `git show` changed paths, returning `status=ok`, `soulVerdict=passed`, `publicationGate=Bifrost`, and `privateStateExposed=false`. Wrapper `tools/epiphany_local_run.ps1 -Mode repo-livefire-closure -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exposes the same read-only proof through the local operator mouth; artifact `local-20260621-190156-803-2f85ba15` printed commit, path, gate, blocker, Soul verdict, Mind commit receipt, and `privateStateExposed=False` without push, merge, publication, or target mutation. New wrapper `tools/epiphany_local_run.ps1 -Mode repo-work-public-proof -Workspace E:\Projects\Huginn -RepoWorkItem huginn-inspection-readback-livefire -SkipBuild` exports the redacted proof bundle and repo-local Verse index without publishing; artifact `local-20260621-190645-345-4555b1dc` wrote `.epiphany\public\proof-bundles\repo-work-public-proof-huginn-inspection-readback-livefire.json`, proof id `repo-work-public-proof-huginn-inspection-readback-livefire`, SHA-256 `857545b199f3e37eb06c2e757e5cfc201958e46667bb1f8403fd333a22620f63`, nine artifact rows, zero publication rows, and `privateStateExposed=False`. swarm overview readback `local-20260621-190701-140-b9519ec6` sees the `REPO-WORK-PUBLIC-PROOF` row and action row from Huginn's repo-local Verse with the same SHA-256 while Bifrost publication remains missing. Launcher compact modes are now named compact operator-context modes instead of read-only modes, and `bifrost-public-proof` summaries print item, target public Verse, room, proof SHA-256, review receipts, and credit receipts so publication receipts are auditable without claiming upstream sync.
next_action: Continue the conceptual-substitution modeling pass beyond receipt writers. Publication/PR/provider result authority is sealed, and repo closure now reads immutable Modeling findings directly instead of caller/scheduler echoes. Audit remaining public receipt writers by named owner, especially Mind/Soul/Substrate/Hands runtime writers and daemon lifecycle paths, then inventory projections, caches, adapters, schedulers, coordinators, and compatibility surfaces that assert facts owned elsewhere.
next_action: Continue the conceptual-substitution modeling pass beyond receipt writers. Publication/PR/provider result authority is sealed; closure reads immutable Modeling truth directly; Soul verification uses fixed grounded Git inspection and fails without typed plan/family evidence. Audit remaining public receipt writers by named owner, especially Mind/Substrate/Hands runtime writers and daemon lifecycle paths, then inventory projections, caches, adapters, schedulers, coordinators, and compatibility surfaces that assert facts owned elsewhere.