Remove app-server plugin routes

This commit is contained in:
Meta Vens 2026-05-13 16:07:02 +01:00
commit 473d22ac3d
6 changed files with 14 additions and 111 deletions

View file

@ -876,6 +876,13 @@ has ordinary app connector fields whose protocol shape mentions historical
`plugin_display_names`; those are connector metadata compatibility, not plugin
runtime authority.
The app-server plugin JSON-RPC verbs are gone too. `plugin/list`,
`plugin/read`, `plugin/install`, and `plugin/uninstall` are no longer
`ClientRequest` variants, no longer dispatch through `codex_message_processor.rs`,
and no longer have test-client helper senders. The old `Plugin*` data structs
remain only as inert protocol-shape residue for orphaned plugin crates such as
`core-plugins`; they are not live routes.
The Phase 6 freshness slice is landed. It exposes read-only
`thread/epiphany/freshness` from live retrieval summaries plus graph
frontier/churn state and, for loaded threads, watcher-backed invalidation

Binary file not shown.

View file

@ -309,6 +309,11 @@ current_status:
`codex-utils-plugins`. The TUI `/plugins` command and marketplace organ are
now deleted too: no slash command, plugin popup module, plugin AppEvent
variants, plugin background RPC helpers, plugin enablement queue, or
marketplace popup tests remain in `codex-tui`. MCP remains JSON-RPC at the
edge; user-declared MCP servers are the only runtime MCP authority.
marketplace popup tests remain in `codex-tui`. The app-server plugin JSON-RPC
route surface is no longer live either: `plugin/list`, `plugin/read`,
`plugin/install`, and `plugin/uninstall` were removed from the shared
`ClientRequest` protocol and from `codex_message_processor.rs`; only inert
legacy protocol structs remain for orphaned plugin crates. MCP remains
JSON-RPC at the edge; user-declared MCP servers are the only runtime MCP
authority.
next_action: Continue starving coordinator/runtime execution and operator surfaces off app-server JSON-RPC and out of `codex_message_processor.rs`; keep the vestigial Codex organ narrowed to subscription auth/model transport.

View file

@ -447,14 +447,6 @@ client_request_definitions! {
params: v2::MarketplaceRemoveParams,
response: v2::MarketplaceRemoveResponse,
},
PluginList => "plugin/list" {
params: v2::PluginListParams,
response: v2::PluginListResponse,
},
PluginRead => "plugin/read" {
params: v2::PluginReadParams,
response: v2::PluginReadResponse,
},
AppsList => "app/list" {
params: v2::AppsListParams,
response: v2::AppsListResponse,
@ -511,14 +503,6 @@ client_request_definitions! {
params: v2::SkillsConfigWriteParams,
response: v2::SkillsConfigWriteResponse,
},
PluginInstall => "plugin/install" {
params: v2::PluginInstallParams,
response: v2::PluginInstallResponse,
},
PluginUninstall => "plugin/uninstall" {
params: v2::PluginUninstallParams,
response: v2::PluginUninstallResponse,
},
TurnStart => "turn/start" {
params: v2::TurnStartParams,
inspect_params: true,

View file

@ -107,11 +107,6 @@ use codex_app_server_protocol::MockExperimentalMethodResponse;
use codex_app_server_protocol::ModelListParams;
use codex_app_server_protocol::ModelListResponse;
use codex_app_server_protocol::PermissionProfile as ApiPermissionProfile;
use codex_app_server_protocol::PluginInstallParams;
use codex_app_server_protocol::PluginListParams;
use codex_app_server_protocol::PluginListResponse;
use codex_app_server_protocol::PluginReadParams;
use codex_app_server_protocol::PluginUninstallParams;
use codex_app_server_protocol::RequestId;
use codex_app_server_protocol::ReviewDelivery as ApiReviewDelivery;
use codex_app_server_protocol::ReviewStartParams;
@ -1015,14 +1010,6 @@ impl CodexMessageProcessor {
self.marketplace_remove(to_connection_request_id(request_id), params)
.await;
}
ClientRequest::PluginList { request_id, params } => {
self.plugin_list(to_connection_request_id(request_id), params)
.await;
}
ClientRequest::PluginRead { request_id, params } => {
self.plugin_read(to_connection_request_id(request_id), params)
.await;
}
ClientRequest::AppsList { request_id, params } => {
self.apps_list(to_connection_request_id(request_id), params)
.await;
@ -1031,14 +1018,6 @@ impl CodexMessageProcessor {
self.skills_config_write(to_connection_request_id(request_id), params)
.await;
}
ClientRequest::PluginInstall { request_id, params } => {
self.plugin_install(to_connection_request_id(request_id), params)
.await;
}
ClientRequest::PluginUninstall { request_id, params } => {
self.plugin_uninstall(to_connection_request_id(request_id), params)
.await;
}
ClientRequest::TurnStart { request_id, params } => {
self.turn_start(
to_connection_request_id(request_id),
@ -6396,38 +6375,6 @@ impl CodexMessageProcessor {
.await;
}
async fn plugin_list(&self, request_id: ConnectionRequestId, _params: PluginListParams) {
self.outgoing
.send_response(
request_id,
PluginListResponse {
marketplaces: Vec::new(),
marketplace_load_errors: Vec::new(),
featured_plugin_ids: Vec::new(),
},
)
.await;
}
async fn plugin_read(&self, request_id: ConnectionRequestId, _params: PluginReadParams) {
self.send_codex_product_surface_disabled(request_id, "plugin/read")
.await;
}
async fn plugin_install(&self, request_id: ConnectionRequestId, _params: PluginInstallParams) {
self.send_codex_product_surface_disabled(request_id, "plugin/install")
.await;
}
async fn plugin_uninstall(
&self,
request_id: ConnectionRequestId,
_params: PluginUninstallParams,
) {
self.send_codex_product_surface_disabled(request_id, "plugin/uninstall")
.await;
}
async fn skills_config_write(
&self,
request_id: ConnectionRequestId,

View file

@ -53,10 +53,6 @@ use codex_app_server_protocol::McpResourceReadParams;
use codex_app_server_protocol::McpServerToolCallParams;
use codex_app_server_protocol::MockExperimentalMethodParams;
use codex_app_server_protocol::ModelListParams;
use codex_app_server_protocol::PluginInstallParams;
use codex_app_server_protocol::PluginListParams;
use codex_app_server_protocol::PluginReadParams;
use codex_app_server_protocol::PluginUninstallParams;
use codex_app_server_protocol::RequestId;
use codex_app_server_protocol::ReviewStartParams;
use codex_app_server_protocol::SendAddCreditsNudgeEmailParams;
@ -565,42 +561,6 @@ impl McpProcess {
self.send_request("marketplace/remove", params).await
}
/// Send a `plugin/install` JSON-RPC request.
pub async fn send_plugin_install_request(
&mut self,
params: PluginInstallParams,
) -> anyhow::Result<i64> {
let params = Some(serde_json::to_value(params)?);
self.send_request("plugin/install", params).await
}
/// Send a `plugin/uninstall` JSON-RPC request.
pub async fn send_plugin_uninstall_request(
&mut self,
params: PluginUninstallParams,
) -> anyhow::Result<i64> {
let params = Some(serde_json::to_value(params)?);
self.send_request("plugin/uninstall", params).await
}
/// Send a `plugin/list` JSON-RPC request.
pub async fn send_plugin_list_request(
&mut self,
params: PluginListParams,
) -> anyhow::Result<i64> {
let params = Some(serde_json::to_value(params)?);
self.send_request("plugin/list", params).await
}
/// Send a `plugin/read` JSON-RPC request.
pub async fn send_plugin_read_request(
&mut self,
params: PluginReadParams,
) -> anyhow::Result<i64> {
let params = Some(serde_json::to_value(params)?);
self.send_request("plugin/read", params).await
}
/// Send an `mcpServerStatus/list` JSON-RPC request.
pub async fn send_list_mcp_server_status_request(
&mut self,