#nullable enable using System; using System.Linq; using GameCult.Caching; using NUnit.Framework; namespace GameCult.Networking.Tests { // CultNet typed selection, Cut 1, second Hands pass on the fix batch (docs/cultnet-selection-cut.md, // "Self's rulings for the Cut 1 fix batch" and "The C# half of the fix batch landed"): regression // tests for the rules the first Hands pass fixed but left proven only by 7903853..3d32c67's own // (unnamed, un-mutated) coverage or, for R-E's cites.target.schemaId door refusal, left entirely // unimplemented. Independent of any live server/client transport, same style as // CultNetSelectionEvaluatorTests - a hand-built row set against CultNetSelectionEvaluator directly. // Reuses CultNetSelectionEvaluatorTests' public fixture types (SelLeafA/SelLeafB/SelFixtureMiddle/ // SelCiter/SelCiterNarrow) rather than declaring a fourth near-identical set. public sealed class CultNetSelectionFixBatchTests { private static CultDocumentRegistry Registry() => CultDocumentRegistry.ForTypes(new[] { typeof(CultNetSelectionEvaluatorTests.SelLeafA), typeof(CultNetSelectionEvaluatorTests.SelLeafB), typeof(CultNetSelectionEvaluatorTests.SelCiter) }); private static CultNetSelectionEvaluator.Row Row(CultDocumentRegistry registry, object document, string key, long ordinal) => new(registry.GetRequired(document.GetType()), new CultRecordKey(key), document, ordinal); // R-B: edges are anchored to the row the hop direction actually reports against - the cited row // under `cited`, not the citer - and edge order is deterministic: page-row order, then // (from, role, to) in code-point order. Two citers citing the same target through the same role // put two edges on one page row (`target`), so only a real (from, role, to) tie-break - not // insertion order - can produce "citer-a" before "citer-b". [Test] public void Evaluator_AnchorsCitedEdgesToTheCitedRowAndOrdersThemByFromThenRole() { var registry = Registry(); var target = new CultNetSelectionEvaluatorTests.SelLeafA { Name = "target", Kind = "k", Mass = 1 }; var citerB = new CultNetSelectionEvaluatorTests.SelCiter { Name = "b", Design = new CultRecordRef(new CultRecordKey("target")) }; var citerA = new CultNetSelectionEvaluatorTests.SelCiter { Name = "a", Design = new CultRecordRef(new CultRecordKey("target")) }; // Supplied out of code-point order (b before a) on purpose - the assertion only passes if // EdgesFor's own tie-break sorts them, not if it merely preserves row-supply order. var rows = new[] { Row(registry, target, "target", 1), Row(registry, citerB, "citer-b", 2), Row(registry, citerA, "citer-a", 3) }; var selection = new CultNetSelection { Schemas = new[] { registry.GetRequired().SchemaId }, Cited = new CultNetIncoming { Role = "Design", Exists = true } }; var evaluation = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1); Assert.That(evaluation.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { "target" })); // Anchor: both edges must be reported (dropped entirely if wrongly anchored to the citer, // which is not on this page under `cited`). Assert.That(evaluation.Edges.Select(e => e.From.Key.Value), Is.EqualTo(new[] { "citer-a", "citer-b" })); Assert.That(evaluation.Edges.All(e => e.To.Key.Value == "target"), Is.True); } // R-C: every ordered comparison the vocabulary makes uses Unicode code-point order, not UTF-16 // code-unit order. U+E000 (BMP private use) sorts before U+1F602 (astral, "😂") in code-point // order despite the astral character's leading UTF-16 surrogate (0xD83D) being numerically // smaller than 0xE000 - a code-unit ("ordinal") compare sorts it the other way. private const string BmpKey = "-row"; private const string AstralKey = "😂-row"; [Test] public void Evaluator_OrdersAstralKeysByCodePointNotUtf16CodeUnit() { var registry = Registry(); var rows = new[] { Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "astral", Kind = "k", Mass = 1 }, AstralKey, 1), Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "bmp", Kind = "k", Mass = 1 }, BmpKey, 1) }; var evaluation = CultNetSelectionEvaluator.Select(registry, rows, new CultNetSelection(), asOf: 1); Assert.That(evaluation.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { BmpKey, AstralKey })); } // R-C, the cursor half: the cursor's position search must compare by the same code-point order // the row tiebreak uses, or a page walk over astral/BMP-boundary keys can skip or repeat rows. [Test] public void Evaluator_CursorPositionUsesCodePointOrderMatchingTheRowTiebreak() { var registry = Registry(); var rows = new[] { Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "astral", Kind = "k", Mass = 1 }, AstralKey, 1), Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "bmp", Kind = "k", Mass = 1 }, BmpKey, 1) }; var selection = new CultNetSelection { Limit = 1 }; var first = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1); Assert.That(first.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { BmpKey })); Assert.That(first.NextCursor, Is.Not.Null); selection.Cursor = first.NextCursor; var second = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1); Assert.That(second.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { AstralKey })); } // R-E: cites.target.schemaId is matched through the same alias matcher `schemas` uses (a // SchemaName, not only the real content-hash SchemaId), and a target whose schema matches // nothing declared is refused at the door - never answered with a quietly empty page. [Test] public void Evaluator_MatchesCitesTargetThroughTheAliasMatcher() { var registry = Registry(); var target = new CultNetSelectionEvaluatorTests.SelLeafA { Name = "target", Kind = "k", Mass = 1 }; var citer = new CultNetSelectionEvaluatorTests.SelCiter { Name = "citer", Design = new CultRecordRef(new CultRecordKey("target")) }; var rows = new[] { Row(registry, target, "target", 1), Row(registry, citer, "citer", 2) }; var alias = registry.GetRequired().SchemaName; var selection = new CultNetSelection { Cites = new CultNetCitation { Target = new CultNetRecordRef { SchemaId = alias, RecordKey = "target" } } }; var evaluation = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1); Assert.That(evaluation.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { "citer" })); } [Test] public void Validation_RefusesACitesTargetSchemaThatMatchesNoDeclaredSchema() { var descriptors = Registry().AllDescriptors.ToArray(); var selection = new CultNetSelection { Cites = new CultNetCitation { Target = new CultNetRecordRef { SchemaId = "no-such-schema", RecordKey = "target" } } }; var ex = Assert.Throws(() => selection.Validate(descriptors)); Assert.That(ex!.Field, Is.EqualTo("cites.target.schemaId")); } // R-E: cites.target.schemaId is resolved against every declared schema, not only the schemas // `selection.Schemas` itself reaches - a cites target is a separate structural reference, not // filtered by the selection's own schema allowlist. A plausible weaker implementation reuses the // `reachable` set already computed for Fields validation and wrongly refuses a valid target whose // schema sits outside it. [Test] public void Validation_ResolvesACitesTargetSchemaEvenWhenNotInTheSelectionsOwnSchemasFilter() { var registry = Registry(); var descriptors = registry.AllDescriptors.ToArray(); var citerSchemaId = registry.GetRequired().SchemaId; var leafAlias = registry.GetRequired().SchemaName; var selection = new CultNetSelection { Schemas = new[] { citerSchemaId }, Cites = new CultNetCitation { Target = new CultNetRecordRef { SchemaId = leafAlias, RecordKey = "target" } } }; Assert.DoesNotThrow(() => selection.Validate(descriptors)); } // R-F: the door is inside Select/EvaluateAll unconditionally - there is no public entry point // that evaluates a selection without validating it first. [Test] public void Evaluator_SelectValidatesFirstAndNeverAnswersAnInvalidSelection() { var registry = Registry(); var rows = new[] { Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "a", Kind = "k", Mass = 1 }, "a", 1) }; var invalid = new CultNetSelection { Schemas = Array.Empty() }; Assert.Throws(() => CultNetSelectionEvaluator.Select(registry, rows, invalid, asOf: 1)); } // R-H: the cursor digest length-prefixes every string and list, so no delimiter choice can make // two different selections collide. The pre-fix scheme joined keys with "," and a field // predicate's values with "|" with no length prefix - Keys=["a,b"] (one string containing a // literal comma) digested the same as Keys=["a","b"] (two strings), and a field's // Values=["a|b"] digested the same as Values=["a","b"]. [Test] public void ComputeDigest_DoesNotCollideOnDelimiterAmbiguousKeysOrFieldValues() { var keysOne = new CultNetSelection { Keys = new[] { "a,b" } }; var keysTwo = new CultNetSelection { Keys = new[] { "a", "b" } }; Assert.That( CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", keysOne), Is.Not.EqualTo(CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", keysTwo))); var valuesOne = new CultNetSelection { Fields = new[] { new CultNetFieldPredicate { Index = "kind", Op = "any_of", Values = new[] { "a|b" } } } }; var valuesTwo = new CultNetSelection { Fields = new[] { new CultNetFieldPredicate { Index = "kind", Op = "any_of", Values = new[] { "a", "b" } } } }; Assert.That( CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", valuesOne), Is.Not.EqualTo(CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", valuesTwo))); } // S5-DigestNoFields (fix batch 3 "Surviving mutants"): the digest reads selection.Fields - a // mutant that drops the fields loop would digest two selections identically as long as their // schemas/keys/hop/projection agree, letting a cursor minted for one selection page a // differently-fielded one. [Test] public void ComputeDigest_DiffersWhenOnlyFieldsDiffer() { var withFieldA = new CultNetSelection { Fields = new[] { new CultNetFieldPredicate { Index = "kind", Op = "any_of", Values = new[] { "a" } } } }; var withFieldB = new CultNetSelection { Fields = new[] { new CultNetFieldPredicate { Index = "kind", Op = "any_of", Values = new[] { "b" } } } }; var noFields = new CultNetSelection(); Assert.That( CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", withFieldA), Is.Not.EqualTo(CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", withFieldB))); Assert.That( CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", withFieldA), Is.Not.EqualTo(CultNetSelectionCursor.ComputeDigest(0, 0, "s", "k", noFields))); } // R-O (fix batch 3, F6 "cursors are keyed"): a cursor's digest is an HMAC under the answering // process's key - a page request carrying a cursor minted under a different key (forged, or // minted by a different process) is refused cursor_invalid, never answered. [Test] public void Page_RefusesACursorMintedUnderADifferentKey() { var registry = Registry(); var rows = Enumerable.Range(0, 3) .Select(i => Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = $"n{i}", Kind = "k", Mass = i }, $"k{i}", i)) .ToArray(); var selection = new CultNetSelection { Limit = 1 }; var mintingKey = CultNetSelectionCursorKey.Random(); var otherKey = CultNetSelectionCursorKey.Random(); var first = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: mintingKey); Assert.That(first.NextCursor, Is.Not.Null); selection.Cursor = first.NextCursor; var ex = Assert.Throws( () => CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: otherKey)); Assert.That(ex!.Code, Is.EqualTo("cursor_invalid")); } // R-O: a cursor minted before a (simulated) restart does not verify against the restarted // process's fresh key - the same refusal as a forged cursor, because from the answering // process's point of view they are indistinguishable (F6: "not surviving a restart is the // accepted cost, not a bug"). [Test] public void Page_RefusesACursorMintedBeforeARestart() { var registry = Registry(); var rows = Enumerable.Range(0, 3) .Select(i => Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = $"n{i}", Kind = "k", Mass = i }, $"k{i}", i)) .ToArray(); var selection = new CultNetSelection { Limit = 1 }; var preRestartKey = CultNetSelectionCursorKey.Random(); var first = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: preRestartKey); Assert.That(first.NextCursor, Is.Not.Null); // A restart is a fresh process key, exactly as CultNetDatabase's constructor mints a fresh // CursorKey per instance unless one is supplied. var postRestartKey = CultNetSelectionCursorKey.Random(); selection.Cursor = first.NextCursor; var ex = Assert.Throws( () => CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: postRestartKey)); Assert.That(ex!.Code, Is.EqualTo("cursor_invalid")); } // R-Y (fix batch 4, Soul's P4 "forged cursor position, reused digest"): before this, the HMAC // covered only the selection, not the cursor's own body - so a forged cursor could keep a // legitimately minted digest and rewrite the ordinal (or schemaId/recordKey) underneath it, and // the server would page from wherever the forged position named instead of refusing it. [Test] public void Page_RefusesAForgedCursorThatReusesALegitimateDigestUnderARewrittenOrdinal() { var registry = Registry(); var rows = Enumerable.Range(0, 3) .Select(i => Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = $"n{i}", Kind = "k", Mass = i }, $"k{i}", i)) .ToArray(); var selection = new CultNetSelection { Limit = 1 }; var key = CultNetSelectionCursorKey.Random(); var first = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: key); Assert.That(first.NextCursor, Is.Not.Null); var legitimate = CultNetSelectionCursor.Parse(first.NextCursor!); var forged = ForgeCursorBody(legitimate.AsOf, ordinal: 999, legitimate.SchemaId, legitimate.RecordKey, legitimate.Digest); Assert.That(forged, Is.Not.EqualTo(first.NextCursor), "the forged cursor must actually differ from the legitimate one"); selection.Cursor = forged; var ex = Assert.Throws( () => CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: key)); Assert.That(ex!.Code, Is.EqualTo("cursor_invalid")); } /// /// Builds a cursor string carrying an arbitrary body under a caller-supplied digest, the same /// wire shape produces - used to simulate a forged /// cursor that reuses a legitimately minted digest under a rewritten body (R-Y). /// private static string ForgeCursorBody(ulong asOf, long ordinal, string schemaId, string recordKey, string digest) { var body = new System.Text.StringBuilder(); void AppendString(string value) => body.Append(System.Text.Encoding.UTF8.GetByteCount(value)).Append(':').Append(value); AppendString(asOf.ToString(System.Globalization.CultureInfo.InvariantCulture)); AppendString(ordinal.ToString(System.Globalization.CultureInfo.InvariantCulture)); AppendString(schemaId); AppendString(recordKey); AppendString(digest); var bytes = System.Text.Encoding.UTF8.GetBytes(body.ToString()); return Convert.ToBase64String(bytes).TrimEnd('=').Replace('+', '-').Replace('/', '_'); } // R-O: the cursor body is length-prefixed, not delimiter-joined, so a record key carrying any // character at all - including U+241F, which broke the pre-fix delimiter-split parse - round-trips. [Test] public void Cursor_RoundTripsARecordKeyContainingU241F() { var registry = Registry(); var weirdKey = "row-␟-two"; var rows = new[] { Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "a", Kind = "k", Mass = 0 }, "a-first", 0), Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "b", Kind = "k", Mass = 1 }, weirdKey, 1) }; var selection = new CultNetSelection { Limit = 1 }; var key = CultNetSelectionCursorKey.Random(); var first = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: key); Assert.That(first.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { "a-first" })); Assert.That(first.NextCursor, Is.Not.Null); selection.Cursor = first.NextCursor; var second = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1, cursorKey: key); Assert.That(second.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { weirdKey })); Assert.That(second.NextCursor, Is.Null); } // R-J: any_of on a numeric alias compares TryGetIndexNumber's canonical rendering, not the // string getter's culture-dependent ToString() - a float large enough that .NET's default // ToString() renders exponent notation ("1E+21") must still match its canonical decimal form. [Test] public void Evaluator_AnyOfOnANumericAliasComparesTheCanonicalRenderingNotToString() { var registry = Registry(); var row = new CultNetSelectionEvaluatorTests.SelLeafA { Name = "big", Kind = "k", Mass = 1e21f }; var rows = new[] { Row(registry, row, "big", 1) }; var descriptor = registry.GetRequired(); Assert.That(descriptor.TryGetIndexNumber(row, "mass", out var canonical), Is.True); // .NET's default ToString() on this magnitude renders exponent notation ("1E+21"); the // canonical decimal never does - if the two happened to be textually equal this assertion, // not the mutant, would be the problem, so pin that precondition rather than assume it. Assert.That(canonical, Does.Not.Contain("E")); Assert.That(row.Mass.ToString(System.Globalization.CultureInfo.InvariantCulture), Is.Not.EqualTo(canonical)); var selection = new CultNetSelection { Fields = new[] { new CultNetFieldPredicate { Index = "mass", Op = "any_of", Values = new[] { canonical! } } } }; var evaluation = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1); Assert.That(evaluation.Rows.Select(r => r.Key.Value), Is.EqualTo(new[] { "big" })); } private static CultDocumentRegistry NarrowAndManyRegistry() => CultDocumentRegistry.ForTypes(new[] { typeof(CultNetSelectionEvaluatorTests.SelLeafA), typeof(CultNetSelectionEvaluatorTests.SelLeafB), typeof(CultNetSelectionEvaluatorTests.SelCiterNarrow), typeof(CultNetSelectionEvaluatorTests.SelCiterManyUntyped) }); // R-V (S-1, Soul's P2 "two schemas at one key"): a row's identity is (schemaId, recordKey), not // the record key alone. SelLeafA and SelLeafB rows both live at key "k"; SelCiterNarrow's // NarrowRef is declared to SelLeafA only, so it must always resolve to the SelLeafA row at "k", // never the SelLeafB one - regardless of which of the two same-keyed rows a bare-key dictionary // would have kept. Before this, byKey was a bare-key dictionary that kept only one of them (last // writer wins), so which row NarrowRef resolved to - and therefore whether the selection matched // or refused reference_outside_target - depended on row insertion order. [TestCase(false)] [TestCase(true)] public void Evaluator_CitedResolvesARowSharingItsKeyWithAnotherSchema_ByDeclaredTargetNotInsertionOrder(bool reverseRowOrder) { var registry = NarrowAndManyRegistry(); var leafA = Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "a", Kind = "k", Mass = 1 }, "k", 0); var leafB = Row(registry, new CultNetSelectionEvaluatorTests.SelLeafB { Name = "b", Kind = "k", Mass = 1 }, "k", 1); var citer = Row(registry, new CultNetSelectionEvaluatorTests.SelCiterNarrow { Name = "citer", NarrowRef = new CultRecordRef(new CultRecordKey("k")) }, "citer", 2); var rows = reverseRowOrder ? new[] { citer, leafB, leafA } : new[] { citer, leafA, leafB }; var selection = new CultNetSelection { Cited = new CultNetIncoming { Role = "NarrowRef", Exists = true } }; var evaluation = CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1); // Only the SelLeafA row at "k" is cited - SelLeafB's row at the same key is a different // identity and must not match, in either row order. Assert.That(evaluation.Rows.Select(r => (r.Descriptor.SchemaId, r.Key.Value)), Is.EqualTo(new[] { (registry.GetRequired().SchemaId, "k") })); } // R-W (S-2, Soul's P3): EnsureWithinDeclaredTarget's equivalent check must run for every edge a // many-reference carries, before the citation's own key filters that edge out - not only for the // edge the citation happens to be asking about. SelCiterManyUntyped.ManyRefs is (by inference, // R-T(b)) declared to SelLeafA alone; one element points at a SelLeafA row (in-target) and a // second at a SelLeafB row (out-of-target). Querying `cites` for a record key neither element // carries must still refuse: the out-of-target edge is wrong regardless of what the caller asked. [Test] public void Evaluator_CitesRefusesAnOutOfTargetEdgeEvenWhenTheQueriedKeyMatchesNeitherEdge() { var registry = NarrowAndManyRegistry(); var leafA = Row(registry, new CultNetSelectionEvaluatorTests.SelLeafA { Name = "a", Kind = "k", Mass = 1 }, "a", 0); var leafB = Row(registry, new CultNetSelectionEvaluatorTests.SelLeafB { Name = "b", Kind = "k", Mass = 1 }, "b", 1); var citer = Row(registry, new CultNetSelectionEvaluatorTests.SelCiterManyUntyped { Name = "citer", ManyRefs = new[] { new CultRecordRef(new CultRecordKey("a")), new CultRecordRef(new CultRecordKey("b")) } }, "citer", 2); var rows = new[] { leafA, leafB, citer }; var selection = new CultNetSelection { Cites = new CultNetCitation { Target = new CultNetRecordRef { SchemaId = registry.GetRequired().SchemaId, RecordKey = "does-not-exist" }, Role = "ManyRefs" } }; var ex = Assert.Throws( () => CultNetSelectionEvaluator.Select(registry, rows, selection, asOf: 1)); Assert.That(ex!.ToSchemaId, Is.EqualTo(registry.GetRequired().SchemaId)); Assert.That(ex.ToKey, Is.EqualTo("b")); } } }